From: Paolo Bonzini <pbonzini@redhat.com>
To: Juergen Gross <jgross@suse.com>,
Maran Wilson <maran.wilson@oracle.com>,
boris.ostrovsky@oracle.com, roger.pau@citrix.com,
andrew.cooper3@citrix.com, hch@infradead.org, JBeulich@suse.com,
x86@kernel.org, xen-devel@lists.xenproject.org,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, rkrcmar@redhat.com
Subject: Re: [RFC PATCH v3 2/2] KVM: x86: Allow Qemu/KVM to use PVH entry point
Date: Fri, 15 Dec 2017 18:25:34 +0100 [thread overview]
Message-ID: <72846976-b3c3-ceca-8168-d50bcad5993e@redhat.com> (raw)
In-Reply-To: <d63fa041-ce36-3c1b-3d8b-87b4c5c4b84f@suse.com>
On 15/12/2017 16:55, Juergen Gross wrote:
> I'm fine with the general idea.
>
> I'm wondering whether you really want to require CONFIG_XEN for the
> KVM case, though.
>
> Wouldn't it be better to rename arch/x86/xen/enlighten_pvh.c to
> arch/x86/pvh.c and arch/x86/xen/xen-pvh.S to arch/x86/pvh-head.S,
Yes, sounds good.
> put both under CONFIG_PVH umbrella and select this from CONFIG_XEN_PVH
> and KVM_PVH (or what you like to call it)?
CONFIG_KVM_GUEST will be good enough.
> In the two moved source files you can make Xen/KVM-specific parts
> optional via their CONFIG_ options.
>
> And you might want to add an own ELF note for the KVM case?
As long as it's compatible with Xen, it's not needed. Only the startup
code changes between a KVM "PVH" kernel and a KVM "HVM" kernel.
Paolo
prev parent reply other threads:[~2017-12-15 17:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 23:42 [RFC PATCH v3 0/2] " Maran Wilson
2017-12-12 23:42 ` [RFC PATCH v3 1/2] xen/pvh: Add memory map pointer to hvm_start_info struct Maran Wilson
2017-12-12 23:42 ` [RFC PATCH v3 2/2] KVM: x86: Allow Qemu/KVM to use PVH entry point Maran Wilson
2017-12-15 15:55 ` Juergen Gross
2017-12-15 17:25 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72846976-b3c3-ceca-8168-d50bcad5993e@redhat.com \
--to=pbonzini@redhat.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=hch@infradead.org \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maran.wilson@oracle.com \
--cc=mingo@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=roger.pau@citrix.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®