From: Bryan O'Donoghue <bod@kernel.org>
To: Wangao Wang <wangao.wang@oss.qualcomm.com>,
Vikash Garodia <vikash.garodia@oss.qualcomm.com>,
Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Neil Armstrong <neil.armstrong@linaro.org>,
quic_qiweil@quicinc.com, quic_renjiang@quicinc.com
Subject: Re: [PATCH v5 2/6] media: qcom: iris: Improve crop_offset handling for encoder
Date: Thu, 13 Nov 2025 09:37:17 +0000 [thread overview]
Message-ID: <72850fb4-a808-4cb7-98dd-b7d280f575ad@kernel.org> (raw)
In-Reply-To: <20251110-iris_encoder_enhancements-v5-2-1dbb19968bd5@oss.qualcomm.com>
On 10/11/2025 10:23, Wangao Wang wrote:
> The setting of HFI_PROP_CROP_OFFSETS for the OUTPUT port is correct,
> but on the CAPTURE port it is used to inform the firmware about the
> ROI, so crop_offset needs to be handled accordingly.
What is ROI ?
Please define this term in your commit log.
---
bod
next prev parent reply other threads:[~2025-11-13 9:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <_qCcVDgw74JJZnRLeyRvD2E58cceoefsZacP0u2-J04hcDEH3Sh1Aeglq-VSWqfWFEx1IdwZDcwsQeQOO4m8yA==@protonmail.internalid>
2025-11-10 10:23 ` [PATCH v5 0/6] media: qcom: iris: encoder feature enhancements Wangao Wang
2025-11-10 10:23 ` [PATCH v5 1/6] media: qcom: iris: Improve format alignment for encoder Wangao Wang
2025-11-10 13:52 ` Dikshita Agarwal
2025-11-13 9:35 ` Bryan O'Donoghue
2025-11-10 10:23 ` [PATCH v5 2/6] media: qcom: iris: Improve crop_offset handling " Wangao Wang
2025-11-13 5:42 ` Dikshita Agarwal
2025-11-13 9:37 ` Bryan O'Donoghue [this message]
2025-11-10 10:23 ` [PATCH v5 3/6] media: qcom: iris: Add scale support " Wangao Wang
2025-11-10 13:54 ` Dikshita Agarwal
2025-11-13 9:50 ` Bryan O'Donoghue
2025-11-10 10:23 ` [PATCH v5 4/6] media: qcom: iris: Add rotation " Wangao Wang
2025-11-10 10:23 ` [PATCH v5 5/6] media: qcom: iris: Add flip " Wangao Wang
2025-11-10 10:23 ` [PATCH v5 6/6] media: qcom: iris: Add intra refresh " Wangao Wang
2025-11-13 10:05 ` [PATCH v5 0/6] media: qcom: iris: encoder feature enhancements Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72850fb4-a808-4cb7-98dd-b7d280f575ad@kernel.org \
--to=bod@kernel.org \
--cc=abhinav.kumar@linux.dev \
--cc=dikshita.agarwal@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_qiweil@quicinc.com \
--cc=quic_renjiang@quicinc.com \
--cc=vikash.garodia@oss.qualcomm.com \
--cc=wangao.wang@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®