Re: [PATCH] Documentation: add ABI entry for intel_pstate

["Rafael J. Wysocki" <rjw@rjwysocki.net>]

On Monday, January 06, 2014 02:01:17 PM Ramkumar Ramachandra wrote:
> Add a Documentation/ABI entry for
> /sys/devices/system/cpu/intel_pstate/max_perf_pct,
> /sys/devices/system/cpu/intel_pstate/min_perf_pct, and
> /sys/devices/system/cpu/intel_pstate/no_turbo.
> 
> Cc: Dirk Brandewie <dirk.brandewie@gmail.com>
> Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
> Cc: Randy Dunlap <rdunlap@infradead.org>
> Cc: Linux PM <linux-pm@vger.kernel.org>
> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
> ---
>  Documentation/ABI/testing/sysfs-devices-system-cpu | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/Documentation/ABI/testing/sysfs-devices-system-cpu b/Documentation/ABI/testing/sysfs-devices-system-cpu
> index 468e4d4..7080718 100644
> --- a/Documentation/ABI/testing/sysfs-devices-system-cpu
> +++ b/Documentation/ABI/testing/sysfs-devices-system-cpu
> @@ -200,3 +200,18 @@ Description:	address and size of the percpu note.
>  		note of cpu#.
>  
>  		crash_notes_size: size of the note of cpu#.
> +
> +
> +What:		/sys/devices/system/cpu/intel_pstate/max_perf_pct
> +		/sys/devices/system/cpu/intel_pstate/min_perf_pct
> +		/sys/devices/system/cpu/intel_pstate/no_turbo

Well, can you please describe each of them separately?  Like what each of them
actually does?

> +Date:		February 2013
> +Contact:	linux-pm@vger.kernel.org
> +Description:	Parameters for the Intel P-state driver
> +
> +		Logic for selecting the current P-state in Intel
> +		Sandybridge+ processors. The three knobs control
> +		limits for the P-state that will be requested by the
> +		driver.
> +
> +		More details can be found in Documentation/cpu-freq/intel-pstate.txt

No, that's not enough.

Thanks!

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.