From: Song Liu <songliubraving@fb.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Netdev <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"ast@kernel.org" <ast@kernel.org>,
"daniel@iogearbox.net" <daniel@iogearbox.net>,
Kernel Team <Kernel-team@fb.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"acme@redhat.com" <acme@redhat.com>
Subject: Re: [PATCH 5/9] perf, bpf: save bpf_prog_info in a rbtree in perf_env
Date: Thu, 14 Feb 2019 17:01:48 +0000 [thread overview]
Message-ID: <728C11EA-0862-47A8-AF0E-BEBA77FC5FF4@fb.com> (raw)
In-Reply-To: <20190214122638.GD26714@krava>
> On Feb 14, 2019, at 4:26 AM, Jiri Olsa <jolsa@redhat.com> wrote:
>
> On Fri, Feb 08, 2019 at 05:17:01PM -0800, Song Liu wrote:
>
> SNIP
>
>> diff --git a/tools/perf/util/env.h b/tools/perf/util/env.h
>> index d01b8355f4ca..5894a177b7cf 100644
>> --- a/tools/perf/util/env.h
>> +++ b/tools/perf/util/env.h
>> @@ -3,7 +3,10 @@
>> #define __PERF_ENV_H
>>
>> #include <linux/types.h>
>> +#include <linux/rbtree.h>
>> #include "cpumap.h"
>> +#include "rwsem.h"
>> +#include "bpf-event.h"
>>
>> struct cpu_topology_map {
>> int socket_id;
>> @@ -64,6 +67,8 @@ struct perf_env {
>> struct memory_node *memory_nodes;
>> unsigned long long memory_bsize;
>> u64 clockid_res_ns;
>> + struct rw_semaphore bpf_info_lock;
>
> why's the lock needed?
>
> jirka
It protects the retries for bpf_prog_info and btf. For perf-top,
we will have one thread writing to the trees, while the main
thread reading from them.
Let me add comments to clarify.
Thanks,
Song
next prev parent reply other threads:[~2019-02-14 17:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-09 1:16 [PATCH 0/9] perf annotation of BPF programs Song Liu
2019-02-09 1:16 ` [PATCH 1/9] perf, bpf: consider events with attr.bpf_event as side-band events Song Liu
2019-02-09 1:16 ` [PATCH 2/9] bpf: libbpf: introduce bpf_program__get_prog_info_linear() Song Liu
2019-02-09 1:16 ` [PATCH 3/9] bpf: bpftool: use bpf_program__get_prog_info_linear() in prog.c:do_dump() Song Liu
2019-02-09 1:17 ` [PATCH 4/9] perf, bpf: synthesize bpf events with bpf_program__get_prog_info_linear() Song Liu
2019-02-09 1:17 ` [PATCH 5/9] perf, bpf: save bpf_prog_info in a rbtree in perf_env Song Liu
2019-02-14 12:26 ` Jiri Olsa
2019-02-14 17:01 ` Song Liu [this message]
2019-02-14 12:33 ` Jiri Olsa
2019-02-14 17:03 ` Song Liu
2019-02-15 7:41 ` Jiri Olsa
2019-02-11 18:54 ` [PATCH 0/9] perf annotation of BPF programs Arnaldo Carvalho de Melo
2019-02-11 20:10 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=728C11EA-0862-47A8-AF0E-BEBA77FC5FF4@fb.com \
--to=songliubraving@fb.com \
--cc=Kernel-team@fb.com \
--cc=acme@redhat.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®