From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Terry Chen <terry_chen@wistron.corp-partner.google.com>,
alsa-devel@alsa-project.org
Cc: cezary.rojewski@intel.com, liam.r.girdwood@linux.intel.com,
yang.jie@linux.intel.com, broonie@kernel.org, perex@perex.cz,
tiwai@suse.com, brent.lu@intel.com, cujomalainey@chromium.org,
seanpaul@chromium.org, casey.g.bowman@intel.com,
mark_hsieh@wistron.corp-partner.google.com,
vamshi.krishna.gopal@intel.com, mac.chiang@intel.com,
kai.vehmanen@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [v7] FROMLIST: ASoC: Intel: sof_cs42l42: adding support for ADL configuration and BT offload audio
Date: Wed, 18 May 2022 08:32:17 -0500 [thread overview]
Message-ID: <728c697b-0df7-3d95-10cb-ce0111f0017b@linux.intel.com> (raw)
In-Reply-To: <20220518033200.1471841-1-terry_chen@wistron.corp-partner.google.com>
> + {
> + .id = "10134242",
> + .drv_name = "adl_mx98360a_cs4242",
> + .machine_quirk = snd_soc_acpi_codec_list,
> + .quirk_data = &adl_max98360a_amp,
> + .sof_tplg_filename = "sof-adl-max98360a-rt5682.tplg",
> + },
To repeat myself, there is no precedent for using a topology file name
that refers to a codec from a different vendor used on a different
platform.
It may work but it's confusing and not maintainable. I don't want to
start a trend where confusion becomes the norm.
In previous contributions, platforms with Cirrus Logic chips used a
non-ambiguous filename, please follow this example:
{
.id = "CSC3541",
.drv_name = "adl_cs35l41",
.sof_tplg_filename = "sof-adl-cs35l41.tplg",
},
and use
.sof_tplg_filename = "sof-adl-max98360a-cs42l42.tplg",
prev parent reply other threads:[~2022-05-18 14:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 3:32 Terry Chen
2022-05-18 13:32 ` Pierre-Louis Bossart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=728c697b-0df7-3d95-10cb-ce0111f0017b@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=brent.lu@intel.com \
--cc=broonie@kernel.org \
--cc=casey.g.bowman@intel.com \
--cc=cezary.rojewski@intel.com \
--cc=cujomalainey@chromium.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mac.chiang@intel.com \
--cc=mark_hsieh@wistron.corp-partner.google.com \
--cc=perex@perex.cz \
--cc=seanpaul@chromium.org \
--cc=terry_chen@wistron.corp-partner.google.com \
--cc=tiwai@suse.com \
--cc=vamshi.krishna.gopal@intel.com \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®