From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A51C1C41513 for ; Fri, 11 Aug 2023 09:09:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229677AbjHKJJs (ORCPT ); Fri, 11 Aug 2023 05:09:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229706AbjHKJJq (ORCPT ); Fri, 11 Aug 2023 05:09:46 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3A09F2D5B for ; Fri, 11 Aug 2023 02:09:46 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 60A3AD75; Fri, 11 Aug 2023 02:10:28 -0700 (PDT) Received: from [10.57.91.12] (unknown [10.57.91.12]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D3E0D3F59C; Fri, 11 Aug 2023 02:09:44 -0700 (PDT) Message-ID: <72960b11-9e35-a259-3ea6-bae91ff94838@arm.com> Date: Fri, 11 Aug 2023 10:09:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] coresight: etm4x: Ensure valid drvdata and clock before clk_put() To: James Clark , Anshuman Khandual , linux-arm-kernel@lists.infradead.org Cc: Mike Leach , coresight@lists.linaro.org, linux-kernel@vger.kernel.org, Dan Carpenter References: <20230811062738.1066787-1-anshuman.khandual@arm.com> <07b0dabb-5409-9ba8-543f-aeecafe083e9@arm.com> From: Suzuki K Poulose In-Reply-To: <07b0dabb-5409-9ba8-543f-aeecafe083e9@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/08/2023 09:39, James Clark wrote: > > > On 11/08/2023 07:27, Anshuman Khandual wrote: >> This validates 'drvdata' and 'drvdata->pclk' clock before calling clk_put() >> in etm4_remove_platform_dev(). The problem was detected using Smatch static >> checker as reported. >> >> Cc: Suzuki K Poulose >> Cc: Mike Leach >> Cc: James Clark >> Cc: coresight@lists.linaro.org >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-kernel@vger.kernel.org >> Reported-by: Dan Carpenter >> Closes: https://lists.linaro.org/archives/list/coresight@lists.linaro.org/thread/G4N6P4OXELPLLQSNU3GU2MR4LOLRXRMJ/ >> Signed-off-by: Anshuman Khandual >> --- >> This applies on coresight-next >> >> drivers/hwtracing/coresight/coresight-etm4x-core.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c >> index 703b6fcbb6a5..eb412ce302cc 100644 >> --- a/drivers/hwtracing/coresight/coresight-etm4x-core.c >> +++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c >> @@ -2269,7 +2269,7 @@ static int __exit etm4_remove_platform_dev(struct platform_device *pdev) >> etm4_remove_dev(drvdata); >> pm_runtime_disable(&pdev->dev); >> >> - if (drvdata->pclk) >> + if (drvdata && drvdata->pclk && !IS_ERR(drvdata->pclk)) >> clk_put(drvdata->pclk); >> >> return 0; > > It could be !IS_ERR_OR_NULL(drvdata->pclk), but I wouldn't bother > changing it at this point. +1, please could we have that. Someone else will run a code scanner and send a patch later. Given this is straight and easy change, lets do it in the first place. Cheers Suzuki > > Reviewed-by: James Clark