From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAB7CCD6E5A for ; Wed, 11 Oct 2023 11:35:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234813AbjJKLfN (ORCPT ); Wed, 11 Oct 2023 07:35:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234809AbjJKLfL (ORCPT ); Wed, 11 Oct 2023 07:35:11 -0400 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CB48A9 for ; Wed, 11 Oct 2023 04:35:07 -0700 (PDT) Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-2c186ea81c7so86999601fa.1 for ; Wed, 11 Oct 2023 04:35:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697024106; x=1697628906; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/Qapw6Vwkgw3j/x2kavvMeUiB4u4WXfkqK2WO2XBHoI=; b=JIVG3Drt2z4AnTJ3x0xy7WyfBYoiidfhfy2Y+m3CDu/qK4SJFhTiJLW7ibElrsF4Yk CVucgTkIS0LunzZZzb4kYO8KdcqcS4bfU9H3UkGa4N/BKepGUGPpbmsJKVg7TNr8+vB5 VmEos5nVcLmmjTb1uDm9XlfiQrzI8DB0eTb4qEtR9ytDIuBeCRsnDFao2AQ16TFH/mNT 15jRwCGmv6mYo8yUFcmr2Id/x9QNLPPRmiFbHHCMkJVkTqq//QJ5HTQf2wj24u3pnS2i VIUYyahktkcCg6N7YYRZcuEiWpQWtSkOWMgWzzVRgrlrRgW6elIfYpbcH2BEUzzaxgUB UtTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697024106; x=1697628906; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/Qapw6Vwkgw3j/x2kavvMeUiB4u4WXfkqK2WO2XBHoI=; b=auwhQkGWKh5ays4drs80rIyo0E+aOhQdk90yb3hd4CmqAn9r0LvAos5dFXNuuJkkz9 1mAV5yL5FRLMRcizXgkOXLqDXe+UkcF6kYd5TJc9gIKMwjDULZYJzphVJZVq2iI17FGw +aDO9On3UIqmlNzMq4wAe6NDJRHVzGqtfwNo1BFKF5wbmw3Py/bJjcyUdgj6cUf0qUp8 njsT9PKnFGAFR6Jyi+cpk4FKpzAv08Y0Sv1YjHIDSGJCjP/lo8CqwV3ncN+tllGSZoHa zht5CQSjeTlMqNP2E7TLnf7S/LvDKkPsb4u6Ya3UoLm9SVRdVohMyONaiYi5mtPgg8T6 pkYw== X-Gm-Message-State: AOJu0YwXHhKEYGMERyS4hryK64ggoA2LktsWS8ibiUd12+ykIU/D0OYu VQy0LrKIGuoRaMlq7GxO/2oI0g== X-Google-Smtp-Source: AGHT+IF5GLRI9qQunLWRzrMod3FWnDE+uoxeFzNq35YPTOaf98ygydLZmEYH1BWul8Cf/WIu46bWag== X-Received: by 2002:a2e:9e53:0:b0:2bf:fa62:5d0e with SMTP id g19-20020a2e9e53000000b002bffa625d0emr18110256ljk.2.1697024105878; Wed, 11 Oct 2023 04:35:05 -0700 (PDT) Received: from [172.30.204.240] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id c5-20020a2ea1c5000000b002bcbb464a28sm2882350ljm.59.2023.10.11.04.35.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Oct 2023 04:35:05 -0700 (PDT) Message-ID: <7297b408-06e8-41f3-a732-64c3cc3194e1@linaro.org> Date: Wed, 11 Oct 2023 13:35:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 5/5] arm64: dts: qcom: sa8775p: Add ep pcie0 controller node Content-Language: en-US To: Mrinmay Sarkar , Manivannan Sadhasivam Cc: agross@kernel.org, andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, quic_shazhuss@quicinc.com, quic_nitegupt@quicinc.com, quic_ramkri@quicinc.com, quic_nayiluri@quicinc.com, quic_krichai@quicinc.com, quic_vbadigan@quicinc.com, quic_parass@quicinc.com, Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Kishon Vijay Abraham I , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, mhi@lists.linux.dev, linux-phy@lists.infradead.org References: <1695218113-31198-1-git-send-email-quic_msarkar@quicinc.com> <1695218113-31198-6-git-send-email-quic_msarkar@quicinc.com> <20230921094823.GE2891@thinkpad> From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/11/23 12:44, Mrinmay Sarkar wrote: > > On 9/21/2023 3:18 PM, Manivannan Sadhasivam wrote: >> On Wed, Sep 20, 2023 at 07:25:12PM +0530, Mrinmay Sarkar wrote: >>> Add ep pcie dtsi node for pcie0 controller found on sa8775p platform. >>> >> It would be good to add more info in the commit message, like PCIe >> Gen, lane >> info, IP revision etc... >> >>> Signed-off-by: Mrinmay Sarkar >>> --- [...] >>> +        max-link-speed = <3>; >> Gen 3? > there is some stability issue with gen4 so going with gen3 as of now. > Will update once issue is resolved. That's something that should have definitely been mentioned in the commit message.. Please try resolving this first, if it ends up requiring bindings changes (missing clocks or whatever), it will be a pain. Konrad