From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0F54C83F2C for ; Mon, 4 Sep 2023 03:58:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351427AbjIDD62 (ORCPT ); Sun, 3 Sep 2023 23:58:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234314AbjIDD61 (ORCPT ); Sun, 3 Sep 2023 23:58:27 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23596F0; Sun, 3 Sep 2023 20:58:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=2KBGelxkdzNuQU0Ky+c2hpiqJmz+JVyJzOKJWp+DAoI=; b=JK7d7wURf+3CeXkX3TTYlcHQFw uidB737ooOB0sB5VTDtfjQbkKs+gtqertZBlwv7xdFewzztw273IBco86ao2Vbr5/bOFR9Z1In6jC l+fTeSitIXbk4AQeFK70VhA4cnX2Jss2Y0N6jmDY3iiE4VJ52nBXcH6JOH+i53elYotA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qd0iz-005iJX-Sr; Mon, 04 Sep 2023 05:58:05 +0200 Date: Mon, 4 Sep 2023 05:58:05 +0200 From: Andrew Lunn To: "Hawkins, Nick" Cc: "christophe.jaillet@wanadoo.fr" , "simon.horman@corigine.com" , "Verdun, Jean-Marie" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "conor+dt@kernel.org" , "netdev@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 4/5] net: hpe: Add GXP UMAC Driver Message-ID: <729dcda6-2d2c-4054-a570-17cdf6e4e57b@lunn.ch> References: <20230816215220.114118-1-nick.hawkins@hpe.com> <20230816215220.114118-5-nick.hawkins@hpe.com> <01e96219-4f0c-4259-9398-bc2e6bc1794f@lunn.ch> <88B3833C-19FB-4E4C-A398-E7EF3143ED02@hpe.com> <1b8058e1-6e7f-4a4a-a191-09a9b8010e0a@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > I have been trying to figure out how exactly I can translate the current code > over to using the page pool api over the past week. It seems like it is quiet > a complex change. As the driver seems to be keeping up with our > performance requirements would it be acceptable to mark this as a Its not just performance. Using well debugged and shared core code means less bugs in your driver. It makes maintenance simpler since there are more people who understand the page pool code than what you have in your driver and it makes your driver more like other drivers. So overall you will end up with a better quality driver by adapting the page pool code. Andrew