From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934880AbcJTLgN (ORCPT ); Thu, 20 Oct 2016 07:36:13 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:44330 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932582AbcJTLgM (ORCPT ); Thu, 20 Oct 2016 07:36:12 -0400 Subject: Re: [PATCH] pinctrl: st: don't specify default interrupt trigger To: , Linus Walleij , References: <1476774988-13484-1-git-send-email-patrice.chotard@st.com> CC: , , From: Patrice Chotard Message-ID: <729ebc94-5476-65a7-cc17-eabfba0d2404@st.com> Date: Thu, 20 Oct 2016 13:35:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1476774988-13484-1-git-send-email-patrice.chotard@st.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.48.1.66] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-10-20_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/18/2016 09:16 AM, patrice.chotard@st.com wrote: > From: Patrice Chotard > > Thanks to 332e99d5ae4 which now alerts of default > trigger usage when configuring interrupts. > > Signed-off-by: Patrice Chotard > --- > drivers/pinctrl/pinctrl-st.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c > index 99da4cf..b7bb371 100644 > --- a/drivers/pinctrl/pinctrl-st.c > +++ b/drivers/pinctrl/pinctrl-st.c > @@ -1512,7 +1512,7 @@ static int st_gpiolib_register_bank(struct st_pinctrl *info, > if (info->irqmux_base || gpio_irq > 0) { > err = gpiochip_irqchip_add(&bank->gpio_chip, &st_gpio_irqchip, > 0, handle_simple_irq, > - IRQ_TYPE_LEVEL_LOW); > + IRQ_TYPE_NONE); > if (err) { > gpiochip_remove(&bank->gpio_chip); > dev_info(dev, "could not add irqchip\n"); > Hi Linus I forgot to mention that this patch is dedicated for v4.9-rcs Thanks Patrice