mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ben Horgan <ben.horgan@arm.com>
To: Reinette Chatre <reinette.chatre@intel.com>,
	linux-kernel@vger.kernel.org
Cc: tony.luck@intel.com, Dave.Martin@arm.com, james.morse@arm.com,
	babu.moger@amd.com, tglx@kernel.org, mingo@redhat.com,
	bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
	hpa@zytor.com, fenghuay@nvidia.com, tan.shaopeng@fujitsu.com
Subject: Re: [PATCH v2 4/6] fs/resctrl: Disallow the software controller when mbm counters are assignable
Date: Wed, 18 Mar 2026 15:55:26 +0000	[thread overview]
Message-ID: <729fd48c-f25b-430a-95e1-49e6156364f8@arm.com> (raw)
In-Reply-To: <cac437e2-8139-4833-9cbd-55d626062730@arm.com>

Hi Reinette,

On 3/18/26 15:44, Ben Horgan wrote:

> 
> Apologies if the commit message aren't clear. I do see that I was confused in this one between
> counters being assignable, i.e. mbm_event mode possible, and the user being the being able to
> assign and unassign counters, i.e. mbm_event mode enabled. Do you prefer this as a commit message?
> 
> fs/resctrl: Disallow the software controller when using mbm_event mode
> 
> The software controller requires that there is one MBM counter, for each
> domain, per monitor group that is assigned to the event backing the
> software controller (the mba_MBps_event). When mbm_event mode is in use
> this event backing cannot be guaranteed as there may be insufficient
> counters, the user may unassign the counter or mbm_assign_on_mkdir may be
> set to 0.

Another case which could be mentioned here and  results in unassigned events
is when mbm_assign_on_mkdir is set to 1 but one of the domains was offline
when the monitor group was created.

> 
> Currently, only AMD systems support counter assignment but the MBA is non
> linear and so the software controller is never supported anyway. For MPAM
> systems the MBA is linear and it could support the software controller.
> Adding support would require guaranteeing that the events backing the
> software controller are always assigned. In order to support mbm_event mode
> for MPAM, which is needed to support memory bandwidth monitors, MBM, on
> platforms with fewer bandwidth counters (per domain) than monitor groups,
> take the pragmatic approach and fail the mount if the user requests the
> software controller, the mba_MBps option, when the mbm_event mode is
> enabled. Furthermore, disable switching to mbm_event mode when the software
> controller is enabled. If, in the future, a way for mbm_event mode and the
> software controller to function at the same time is introduced these
> restrictions can be adapted.
Thanks,

Ben


  reply	other threads:[~2026-03-18 15:55 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-13 17:45 [PATCH v2 0/6] x86,fs/resctrl: Pave the way for MPAM counter assignment Ben Horgan
2026-03-13 17:45 ` [PATCH v2 1/6] x86,fs/resctrl: Make resctrl_arch_is_evt_configurable() aware of mbm_assign_mode Ben Horgan
2026-03-13 17:45 ` [PATCH v2 2/6] fs/resctrl: Tidy up the error path in resctrl_mkdir_event_configs() Ben Horgan
2026-03-13 17:45 ` [PATCH v2 3/6] fs/resctrl: Make 'event_filter' files read only if they're not configurable Ben Horgan
2026-03-13 18:33   ` Luck, Tony
2026-03-16  9:51     ` Ben Horgan
2026-03-16 16:27       ` Luck, Tony
2026-03-16 17:02         ` Ben Horgan
2026-03-16 17:29           ` Reinette Chatre
2026-03-17 12:05             ` Ben Horgan
2026-03-13 17:45 ` [PATCH v2 4/6] fs/resctrl: Disallow the software controller when mbm counters are assignable Ben Horgan
2026-03-16 21:35   ` Reinette Chatre
2026-03-17 11:13     ` Ben Horgan
2026-03-17 17:17       ` Reinette Chatre
2026-03-18 15:44         ` Ben Horgan
2026-03-18 15:55           ` Ben Horgan [this message]
2026-03-18 22:17           ` Reinette Chatre
2026-03-13 17:45 ` [PATCH v2 5/6] x86,fs/resctrl: Add resctrl_arch_mbm_cntr_assign_fixed() Ben Horgan
2026-03-13 17:45 ` [PATCH v2 6/6] arm_mpam: resctrl: Adapt to new or changed resctrl arch functions Ben Horgan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=729fd48c-f25b-430a-95e1-49e6156364f8@arm.com \
    --to=ben.horgan@arm.com \
    --cc=Dave.Martin@arm.com \
    --cc=babu.moger@amd.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=fenghuay@nvidia.com \
    --cc=hpa@zytor.com \
    --cc=james.morse@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=reinette.chatre@intel.com \
    --cc=tan.shaopeng@fujitsu.com \
    --cc=tglx@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®