From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CH5PR02CU005.outbound.protection.outlook.com (mail-northcentralusazon11012011.outbound.protection.outlook.com [40.107.200.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A36C5258EFB for ; Thu, 27 Nov 2025 05:51:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.200.11 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764222690; cv=fail; b=WA1YvLiMi3an5WaMzfrWhk3GO5dQR/U3FaLmwuZP5nsGaDHDfzONmQIreQAV29HshQkg4jhLhXhDaDpiQHwfQZiy5GlVjxhFSn/e+YYdqeSuChfe+TjbGiKdjOT+NfJk+odZy+M2uP7xoAh+iSdvOxelkwvu3HDc6zyMwLhhUXM= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764222690; c=relaxed/simple; bh=sda/eL0PG3f+vcrG8jXQJZGK/xdSejpTnl2fkPBui4I=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=QU45dfRQ0bAzAnHdhA4XVSoxbmJKHwtkLCIJyNXRa+ylCOVqnnFviyNYesy+KalE3MBFS7UeUWevQ26GypgKwca/dyIi3ktExJqi62vXWqvh1/P3VDNB1qWidYtk6RYqpuCjzkB/nmk9bwkCGvxkODO6aLvc+J6102RYUEE5zN4= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=wuG8W8da; arc=fail smtp.client-ip=40.107.200.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="wuG8W8da" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=r/iFf4yeaVoEXjjEdh6kAPM4sMtRGEcTjHLrCqfCgLsAT0+Mnuzc3dI512RK9wpDLVyeoVpU9kOkqh2L9pamV/vv0DUrjmuHnRK2EAhPL/G9inJ43/Sbek8fh/KIoS/umsRX0/flBjw537M5sa19M4urL/B0TfrJlEWEL5VhfeNeWD1wFAzn34PxonstVXpaYO8PQOnt7BIUQlE1L419bcRE2SqNYZ5btw36mRpK25J+sS558UivRzKjB7cYFCR1O5zX1mxyLWIq6V1zv2ZpVW09bmNBiX3uEgaN/l/7yO40WJxx5vYXR9qlWSyiMoAOa4hjhlLm+yrCXPD2Ko/NLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/Ss7U5IwLHdxjBO7hawcJc3C/0XzXxq+dpBtQFr6NgM=; b=hWEN5yiB6bZLtfXPigE0n2KzhKDFDKTEJqHRa11osFFOnemtllWdBc2ZfUcEqvxMcHRwakP95CzO+zTvQtmiz+3jNBSXma5PP9VqooTxPUIvK1mpiUckh6rGLz6wNmXJD/E0Fy2Dq4I6durBo7s57AUGogmZXtyu0Fn18yvD516JVVlgTz2OOA3tmkLOME6tTAIQaC4pEhINBJzZ/nFiDFoB8KvyF+ZnRUJJysa6yhJ3MaTjw7Msr/1ObkofkqRth1mpLnL8BTUs3BrM+SCpsw0vcnL2ZeV2U2OIVO8DqEl6wOhvUZ1UpuNqro79zepcsAuSLyvG8gPC+XUYszvn3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=os.amperecomputing.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/Ss7U5IwLHdxjBO7hawcJc3C/0XzXxq+dpBtQFr6NgM=; b=wuG8W8daXyKy0UcPNirotimmprUrlL2pUz/8H4zXrVUWTokeHS6NPduftd6IbeqGhdZ+hQ7aAdQdsa7PJwyCBNbw3utdYX65VH2+1DlwXWa5QtDWjNPRGtT1uqpzRupZJCqJ5tYjyYzEUepyLgQkz3ANmGP3zvAmsDbsH7s1xbk= Received: from BL1PR13CA0309.namprd13.prod.outlook.com (2603:10b6:208:2c1::14) by DM4PR12MB6495.namprd12.prod.outlook.com (2603:10b6:8:bc::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.14; Thu, 27 Nov 2025 05:51:25 +0000 Received: from BL6PEPF00020E66.namprd04.prod.outlook.com (2603:10b6:208:2c1:cafe::47) by BL1PR13CA0309.outlook.office365.com (2603:10b6:208:2c1::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9388.3 via Frontend Transport; Thu, 27 Nov 2025 05:51:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by BL6PEPF00020E66.mail.protection.outlook.com (10.167.249.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.7 via Frontend Transport; Thu, 27 Nov 2025 05:51:25 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 26 Nov 2025 23:51:25 -0600 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 26 Nov 2025 21:51:24 -0800 Received: from [172.31.184.125] (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Wed, 26 Nov 2025 21:51:21 -0800 Message-ID: <72a32cac-29dc-41b7-a318-84345a55ed45@amd.com> Date: Thu, 27 Nov 2025 11:21:15 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] sched/fair: update rq->avg_idle for the delay-dequeue task To: Huang Shijie , , , , CC: , , , , , , , , , References: <20251127050353.1089724-1-shijie@os.amperecomputing.com> <20251127050353.1089724-4-shijie@os.amperecomputing.com> Content-Language: en-US From: K Prateek Nayak In-Reply-To: <20251127050353.1089724-4-shijie@os.amperecomputing.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF00020E66:EE_|DM4PR12MB6495:EE_ X-MS-Office365-Filtering-Correlation-Id: 5176ff21-b108-479e-0226-08de2d79005c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|7416014|376014|82310400026; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Y1JEWjUvQjBPVTNVSUVNRkx5S3pmUEpMS0Vsa3Nsbk5RMk9LdndSSEVKYVdt?= =?utf-8?B?TzZzMUc0eUdqeVdvRU5jR2ZSZnEzdjNXL2xSYlZ0NnZOQ2RiV1FINTlBUHNi?= =?utf-8?B?SnJRSHBEL1dOWDBrY3lKSllMZnIza0gyY05SN3prVHYrbmdsOVZmOWNKZ3Rk?= =?utf-8?B?MHRCVk9YM1RhTGRNL2htUThKV0ozL3ZsTHlLa2hYbDVaMXVxMU0vbmlXR1Ay?= =?utf-8?B?V2FVejlaVmZXbWQ4NWpTSlZWTFFFUGVJc2doOWU1bHFQbERtYWNQQzNNaURO?= =?utf-8?B?M0VuNW4xanNLYk5nelVnR1ZzUncvSjZNUldBd2hza3VTYUlIR05QOVpyeWFu?= =?utf-8?B?R2FTUnJmcTVmaDFnV3E2QnhNR1ZFWmVTcGp2M3BTcDJ2K1lPT3NGeFVxVUlD?= =?utf-8?B?bVFqRDZGN21sZFdSR2RidzA2TS9GRzJ4RnpGQkFISWtEMjJydUliZ2VERWZE?= =?utf-8?B?bG4ycmpGVVFSQTFIQitJdjdIRGVON2NXejJuUlBDV2YxVFR5QTcyMS9ncklI?= =?utf-8?B?dnYzbElRYnVueVJET1FDRVc1UE9uYXZmV0k0MC9qajl3WXVmb01LOW50TTBO?= =?utf-8?B?YzRiVGdxcGl5dEIwWmVDam9zZmp3Yzh1V1RoanAxMnVRSHExZWdnZWY4eXVy?= =?utf-8?B?MTJNV0krSWl2am0yb1dGdEc5THBqTW5xd1NvalkwZ1dkK2w2dnBvTDJlenpO?= =?utf-8?B?b25Talh4YlY3L2lpditPUUZ4Rk5acTNWZE1QVERkWU5CTW1xSi9MZUlaT0Iw?= =?utf-8?B?aVo3QTdOdUI3U3kzRVdXUldNcmJwZ1hSRDVkUzg0dnpMRExIVlZFZzRSMGxq?= =?utf-8?B?ZGhsc05tLzVoVFE0YW5mL0FNcVdjbStJVDVJcDJjdmxVNGxLZ0I3YUNNL0FE?= =?utf-8?B?bEZjQTd2VHcvZ3MySDVoTjhCdGw4d0xmaXlEWDdibkVidEJqcmRHdXBBd1h4?= =?utf-8?B?ODhKcHB0OXA2eVFlTHVHeGg1amxlU1B6NlVtNzlpZG1FY0I2ZjU4SnJpRytr?= =?utf-8?B?cmR0ZU9BQ01VZUVmWUFxR1k1amRsVkZRZjFnSC9BaStTRk1DcWhNaDE1R0N2?= =?utf-8?B?ajBEZkhJZUJhVHhiVUwyVnROalMvQklwcG9CVmlxY1N5SkZpQTZGanI5bkdK?= =?utf-8?B?TGY3aVpWR2YySW55V2JQcXQybHJGR1FkN2NqOUNJSEZCVW5UMU9CUVRJOTBK?= =?utf-8?B?R3VqMGF3eXM2T0FERDdRL1JqT2RUbDFPNkNwaVVhSVltUzlxandlYlFONE9E?= =?utf-8?B?dTZBRGt1eHkxVERwNC9YN1drY09RR2JNOFpYaFFVL3k3b2RZbmZwUzdlSVFr?= =?utf-8?B?TnFoZHJlMENwc3doMmNieCttWmtLMjV0SzZicHZMNVZyU0EzWk1rR01WY1o5?= =?utf-8?B?SzlPcjhYK08vTWtoK2xHK1pQTFlnTjdXSGVRVXJKbGpzeTI5SlhwcFo2MFUr?= =?utf-8?B?Uk9NQXhhUlRXQ2d0MnJ6WlFwWE1odmxpY2Q0VzUyT0d4VnhHbEVZeXZNWVl2?= =?utf-8?B?cDFPc3R0SFM3Ynliblk3WmhZM3gyM3dJVisxb28zdGdlWElyWTJNZlFCMUR4?= =?utf-8?B?Wml2dlZwM1Q2MFhuTVJPMHFRay9RVTJyZ0NTT1RFT0UyM3ZMSEhCNDlJMDdJ?= =?utf-8?B?M1l5cDliSmxOaXZCRzdRL0U4aEoxNU1mVTk4MGxONUlPd005bytnZ2xVa3BO?= =?utf-8?B?RmYxT3VjV3BSZ01CUkEwa2w3dW93RjZJRFZxZ1VUUWxhSlk5UEZyWnlZOUww?= =?utf-8?B?RDgxMjQ0bE03VXlFQUI5SWFYWlkyaVlvS3Z4NU1kRTlobW81UmlFMVJad1Ji?= =?utf-8?B?NS9xWWFSUTQ2ei9HUFhHUjFadUhoQ1hmOTI2R2p1c1Z2ajBTdnZjcWlrVjF4?= =?utf-8?B?djRtZ1FxNythK0VXRWlKM1hvbmx5OXpmNDNRQXdmak43WkM5RWRDdTZwS0dO?= =?utf-8?B?Tk9qeS8yWkdNNTlrU3dPanY2Y2VLVnEvODVtZlVndDR0TFJ4QjdOWXdROUg1?= =?utf-8?B?M25XN3VIK3pvQk1Ja0lSMUtKTi8ybVRqVHZERWdCT1RQbk94UHlKcW9hWmdR?= =?utf-8?B?UTYySkM2Q1o1d2IvSFpTK1lCa1lDb2ViSjBzSjMwYXZ4NVdZTW5TRHRTL3pR?= =?utf-8?Q?c8Xw=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(7416014)(376014)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2025 05:51:25.3071 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5176ff21-b108-479e-0226-08de2d79005c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF00020E66.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6495 On 11/27/2025 10:33 AM, Huang Shijie wrote: > When a delay-dequeue task is woken and requeued back, it may > becomes eligible, and changes the CPU idle status, > so we need to update the rq->avg_idle for it. > > This patch adds a new parameter for requeue_delayed_entity(), > and updates the rq->avg_idle as needed. Can't this be solved by moving update_rq_avg_idle() into enqueue_task() in the previous patch? The only path that can reenqueue a delayed task from ttwu_runnable() calls enqueue_task() with ENQUEUE_DELAYED. -- Thanks and Regards, Prateek