From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754103AbdIFMoF (ORCPT ); Wed, 6 Sep 2017 08:44:05 -0400 Received: from mail-sn1nam01on0085.outbound.protection.outlook.com ([104.47.32.85]:27808 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753839AbdIFMoA (ORCPT ); Wed, 6 Sep 2017 08:44:00 -0400 Subject: Re: [PATCH] tty: xilinx_uartps: move to arch_initcall for earlier console To: Linus Walleij , Michal Simek CC: Greg KH , Shubhrajyoti Datta , "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" , References: <1503487221-17950-1-git-send-email-shubhrajyoti.datta@xilinx.com> <20170823232424.GA9546@kroah.com> <62daa70c-0c6f-7628-efa4-308cfe93709c@xilinx.com> From: Michal Simek Message-ID: <72a8ba54-69fb-5a69-35b3-8c9e277621fb@xilinx.com> Date: Wed, 6 Sep 2017 14:43:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.1.0.1062-23306.006 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(39860400002)(2980300002)(438002)(377454003)(24454002)(199003)(189002)(54534003)(54356999)(8936002)(2906002)(36756003)(4326008)(39060400002)(6246003)(2950100002)(23676002)(76176999)(81156014)(9786002)(81166006)(33646002)(230700001)(50986999)(8676002)(31686004)(305945005)(356003)(106466001)(86362001)(63266004)(54906002)(189998001)(65956001)(64126003)(31696002)(478600001)(47776003)(5660300001)(966005)(6306002)(53546010)(65826007)(65806001)(83506001)(93886005)(50466002)(4001350100001)(36386004)(229853002)(626005)(77096006)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR0201MB1923;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;PTR:unknown-60-83.xilinx.com;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2NAM02FT047;1:CmO1GVdcZEFYJj1oyipK0HzcWDY68RUj57Md2xcXQsvoR/p4RZsEmPC5SBL95+UV1u934ICqI76ED5uO/CHcq8ALqF3Zc13okkCT3YIxCd1wqiiNXSo9igFHOhz349YE X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5cdc4066-8085-4438-5e83-08d4f524f03d X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(8251501002)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:BLUPR0201MB1923; X-Microsoft-Exchange-Diagnostics: 1;BLUPR0201MB1923;3:R6y+cE4qZr2BCSdL8HBu19CcspHVmYtee7ajr25TiwpCx62F4GmMj8zlFwb2rdQIMm7RxTrINgYPOIcA14oTTlTjl+WLynKyYxlC59u9Jhfr5/Fe97vVpwR2cC4YSFuaspava65yhfSAzUepLtERyFfbbBnPaD/SzcoRV8YMdiM5TNeWeR6Ik9fE9/6c1U02QW14mHkax1+mZCYD38r/2aHc6Z0DbtJPk4044nXVWRenELX70gR/H/H4KNgrfK8eCCCE4S0cmVke5S3tT43g+w4rIyqLuwyQ3ThwbPaIlH1z8Kxm75GtocD1aGP9XCK0+F5Dzo89GTjonrmYNj8OjsgdkUrmcaAFU4jGKEUFFU4=;25:vI1wtS0kanDrHej0Ya27I1UTE+s1V6wqZR3/p8s89qLSQ5TK2eZfv4eCAjFHbVGJJ0gP0jjGbH4cgPt0aQzB2bOBI/dQiot6Ha2OJfltpg01W4i0bzoAvuArCRQdpnX7U9j+M9wu+dA11V/QgkXH61D1VAzvsEaCTdipqmztq4vj1scwmvsVIBPMF5ejCZLqAlat7wiPTQ3mwTL6Fzgd6RnR7/65jcz44uPSFiwk4Pex/RxCte0Fkpzo2hyULKIJxhjxvdRCK+CUmTG7156atS56A20sfpMSeZUW5WJ4Wto0UWtludkHsrAbDGTST2pF3Uw9natuUASRX92AzgJI5Q== X-MS-TrafficTypeDiagnostic: BLUPR0201MB1923: X-Microsoft-Exchange-Diagnostics: 1;BLUPR0201MB1923;31:zL1RbLpOHZWVWjZLMZRU9fYxqNX40TnDqxCO9GlqbA+cu4pBjJhUjgCQFOdS7OQ+SgB+7i0gpyw5wiXrW9ToRRmVHaWAuYm0ZSmFmodqI4pncrFdLpgQSBhdM/LY4ZQ0e2L4BiIpNEA/8cg4/Ene8S2YAkEGLWrTsw2aQh/CqQmPQRm/oS+LSyxPcf+F/BExgLzvKBn37w7acyTLZCCMK09Q/lLtgcbREcsNT9rs+i8=;20:T9Eb7Fcz5vv5OJH75wpImvbw1oscrTi+zOr4p30aBueDiLhM38Sw+CZ8As6y8eyOdFDosl8jveSSOiae3x6ln7NWpfL1Z+j7EQcIqs4ux4UXLs0Wn9CzgGgM0SzKPPcz6yFVHltVYA3FLJPmQikt5Z+G4FAWz+HJIebEPM7BSrUCfUusa2/y16w/uGNuRz1hO45U2gMpME8n8z67PL7CsEySdQ0k8NlREKAFX7LXdQEG+t6uBX+fpjjewJ/pla1NCLYLKwtF9OWA1/1RAfpPfVLBzEiBq1mf+JTB8TiciEPri323dDAfDXhVjuciupaBkgyfXeD9y1PqCi9PkTe0ZQUh45wGqGNySTmvut4nWv+PnQOUXbkva55GYtTAwWYhcja+TbLcHpgo4cpBvhlLA7KqoIUed6xwtjptM2A//+875E33dTNc9w2mwzt6Ok7cFu6/WkZj5al7YfMTvfLsoD4r6z2QgtWnXI7I15eMi19jtyuB+DuVJO46AnCXP9yM X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(100000703101)(100105400095)(93006095)(93004095)(10201501046)(6055026)(6041248)(20161123562025)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BLUPR0201MB1923;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BLUPR0201MB1923; X-Microsoft-Exchange-Diagnostics: 1;BLUPR0201MB1923;4:oQXAeIzE69TuOo9LNs7UkqOZFEbgF3xUiPnv4HywMqLUkqxrgTG4To1wHwVgwp27uEfl+5rKUBLSRjfSVsjR9/mBoVgm9MJH1A8w9URcBgFuYUzEPmayzMBDhnk/JnYRKUK59VuiOrtzFUSMK/gHKXNJn1EeYRjvWabNWfcWW7zNKuGqOC+6KlVvLF1kq3Jch/DhsXevUJhvrrcgsAIF79BW/J7JZAKbAjbyPOZNA8X6Gg256rMZIgP7ahMqLvHhy6ZIRKjMd46DxvdevBHbc48SLTldDg+ogjcZRgXMMq8= X-Forefront-PRVS: 0422860ED4 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTFVQUjAyMDFNQjE5MjM7MjM6UVYzT0pkK09sLzhBOWJ2RUZ1MHNhWHNv?= =?utf-8?B?NDQ0bVpVZXBSeUpZQm9YZXEyNktkdHdFZzNlZnVVQldkSkZPdCtvM3R0L2ZG?= =?utf-8?B?UWNjc0RscFp4M1FCNnNMVm8xT0c1ZjZkV3cvNUFKQWdGdXlMZk50dEFQT1pj?= =?utf-8?B?ZWRQTGxWL1NneFlvdEoyVWdRdEkxS2RpZTBaZWhLMTlWdWh6UW1tVTJDa1hG?= =?utf-8?B?c09qM0ovVDFtdUFOOHpCOWxMVEF5ZDlWTjVhanRxVGcwdFBlYUJueWptdmJO?= =?utf-8?B?U3o1TUhheVl2NEVqR1RBU0I0emxoWklUQnVaa0psZFdncklvdVNGY0lwQUp4?= =?utf-8?B?SnFacVJjNFdDSmxsZi92UkdTQUNvU1VjaXlBUGxtZzgvYW9sTzZHZU9uUitw?= =?utf-8?B?OWRrcldxMGUxOVVPRjlaV1ZLcEFtV3crc2twTjlwdUF2VG5lNWZMWTRnQmtx?= =?utf-8?B?STd4enVVNXNBMHMyWjNydks1N3prZ1NiY0ZPK0pSNUpwbzhxd3dtR2VNb3M4?= =?utf-8?B?Q1VsNmJuUXNSMzQrVFk4Q0RRNVlEVjBmZUlYWFl6Vm8yb1VWU21DR29VRUpm?= =?utf-8?B?aVdLZzNEeEdTdVBUTEZVLzJqU3RIaXNEdnp4czlQbEtSZWNkV0hXNVZQYXMw?= =?utf-8?B?UFI4d1NhK29pWlN2UDVIRWFXaUpPNHMzWDVVbGM0TVZxSEo3cnU4M0VUaDNZ?= =?utf-8?B?YzJWaXpJMTdZUXJ3a2diRjZQMkEzM1JmY1pzZm9mQ2VTYmw5dVVib1AyaG9s?= =?utf-8?B?c2tBQ1FhQXdJRzN2Zk51SFJsZHRqcTFkVFVYWUhOUWVqWFk0ZHI2TXJUMGdx?= =?utf-8?B?WWtYT2JEcEhIYjlqRGNHRHlqbG9hOGxUMEQvNTNaTUxsM1gwMnNJU0YzNVU1?= =?utf-8?B?K3ZJeDhaMWtMc3BoV1RIN25GWU1nNlR4TjRobEZMVURoaVZYQkRaY2p0eUpW?= =?utf-8?B?UEhTWHJaQkY3UEFSOUFZNk5xWDdsWi85NUxpOVFzNm51OG40dmtnbzhpT2l1?= =?utf-8?B?aEpBZnZ3SmxicW5EZVJyMURESFV2NXhEZUZlWGRPRUp1aXdXRjdrbE8zZzAz?= =?utf-8?B?dFJxcTFMckpWeTRPbjZ0ZkphVmQvVjFrS0pjcDdEQmFSQWhoVHlDNGNIME4r?= =?utf-8?B?bzBFcUlXUHQzUGFwNlVqL3lmbUFZRnFXUEhwaGdENVE4VUY0bHhqbGtkdEh6?= =?utf-8?B?SWRNVHNQMnFUZlYxclZITlhzK1FFWXd1NmVXTnNibVVFUytJelEvWFBPaFdY?= =?utf-8?B?ZGtvNFNRN3BDbnNyQVM5SWVvVmR2MDJmSy9PYVBNWTNRVTBPUThqbEhXekk0?= =?utf-8?B?eTIySVhLQ2wzSC9adExLODJFUnV4M0IrNVdoNnBJb3lYWWNJL2NmUkxIOW5E?= =?utf-8?B?UFBuZFVPVDYrdWhadDdPY2ZFemRTdlVRR3AvdWp2WloreFBhTjJSNG5mcXZs?= =?utf-8?B?Y1lqZW80UGE0aGMvSkNzVFU3NFN0Z09XWEh5RC9kNjg4QTlhZHZBUVVCdTM3?= =?utf-8?B?SVlnWXdnZlpkclUvN3JJelV3b2UzZElFNUc3RXBjblpYZ3lSQ1pONy9uN25z?= =?utf-8?B?QXB0RXUvakZaL3FKNzJmTmFETS9mRmp6b3VmYTdycXJDbkV2TGEvV0I5d0Q3?= =?utf-8?B?Mit0aHN0dG41L3VEaEtDbjFGamY1YmwzYWw3blBSc0dvd1I5aThLUEE4djZL?= =?utf-8?B?R3NuVkt4N0NYZTU5ZHl1eXJMeEtTbmlPVzZ2WEtPakFwRzFCRHR3QklUbUVT?= =?utf-8?B?dWxrZnBRL0xrejdXbXp5MU9RPT0=?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR0201MB1923;6:DpsPUMpiZ2ZAV1T8ZH2FoFeFog9RYQV9DMVz4Vv3wptIWDkzRrVMYcDK6FSucwxBHTEV7Pa5pErB+dFoPTy7bLmDql+H215YIM/dXOFkC5y2RO1aeztC75v9TC+tuIjWxECJV0QSq1E7uHOE3SpQRUdNi+5XZ+N5uQEQwENa4EPOvI9GefldL64Fvr0nHHydhUVaFZewk9W10Cb1qXUedvnEIO+CMIopcq8Kd30MKQI3nuyfARIvQ6gNAo/1wDEnwJfZ/dscho1d5bIVBOWMrMiQ1eiAl41FGIDR0ufVLHc6kBmHIQM+l64rmHPNmHcg6bpn+nQES5B5i9iNCTM/0g==;5:qhsr57758T8dKjZjI68+vaECqSrxJDUXLgvFPsMdpB50RGoJR6CQER+IuorOK8IPzLLj7ar08jO7gz5MOpB7s0aSGAcQqRpkg88fsqgPAqr24TgNOwzSvZLtch4nyePNIYEO97pdY5thuc5XYKwEHA==;24:B4n0PFF6i6GGhDc6qc1K4oc6YNvqhVvI6rYDAtWY+nfweoKr0jnOCYLm9F3Tr/E4lLr0el9LPtis9CLS78Qz0MAWKVX5d/q1rDCvFPLmBTc=;7:k2bmNuYtXCKRHlFsjNH46RYuDD1kOennzYIosV3HZ5da2cETbv/VHicyMGEgCm7kHODMvg+L/SnYBdHSxcn7nRDzm5kqQLkTTWTNwUCELP1RHybgnnWt9nhZYbI0bU/P6/qtNSNBjlVkaZi22abcBclAgnt0yD9lIZlEaZJgFhSO3syBWcFQsSQUiphoL+Eq5fCyB8dSedmg6czhP2hi1IIhYv5zTN5wP3CXkWy36O8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2017 12:43:54.4887 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0201MB1923 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31.8.2017 14:59, Linus Walleij wrote: > On Thu, Aug 24, 2017 at 11:32 AM, Michal Simek wrote: >> On 24.8.2017 01:24, Greg KH wrote: >>> On Wed, Aug 23, 2017 at 04:50:21PM +0530, Shubhrajyoti Datta wrote: >>>> Signed-off-by: Shubhrajyoti Datta >>> >>> I can't take patches without any changelog text at all :( >> >> ok. I see you have also commented this. >> >> Anyway this is kind of old discussion about moving serial drivers to >> arch_initcall from module_init. >> >> There is one patch in the tree. >> >> commit 4dd9e742df98f8f600b4302d3adbb087a68237f7 >> Author: Alessandro Rubini >> AuthorDate: Tue May 5 05:54:13 2009 +0100 >> Commit: Russell King >> CommitDate: Sun May 31 14:58:11 2009 +0100 >> >> [ARM] 5505/1: serial amba-pl011: move to arch_initcall for earlier >> console >> >> Signed-off-by: Alessandro Rubini " >> Signed-off-by: Russell King >> >> >> and then there was one patch (also sent to linux-serial but don't have link) >> https://patches.linaro.org/patch/14633/ >> >> where that discussion wasn't finished. > > Yeah Alessandro never came back on that. > > I *guess* it is to get the console up really early, simply becaus it is > quite helpful for spotting early boot problems. ok. It means no concern about the move to arch_initcall. Shubhrajyoti: Please send v2 with changelog. Thanks, Michal