From: "Filipe Laíns" <lains@archlinux.org>
To: "Kamil Domański" <kamil@domanski.co>,
"Jiri Kosina" <jikos@kernel.org>,
"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
linux-kernel@vger.kernel.org
Cc: Nestor Lopez Casado <nlopezcasad@logitech.com>
Subject: Re: [PATCH v3] HID: logitech-hidpp: add support for Logitech G533 headset
Date: Sat, 04 Jul 2020 16:01:43 +0100 [thread overview]
Message-ID: <72aa9cf8c9bc46548c29742f55be7d3b0c002971.camel@archlinux.org> (raw)
In-Reply-To: <20200704004745.383271-1-kamil@domanski.co>
[-- Attachment #1: Type: text/plain, Size: 917 bytes --]
On Sat, 2020-07-04 at 02:47 +0200, Kamil Domański wrote:
> Changelog:
> v2:
> - changed charging status parsing to account for invalid states
> v3:
> - rebased against Linux v5.7
> - changed variable naming in hidpp20_adc_map_status_voltage
> to camel case
> - corrected comment styling in hidpp_battery_get_property
> - dropped usage of test_bit macro in hidpp20_adc_map_status_voltage
> to avoid using `long` type
> - added bit flag definitions in hidpp20_adc_map_status_voltage
>
> Signed-off-by: Kamil Domański <kamil@domanski.co>
Seems like my concerns were address and the patch looks correct.
Benjamin, Jiri, are there any implications to keep in mind of always
polling the device every time we need to read the voltage? I don't
expect anything major, I just thought there might something there I
should keep in the back of my mind.
Cheers,
Filipe Laíns
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-07-04 14:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-04 0:47 Kamil Domański
2020-07-04 15:01 ` Filipe Laíns [this message]
2020-08-31 7:00 ` Jiri Kosina
[not found] ` <CA+oAjKzdmzg2KFuuSOJL35ifHRSCosHW+y4Cm4bmQQQc49GjAA@mail.gmail.com>
2020-09-25 11:48 ` Jiri Kosina
-- strict thread matches above, loose matches on Subject: below --
2020-07-04 0:43 Kamil Domański
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72aa9cf8c9bc46548c29742f55be7d3b0c002971.camel@archlinux.org \
--to=lains@archlinux.org \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=kamil@domanski.co \
--cc=linux-kernel@vger.kernel.org \
--cc=nlopezcasad@logitech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®