From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966480AbdEOTWJ (ORCPT ); Mon, 15 May 2017 15:22:09 -0400 Received: from mout.web.de ([212.227.15.14]:50327 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934329AbdEOTWI (ORCPT ); Mon, 15 May 2017 15:22:08 -0400 Subject: [PATCH 6/6] PNP: Delete an error message for a failed memory allocation in quirk_awe32_add_ports() From: SF Markus Elfring To: "Rafael J. Wysocki" , kernel-janitors@vger.kernel.org Cc: LKML , Wolfram Sang References: <94f6ec12-0092-e1e6-3fb1-81f9630eae1f@users.sourceforge.net> Message-ID: <72ac25c7-93b8-49ad-bdb2-173aa2863aba@users.sourceforge.net> Date: Mon, 15 May 2017 21:22:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <94f6ec12-0092-e1e6-3fb1-81f9630eae1f@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:YFF1l5ZZnnv068pdX4RCR3mDxtkJNVTvkzziIouF8nZ5AqWJedJ hp+8MrjqRIBlfmPIglJvmN3Q5H0IzHuBw6nhtg8QaYzGgrMB6W0gSKdJkpls0YA9rgwnsKQ gQvSdlDNjP8PgxvLoGswmh7UJNxkb9kfa04tOn2GBdqSXxYaeoF/Jm0FhcFiV9zbxdQIM/G OXs90f1C2jpG2TNCRNrzw== X-UI-Out-Filterresults: notjunk:1;V01:K0:GbGuvqLpwdY=:l0TZP8xQssFA1e6s13TJlm VYEUXGVkCZBgiTR19VXBPk01EXgL0/Tz1EUqweF8qFmKPd+QAbOqOyCXePd96S6/O+WSTAI3i hiLinlS7Wohgbsf+vLuidVJ+NEd+Gy5+c0Yd6P/my70EH1o1Vd4RNh59gugLNg/+AymBmkFHP WcjnYfihSoQDeyOW1ZOVqTjl3tXA6c8v5kguJKgCzTgrlvNfFmZzRQWKOYVNoGjc30Ult2Imz AQJvkDF0dKP9kVOu3vkkmmxstQ5NGEApBatHjh4VjmqSB3RwkqN8zFy3V+txEcYS+GdHHMHUw XQ8uRCOC6jzZTNC3zmhLBwzwfmTQoWphTYdPFHOcL+wNtxlU0Z3GKk0tAPsUAJq+KKcXdEYGY munCTGVo/KEuFyHJpL9hBIGz4Jmm1axvUSdLSqqNV+tQFCJNezLTi/NwO5lIa8miKmUsxk8/a 0kSIBAFNc49TVH8QVAuKKx20IVOhvZ/fvgK8r5hGw3rj/SYXh1OXqCjovzoP+9pI8pDk6glMc C9LAUoo9/65xQLoF6ZWm6Ni+WQP+BQ9j8twcEWty/94UCmkCWaugGzxq0/R3RUKFxtcsJXD5V rHuSJmp63w9e104aGRzpA5DPOMODEnnL4BArmylTALSeyUsq7K5vyY70pdRUrfq/tPodGeVQ0 XTW5xO4V0WtQhoSTjt11Fzvepi2yWMp/XuVoR3BOwx2hYgSqtHe8QlFTeHWbpeCZ9HAfQMrnK 8Edb+m5lrCrFOvxQXu32/1gCHXToEB51kUCI0Twf6sqhs+c9XyZqEWM3aNaObt46V13tgXWmv A5zFEM0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 15 May 2017 20:36:35 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/pnp/quirks.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/pnp/quirks.c b/drivers/pnp/quirks.c index f9be5f3fb7ea..ae7fbf105e0a 100644 --- a/drivers/pnp/quirks.c +++ b/drivers/pnp/quirks.c @@ -33,8 +33,5 @@ static void quirk_awe32_add_ports(struct pnp_dev *dev, - if (!new_option) { - dev_err(&dev->dev, "couldn't add ioport region to option set " - "%d\n", pnp_option_set(option)); + if (!new_option) return; - } *new_option = *option; new_option->u.port.min += offset; -- 2.13.0