From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FCA4C38145 for ; Thu, 8 Sep 2022 09:29:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230053AbiIHJ3e (ORCPT ); Thu, 8 Sep 2022 05:29:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230350AbiIHJ3a (ORCPT ); Thu, 8 Sep 2022 05:29:30 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C7BF2BCA for ; Thu, 8 Sep 2022 02:29:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662629367; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=casXnlyfem/cMcq/zKr8AiPcnoA42iZlvAPreQZv3fs=; b=bpdFaZ8S4+uUF7ycFdr5UgGj967cK9Kk2C4ITqGcMRP7OdsT6iNHa6fn4XbIK7fmV7E7Bh sQ/UkWo/tZ1yt1un+fO39QOJtfC+0xWUfzoIM+XzCGN9A9lWAHSSk8Av72JgyyrWDjxL58 X9w/WBtdKc3MpLwdRj+zzMRW8lHdNfs= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-561-pxDbEA7TNoyNu6U23WkJTA-1; Thu, 08 Sep 2022 05:29:25 -0400 X-MC-Unique: pxDbEA7TNoyNu6U23WkJTA-1 Received: by mail-ed1-f71.google.com with SMTP id m18-20020a056402511200b0044862412596so11002525edd.3 for ; Thu, 08 Sep 2022 02:29:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=casXnlyfem/cMcq/zKr8AiPcnoA42iZlvAPreQZv3fs=; b=cObIkDmf74ThXSW22gdxf6hNmLPE8N6P/r9VC+UExjmvbyhzJlZbg02Dazx5bVVmNe OcU3Upkrh9g1yBPE+5padPsaD3ks+RG4SFy6bH8Y4+srvb2c6IC23KjimU+M8gZGraKS 4NGl4PMQDVShsRQSFmhwup4PKAv0+FRDmg3AGQq8HBedpr5sLK+BpBj2qDwkUnGZ5Q3B E2qF54QXNSe62dIxEH3C0ashuhDUb6lLcFxiuYQBYzVac8yxeXHX1fDySygJRf9B/IbQ twoeJe7sXQOMC4P5D7/TRjkdujVshIonyxRBIdkzPR9l5a8kwIyyX1ms7pjjFaqiRjP3 vf3A== X-Gm-Message-State: ACgBeo2kDTV9XyLT1JJuZU/BVniGjCS0YQcLSS5xGwyE/27MfKCBwfa2 MLl5XIOM3xzdD3wU+QxGQcRkQ9KwLsQTX5G0WYBW8gON6Eaw24UhPHNAKmPWo+osbFam3p6toRN hMWHk6ssSYwnP2Tv+2uKmaYZw X-Received: by 2002:a05:6402:e96:b0:443:a086:e3e8 with SMTP id h22-20020a0564020e9600b00443a086e3e8mr6634983eda.330.1662629364653; Thu, 08 Sep 2022 02:29:24 -0700 (PDT) X-Google-Smtp-Source: AA6agR7dC5R82XPS91l4CxPlXPGCcS/hi02/tOGJdVWXrPtNkFqqjr46QX0/6Sg6lODyX2MG2aj1BQ== X-Received: by 2002:a05:6402:e96:b0:443:a086:e3e8 with SMTP id h22-20020a0564020e9600b00443a086e3e8mr6634970eda.330.1662629364485; Thu, 08 Sep 2022 02:29:24 -0700 (PDT) Received: from ?IPV6:2001:1c00:c1e:bf00:d69d:5353:dba5:ee81? (2001-1c00-0c1e-bf00-d69d-5353-dba5-ee81.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:d69d:5353:dba5:ee81]) by smtp.gmail.com with ESMTPSA id w6-20020a50c446000000b004476c19d126sm12139269edf.38.2022.09.08.02.29.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Sep 2022 02:29:23 -0700 (PDT) Message-ID: <72acff59-81f0-f466-6197-d3e993f051ac@redhat.com> Date: Thu, 8 Sep 2022 11:29:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v1 8/8] efi/dev-path-parser: Refactor _UID handling to use acpi_dev_uid_to_integer() Content-Language: en-US To: Andy Shevchenko , "Rafael J. Wysocki" , Wolfram Sang , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, devel@acpica.org Cc: "Rafael J. Wysocki" , Len Brown , Ard Biesheuvel , Elie Morisse , Nehal Shah , Shyam Sundar S K , Khalil Blaiech , Andy Gross , Bjorn Andersson , Konrad Dybcio , Will Deacon , Mark Rutland , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Mark Brown , Robert Moore , Wolfram Sang References: <20220907164606.65742-1-andriy.shevchenko@linux.intel.com> <20220907164606.65742-9-andriy.shevchenko@linux.intel.com> From: Hans de Goede In-Reply-To: <20220907164606.65742-9-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 9/7/22 18:46, Andy Shevchenko wrote: > ACPI utils provide acpi_dev_uid_to_integer() helper to extract _UID as > an integer. Use it instead of custom approach. > > Signed-off-by: Andy Shevchenko > --- > drivers/firmware/efi/dev-path-parser.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/firmware/efi/dev-path-parser.c b/drivers/firmware/efi/dev-path-parser.c > index eb9c65f97841..113b3ca1bd76 100644 > --- a/drivers/firmware/efi/dev-path-parser.c > +++ b/drivers/firmware/efi/dev-path-parser.c > @@ -15,9 +15,11 @@ > static long __init parse_acpi_path(const struct efi_dev_path *node, > struct device *parent, struct device **child) > { > - char hid[ACPI_ID_LEN], uid[11]; /* UINT_MAX + null byte */ > struct acpi_device *adev; > struct device *phys_dev; > + char hid[ACPI_ID_LEN]; > + long ret; "long ret" should be "int ret" here since that is what acpi_dev_uid_to_integer() returns. Regards, Hans > + u64 uid; > > if (node->header.length != 12) > return -EINVAL; > @@ -27,12 +29,12 @@ static long __init parse_acpi_path(const struct efi_dev_path *node, > 'A' + ((node->acpi.hid >> 5) & 0x1f) - 1, > 'A' + ((node->acpi.hid >> 0) & 0x1f) - 1, > node->acpi.hid >> 16); > - sprintf(uid, "%u", node->acpi.uid); > > for_each_acpi_dev_match(adev, hid, NULL, -1) { > - if (adev->pnp.unique_id && !strcmp(adev->pnp.unique_id, uid)) > + ret = acpi_dev_uid_to_integer(adev, &uid); > + if (ret == -ENODATA && node->acpi.uid == 0) > break; > - if (!adev->pnp.unique_id && node->acpi.uid == 0) > + if (ret == 0 && node->acpi.uid == uid) > break; > } > if (!adev)