From: Andrew Lunn <andrew@lunn.ch>
To: Luke Howard <lukeh@padl.com>
Cc: Cedric Jehasse <cedric.jehasse@gmail.com>,
Jiri Pirko <jiri@resnulli.us>, Ivan Vecera <ivecera@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Nikolay Aleksandrov <razor@blackwall.org>,
Ido Schimmel <idosch@nvidia.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
David Ahern <dsahern@kernel.org>, Shuah Khan <shuah@kernel.org>,
Vladimir Oltean <olteanv@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
bridge@lists.linux.dev, linux-kselftest@vger.kernel.org,
Max Hunter <max@huntershome.org>,
Kieran Tyrrell <kieran@sienda.com>
Subject: Re: [PATCH net-next v2 5/6] net: dsa: mv88e6xxx: MQPRIO support
Date: Wed, 3 Jun 2026 04:41:13 +0200 [thread overview]
Message-ID: <72af0cfc-9011-4713-9862-710eea5f1cb0@lunn.ch> (raw)
In-Reply-To: <89BA4203-110E-4767-895C-A2808602FAF8@padl.com>
> We could add (e.g.) bridge_setup_tc to dsa_switch_ops, which (in the
> mv88e6xxx implementation) could validate the bridge contained all
> user ports. But it would not be possible to block a port from
> leaving as port_bridge_leave cannot return an error, and tearing
> MQPRIO config down silently would be a different sort of bad.
There can be multiple bridges, even as far as one bridge per port.
For switch wide properties, you basically have to allow the first user
to configure it, refcount additional users get added and removed, and
only allow the last user to change it.
The alternative is return -EOPNOTSUPP, and let the kernel do it in
software, if a user wants something different to the global
setting. The hardware is only there to accelerate what Linux can
already do in software. That is the model we use.
Andrew
next prev parent reply other threads:[~2026-06-03 2:41 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 0:43 [PATCH net-next v2 0/6] net: dsa: mv8ee6xxx: MQPRIO and 802.1Qat support Luke Howard
2026-06-02 0:43 ` [PATCH net-next v2 1/6] net: bridge: mdb: add MDB_FLAGS_STREAM_RESERVED flag Luke Howard
2026-06-02 0:43 ` [PATCH net-next v2 2/6] net: bridge: convert mdb_entry host_joined to a flags field Luke Howard
2026-06-03 7:38 ` Nikolay Aleksandrov
2026-06-02 0:43 ` [PATCH net-next v2 3/6] net: bridge: add 802.1Qat stream reservation admission control Luke Howard
2026-06-02 1:28 ` Luke Howard
2026-06-03 7:35 ` Nikolay Aleksandrov
2026-06-04 5:39 ` Luke Howard
2026-06-05 12:53 ` Cedric Jehasse
2026-06-05 14:44 ` Andrew Lunn
2026-06-06 8:02 ` Luke Howard
2026-06-06 8:21 ` Nikolay Aleksandrov
2026-06-06 21:49 ` Luke Howard
2026-06-06 22:14 ` Nikolay Aleksandrov
2026-06-07 0:02 ` Luke Howard
2026-06-05 22:36 ` Luke Howard
2026-06-02 0:43 ` [PATCH net-next v2 4/6] net: bridge: allow MDB_FLAGS_STREAM_RESERVED on host groups Luke Howard
2026-06-02 0:43 ` [PATCH net-next v2 5/6] net: dsa: mv88e6xxx: MQPRIO support Luke Howard
2026-06-02 12:00 ` Cedric Jehasse
2026-06-02 21:12 ` Luke Howard
2026-06-02 23:48 ` Luke Howard
2026-06-02 23:55 ` Andrew Lunn
2026-06-03 0:15 ` Luke Howard
2026-06-03 1:40 ` Luke Howard
2026-06-03 2:41 ` Andrew Lunn [this message]
2026-06-03 3:29 ` Luke Howard
2026-06-04 6:26 ` Luke Howard
2026-06-03 2:09 ` Luke Howard
2026-06-03 3:30 ` Luke Howard
[not found] ` <808529B1-E40A-4E54-A654-86F1B6D1FA66@padl.com>
2026-06-04 8:36 ` Cedric Jehasse
2026-06-02 0:43 ` [PATCH net-next v2 6/6] net: dsa: mv88e6xxx: honour MDB_FLAGS_STREAM_RESERVED for AVB streams Luke Howard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72af0cfc-9011-4713-9862-710eea5f1cb0@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=bridge@lists.linux.dev \
--cc=cedric.jehasse@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=kieran@sienda.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lukeh@padl.com \
--cc=max@huntershome.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®