From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 898A7EB64D8 for ; Tue, 20 Jun 2023 19:03:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230337AbjFTTDr (ORCPT ); Tue, 20 Jun 2023 15:03:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230287AbjFTTDo (ORCPT ); Tue, 20 Jun 2023 15:03:44 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B43059B for ; Tue, 20 Jun 2023 12:03:43 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-4f957a45b10so51264e87.0 for ; Tue, 20 Jun 2023 12:03:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687287822; x=1689879822; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yhFl7csls6VbQpRJBHh5j2tQyC8b07HNJS4qfJGgohA=; b=iF4yTNc77O+N4+MMq+HnSFJ+btZOf3ve7xLf2SUYea8xR10c1zDtlhYSHqueI7hvRe ATX2a9A2xzy0AaWGiazqKlKzk2lstSUC7Miro+Le0oTgy/ZEGjdkfGRsU99ETnTrwVG9 1nk5dAuyF3kh+Z6IcE3s5oIet1a8YlhiD32E3GdkaIAMjerBZJqa6U+XYws06GNsUvIX Iaqu/oyGpeN7NpBSF8rASuSaJ7saJgTwzH9JXgw2kDJpI49ILh3Ife+w8L4cn45MFqjd CyCkO+hiYI9KJlLpdih0eWnRpT22+dREjZo9upVBMeAxqrdI+2Q172HRBGyn/kgKBA9i bVjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687287822; x=1689879822; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yhFl7csls6VbQpRJBHh5j2tQyC8b07HNJS4qfJGgohA=; b=h7LScQlp/8X9zAKmlDn+sz3VrMO3cwM3uc5ulMQafVe0qSYQWxNHDzb5eIjnUWt1IB GFfZEJsrywPzVY8jbtDh+qXHyZBD7tlqAfBoAypGRUt3nPp0qh1yPokMuw+Or8WsIiHi LSMDGbhT1IdO5JQZgqEeQqdQ3yh8C+FXR74x8+Un/Iq6jHym+o3O3eEYVyC9KLyMZ3+k AoL1mR2ajrhs4la0j+md0pSKs+FrBJNSQmvQA3DqwxHdBCxeV3VDV5TsTADKIdt35UGz hvRD5O/+7IYGdYB45ng8M2hUH1rrBmTkyhFdHVOCmkWPd4FeBdfC8rws9E8HHIXHHPJI DbSQ== X-Gm-Message-State: AC+VfDyEvVLmUsw9VJz/jva/e9Z/345d2iBErRQI+kftyjIE80AuJbpm ca5lCCaDEWMyuVadI/XTfVbmGA== X-Google-Smtp-Source: ACHHUZ5JeTANAG/P0Z/5Ude0RuprBA3s6XiRGOPpGOLVemNka9J+vhmKajP+GrfY3D4g3b74f8GDww== X-Received: by 2002:a05:6512:3288:b0:4f6:29b2:f92a with SMTP id p8-20020a056512328800b004f629b2f92amr7475693lfe.21.1687287822003; Tue, 20 Jun 2023 12:03:42 -0700 (PDT) Received: from [192.168.1.101] (abxj193.neoplus.adsl.tpnet.pl. [83.9.3.193]) by smtp.gmail.com with ESMTPSA id p2-20020a19f002000000b004f85885cff1sm456176lfc.134.2023.06.20.12.03.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Jun 2023 12:03:41 -0700 (PDT) Message-ID: <72b34fea-70c1-8d80-ef3a-15e82678c757@linaro.org> Date: Tue, 20 Jun 2023 21:03:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 4/4] arm64: dts: qcom: qrb4210-rb2: Enable GPU Content-Language: en-US To: Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230620-topic-gpu_tablet_disp-v1-0-7bb02bec8dc0@linaro.org> <20230620-topic-gpu_tablet_disp-v1-4-7bb02bec8dc0@linaro.org> <30cfddfb-fabb-a65e-6bb6-c0efdbd92fd7@linaro.org> From: Konrad Dybcio In-Reply-To: <30cfddfb-fabb-a65e-6bb6-c0efdbd92fd7@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20.06.2023 17:47, Dmitry Baryshkov wrote: > On 20/06/2023 16:17, Konrad Dybcio wrote: >> Enable the A610 GPU and provide a firmware path to the ZAP blob. >> >> Signed-off-by: Konrad Dybcio >> --- >>   arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 8 ++++++++ >>   1 file changed, 8 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts >> index e23a0406eacc..a7278a9472ed 100644 >> --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts >> +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts >> @@ -179,6 +179,14 @@ &gpi_dma0 { >>       status = "okay"; >>   }; >>   +&gpu { >> +    status = "okay"; >> + >> +    zap-shader { >> +        firmware-name = "qcom/qrb4210/a610_zap.mbn"; > > Should this be qrb4210 or sm4250? Previously we did not use special subdirs for IOT versions. See qrb5165-rb5.dts. https://lore.kernel.org/linux-arm-msm/CAH=2NtwVtLdE5hg8Qhd_MLCPJTqXvus8+qW_uj4O7hnOy7PVUA@mail.gmail.com/ Konrad > >> +    }; >> +}; >> + >>   &i2c2 { >>       clock-frequency = <400000>; >>       status = "okay"; >> >