Re: [PATCH next 2/3] ASoC: tas2781: fix reset-gpio polarity

[POPESCU Catalin <catalin.popescu@leica-geosystems.com>]

On 03/07/2025 10:03, Krzysztof Kozlowski wrote:
> This email is not from Hexagon’s Office 365 instance. Please be careful while clicking links, opening attachments, or replying to this email.
>
>
> On 03/07/2025 09:50, Catalin Popescu wrote:
>> Both TAS2563 & TAS2781 have an active low reset, yet the driver assumes
>> an active high reset. Hence, in order to get the chip out of reset we
>> need to lie to the devicetree about the reset polarity. The patch fixes
>> the driver so it could work no matter the polarity and leaves it to the
>> devicetree to define the correct polarity.
>>
>> Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com>
>
> This breaks all existing in-tree and out-tree users.
>
> DTS patches are independent, so you cannot fix in-tree that way. Anyway,
> you cannot fix other users, so sorry, you are stuck with this or you
> need some tricks (I once did for a qcom codec, but I don't know if this
> is really the solution and my case was easier about the users).
>
> Best regards,
> Krzysztof

Then, I'll keep lying to my devicetree and stick with the current driver.
Thx for the review!

BR,
Catalin