From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751125AbdILTME (ORCPT ); Tue, 12 Sep 2017 15:12:04 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:46585 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750869AbdILTMB (ORCPT ); Tue, 12 Sep 2017 15:12:01 -0400 X-Google-Smtp-Source: ADKCNb6uYuHNWOMAMd2UOmq9qepS/8KL7nuIzq7e+nlrAXKgVJLkMDA/eh78fQT2czs4DXo5OJBmLQ== Subject: Re: Splitting led drivers to subdirectories? To: Pavel Machek , linux-leds@vger.kernel.org, kernel list References: <20170912125408.GA4074@amd> From: Jacek Anaszewski X-Enigmail-Draft-Status: N1010 Message-ID: <72bc03c4-90d8-0f82-42b5-172022fb6a8b@gmail.com> Date: Tue, 12 Sep 2017 21:11:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170912125408.GA4074@amd> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 09/12/2017 02:54 PM, Pavel Machek wrote: > Hi! > > Is it time to start splitting drivers into subdirectories? > > I'd quite like to see drivers/leds/i2c/ and drivers/leds/flash/ . That > way it is easier to look at related drivers for inspiration... These categorization would be inconsistent - i2c is a bus, and flash is a LED function. Moreover, not all devices are driven through buses, some of them via gpio, MMIO or even as2cwire like in case of leds-aat1290. Do we want to split the drivers like that? It would generate only unnecessary noise IMHO. We could go for splitting drivers to LED and LED flash class, but the former is just a subset of the latter, so it would be also not accurate. Effectively I propose to apply the "leave well alone" rule here :-) -- Best regards, Jacek Anaszewski