From: Bart Van Assche <bvanassche@acm.org>
To: "Bao D. Nguyen" <quic_nguyenb@quicinc.com>,
quic_asutoshd@quicinc.com, quic_cang@quicinc.com,
mani@kernel.org, stanley.chu@mediatek.com,
adrian.hunter@intel.com, beanhuo@micron.com, avri.altman@wdc.com,
martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, Alim Akhtar <alim.akhtar@samsung.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 2/7] ufs: core: Update the ufshcd_clear_cmds() functionality
Date: Fri, 19 May 2023 15:53:06 -0700 [thread overview]
Message-ID: <72c3d1b1-69de-b91b-09e4-08875a3602d9@acm.org> (raw)
In-Reply-To: <91bddbc5945a7a651bb1edc35ac5ff54a20bf6c1.1683872601.git.quic_nguyenb@quicinc.com>
On 5/11/23 23:28, Bao D. Nguyen wrote:
> In the ufshcd_clear_cmds(), the 2nd pamameter would be the
> bit mask of the command to be cleared in the transfer request
> door bell register. This bit mask mechanism does not scale well in
> mcq mode when the queue depth becomes much greater than 64. Change the
> 2nd parameter to the function to be the task_tag number of the
> corresponding bit to be cleared in the door bell register.
> By doing so, mcq mode with a large queue depth can reuse this function.
>
> Since the behavior of this function is changed from handling
> multiple commands into a single command, rename ufshcd_clear_cmds()
> into ufshcd_clear_cmd().
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2023-05-19 22:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1683872601.git.quic_nguyenb@quicinc.com>
2023-05-12 6:28 ` [PATCH v5 1/7] ufs: core: Combine 32-bit command_desc_base_addr_lo/hi Bao D. Nguyen
2023-05-19 22:46 ` Bart Van Assche
2023-05-12 6:28 ` [PATCH v5 2/7] ufs: core: Update the ufshcd_clear_cmds() functionality Bao D. Nguyen
2023-05-19 22:53 ` Bart Van Assche [this message]
2023-05-12 6:28 ` [PATCH v5 3/7] ufs: mcq: Add supporting functions for mcq abort Bao D. Nguyen
2023-05-19 22:56 ` Bart Van Assche
2023-05-12 6:28 ` [PATCH v5 4/7] ufs: mcq: Add support for clean up mcq resources Bao D. Nguyen
2023-05-19 22:58 ` Bart Van Assche
2023-05-12 6:28 ` [PATCH v5 5/7] ufs: mcq: Added ufshcd_mcq_abort() Bao D. Nguyen
2023-05-17 3:15 ` Stanley Chu
2023-05-17 3:25 ` Bao D. Nguyen
2023-05-12 6:28 ` [PATCH v5 6/7] ufs: mcq: Use ufshcd_mcq_poll_cqe_lock() in mcq mode Bao D. Nguyen
2023-05-19 22:59 ` Bart Van Assche
2023-05-12 6:28 ` [PATCH v5 7/7] ufs: core: Add error handling for MCQ mode Bao D. Nguyen
2023-05-19 23:03 ` Bart Van Assche
2023-05-20 0:11 ` Bao D. Nguyen
2023-05-23 6:58 ` Bao D. Nguyen
2023-05-22 6:48 ` Stanley Chu
2023-05-22 6:56 ` Stanley Chu
2023-05-23 7:01 ` Bao D. Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72c3d1b1-69de-b91b-09e4-08875a3602d9@acm.org \
--to=bvanassche@acm.org \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=quic_asutoshd@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®