From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755951AbcK2UR6 (ORCPT ); Tue, 29 Nov 2016 15:17:58 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:34841 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753019AbcK2URr (ORCPT ); Tue, 29 Nov 2016 15:17:47 -0500 Subject: Re: [PATCH] perf sched timehist: Improve error message when analyzing wrong file To: Arnaldo Carvalho de Melo References: <1480449528-43394-1-git-send-email-dsahern@gmail.com> <20161129201404.GF23423@kernel.org> Cc: mingo@kernel.org, peterz@infradead.org, namhyung@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org From: David Ahern Message-ID: <72c47909-8e9c-616c-1afe-5daa12f44473@gmail.com> Date: Tue, 29 Nov 2016 13:17:43 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: <20161129201404.GF23423@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/29/16 1:14 PM, Arnaldo Carvalho de Melo wrote: > It uses things like: > > if (kmem_page) { > struct perf_evsel *evsel; > > evsel = perf_evlist__find_tracepoint_by_name(session->evlist, > "kmem:mm_page_alloc"); > if (evsel == NULL) { > pr_err(errmsg, "page", "page"); > goto out_delete; > } > I thought something like existed but did not find it looking at kvm and sched commands. Will re-spin to be consistent with kmem.