From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751218AbdA1Jjv (ORCPT ); Sat, 28 Jan 2017 04:39:51 -0500 Received: from mout.web.de ([217.72.192.78]:53595 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750829AbdA1Jjq (ORCPT ); Sat, 28 Jan 2017 04:39:46 -0500 Subject: [PATCH 3/4] dcbnl: Adjust five checks for null pointers To: netdev@vger.kernel.org, "David S. Miller" , Pan Bian References: Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: <72caef1b-f525-2942-4c29-ea2976157ad6@users.sourceforge.net> Date: Sat, 28 Jan 2017 10:36:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:ekbbFo8MtPD/bO0/7MspFo5NWN/64MVhXtCopRWCYjgHxbpmkN7 f5qnjXlm2t5uOPWPV4e4/S43V9Y16pwcgrk1rHyVbKgLxgrW3+movQGGTLbLWY2LwjQ2SC5 RZVJnv1epQy42/F9KewobckS72CHmwRMu6hVnAgRPneEhWxg4p+LTK1FOY356gTtI2BVK3G 1EaApdfdQBFHcVduPyctw== X-UI-Out-Filterresults: notjunk:1;V01:K0:e1ttZr7qSSc=:Pi3kgeL1pvFUh+qPzExFYz 6B29fbtZwo2WmHIZt+V+Yz3ApdCd0t/Tz1HfZbKToHnuxdyAzF/W4wabxLxrzaO/BcDrxd5qN kLwOpIHzOaX1vH7Zfsl/niNQWh9vsIr0LzAAIUAqQvFrQZe15p2SzdU7jb6TIpYX8iAxzvC0a f1jRxLqkKuoQtyeDDo435mI7KiAjvy35JafM3DyWtSZz24aXQy4RlCnwmIZ0jUz6Bo3cYfY1U XmtLA5TaBImJAvWO/n49JwSiWIq5KJdSHf7oV43KntH694yAVicskdAlXhXZWLmUvVbJB2oXh zX70yJWImeMwmZWTBmYhCDrKdFvdJDhfibJCP0pLx7WQFrpDJYfNgm9jcB0vxmV8XTc3/r+Up Ul33eP02QXgP7KdQ1ThqDg9qdojv22Hv84cD9b1fIZVrZApJfkVIoLRvVkU6DVKYkkrsxKNTX t0TtWENMEnOSH2Y8mXDMYtxdgAnzecBD2zUb76dKgoXBGLHSnoOXBM9b+caBTpnclawxgKukZ fL0zMTgGHcgoeh6LhfRQ2xUn5YOKCIVEZ/BVCrx9jAEOIol9mniuRJmCoO3I8DqAmfzb2xLGa /4CKDeuTcZu8rfMmQ+k58lhMx3wMo8vwkpzuQXILQL6FLd32Pm6D+Z3KiPVkblqsQEfFLFerY kLN6OmsThfFmDjH2/2NjZuTAAOtrMRxC18oPy5bzZuC/KcbOusdWekC00s+6RjD1Apl43gP93 68Q/O6C9+MdjaPjcyUlfcBeF+4D56H8CZvf9TJ5lZpCYM+x6MCVH3bP/GJaDo2VOV9W5Tc0ke TAyk6W8bKWofIkHZQfxX29sARCavg== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 28 Jan 2017 09:56:36 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script "checkpatch.pl" pointed information out like the following. Comparison to NULL could be written !… Thus fix the affected source code places. Signed-off-by: Markus Elfring --- net/dcb/dcbnl.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/net/dcb/dcbnl.c b/net/dcb/dcbnl.c index f29e19d962ec..0903081a1212 100644 --- a/net/dcb/dcbnl.c +++ b/net/dcb/dcbnl.c @@ -398,7 +398,7 @@ static int dcbnl_setnumtcs(struct net_device *netdev, struct nlmsghdr *nlh, return ret; for (i = DCB_NUMTCS_ATTR_ALL+1; i <= DCB_NUMTCS_ATTR_MAX; i++) { - if (data[i] == NULL) + if (!data[i]) continue; value = nla_get_u8(data[i]); @@ -741,7 +741,7 @@ static int dcbnl_setpfccfg(struct net_device *netdev, struct nlmsghdr *nlh, return ret; for (i = DCB_PFC_UP_ATTR_0; i <= DCB_PFC_UP_ATTR_7; i++) { - if (data[i] == NULL) + if (!data[i]) continue; value = nla_get_u8(data[i]); netdev->dcbnl_ops->setpfccfg(netdev, @@ -955,7 +955,7 @@ static int dcbnl_bcn_setcfg(struct net_device *netdev, struct nlmsghdr *nlh, return ret; for (i = DCB_BCN_ATTR_RP_0; i <= DCB_BCN_ATTR_RP_7; i++) { - if (data[i] == NULL) + if (!data[i]) continue; value_byte = nla_get_u8(data[i]); netdev->dcbnl_ops->setbcnrp(netdev, @@ -963,7 +963,7 @@ static int dcbnl_bcn_setcfg(struct net_device *netdev, struct nlmsghdr *nlh, } for (i = DCB_BCN_ATTR_BCNA_0; i <= DCB_BCN_ATTR_RI; i++) { - if (data[i] == NULL) + if (!data[i]) continue; value_int = nla_get_u32(data[i]); netdev->dcbnl_ops->setbcncfg(netdev, @@ -1632,7 +1632,7 @@ static int dcbnl_setfeatcfg(struct net_device *netdev, struct nlmsghdr *nlh, goto err; for (i = DCB_FEATCFG_ATTR_ALL+1; i <= DCB_FEATCFG_ATTR_MAX; i++) { - if (data[i] == NULL) + if (!data[i]) continue; value = nla_get_u8(data[i]); -- 2.11.0