From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F5D0C4332F for ; Sun, 6 Nov 2022 16:26:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230022AbiKFQ0L convert rfc822-to-8bit (ORCPT ); Sun, 6 Nov 2022 11:26:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229804AbiKFQ0K (ORCPT ); Sun, 6 Nov 2022 11:26:10 -0500 Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80EFB640F for ; Sun, 6 Nov 2022 08:26:09 -0800 (PST) Received: from omf17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D682B1C652A; Sun, 6 Nov 2022 16:26:07 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf17.hostedemail.com (Postfix) with ESMTPA id 6487D17; Sun, 6 Nov 2022 16:25:20 +0000 (UTC) Message-ID: <72d228fc27951a7ba9e607d9fc433b3c64a801e3.camel@perches.com> Subject: Re: [PATCH] EDAC: altera: Remove unnecessary print function dev_err() From: Joe Perches To: wangkailong@jari.cn, bp@alien8.de, mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com, rric@kernel.org Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sun, 06 Nov 2022 08:26:04 -0800 In-Reply-To: References: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Rspamd-Queue-Id: 6487D17 X-Stat-Signature: nwagrj9zn7r167ofd8wyn3ziaqqiegqf X-Rspamd-Server: rspamout08 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX19NVUyMV9EgdLGR/NZuAAOGhLlXbrm2DI0= X-HE-Tag: 1667751920-668540 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2022-11-06 at 21:33 +0800, wangkailong@jari.cn wrote: > Eliminate the follow coccicheck warning: > > ./drivers/edac/altera_edac.c:2153:2-9: line 2153 is redundant because > platform_get_irq() already prints an error > ./drivers/edac/altera_edac.c:2188:2-9: line 2188 is redundant because > platform_get_irq() already prints an error [] > diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c [] > @@ -2150,7 +2150,6 @@ static int altr_edac_a10_probe(struct platform_device *pdev) > > edac->sb_irq = platform_get_irq(pdev, 0); > if (edac->sb_irq < 0) { > - dev_err(&pdev->dev, "No SBERR IRQ resource\n"); > return edac->sb_irq; > } Should delete now unnecessary braces too > > @@ -2185,7 +2184,6 @@ static int altr_edac_a10_probe(struct platform_device *pdev) > #else > edac->db_irq = platform_get_irq(pdev, 1); > if (edac->db_irq < 0) { > - dev_err(&pdev->dev, "No DBERR IRQ resource\n"); > return edac->db_irq; > } > irq_set_chained_handler_and_data(edac->db_irq,