From: Chao Yu <yuchao0@huawei.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
<linux-f2fs-devel@lists.sourceforge.net>
Subject: Re: [f2fs-dev] [PATCH 04/10] f2fs: support IO alignment for DATA and NODE writes
Date: Thu, 12 Jan 2017 19:15:07 +0800 [thread overview]
Message-ID: <72d90cfd-4496-ad66-bd02-74b4e570c7ac@huawei.com> (raw)
In-Reply-To: <20170104234444.GD1011@jaegeuk.local>
On 2017/1/5 7:44, Jaegeuk Kim wrote:
> On 01/04, Chao Yu wrote:
>> Hi Jaegeuk,
>>
>> On 2016/12/31 2:51, Jaegeuk Kim wrote:
>>> This patch implements IO alignment by filling dummy blocks in DATA and NODE
>>> write bios. If we can guarantee, for example, 32KB or 64KB for such the IOs,
>>> we can eliminate underlying dummy page problem which FTL conducts in order to
>>> close MLC or TLC partial written pages.
>>>
>>> Note that,
>>> - it requires "-o mode=lfs".
>>> - IO size should be power of 2, not exceed BIO_MAX_PAGES, 256.
>>> - read IO is still 4KB.
>>> - do checkpoint at fsync, if dummy NODE page was written.
>>
>> Which scenario we can benefit from? Any numbers?
>
> I described it in the patch. This is not targetting for performance improvement
> for now, but to address the dummy page write problem in FTL so that we can later
> implement very simple host-level FTL on top of open-channel SSD.
Alright, if we are doing this since FTL implementation is moved up, so I can
understand that.
Thanks,
>
>> I doubt that there are some potential side-effect points:
>> - write amplification will be more serious than before
>> - free space will be more fragmented since dummy blocks is separated in whole
>> address space
>> - there is less chance to merge small(unaligned) IOs in block layer
>
> I agree, so I just added this as a mount option experimentally.
> One point would be that, if f2fs doesn't do this, FTL should do it. So I think,
> from the system point of view, f2fs is a better layer to do it.
>
> Thanks,
>
>>
>> Thoughts?
>>
>> Thanks,
>
> .
>
next prev parent reply other threads:[~2017-01-12 11:18 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-30 18:51 [PATCH 01/10] f2fs: reassign new segment for mode=lfs Jaegeuk Kim
2016-12-30 18:51 ` [PATCH 02/10] f2fs: fix wrong tracepoints for op and op_flags Jaegeuk Kim
2017-01-04 3:25 ` [f2fs-dev] " Chao Yu
2016-12-30 18:51 ` [PATCH 03/10] f2fs: add submit_bio tracepoint Jaegeuk Kim
2017-01-04 3:32 ` [f2fs-dev] " Chao Yu
2017-01-04 23:35 ` [PATCH 03/10 v2] " Jaegeuk Kim
2017-01-12 11:07 ` Chao Yu
2016-12-30 18:51 ` [PATCH 04/10] f2fs: support IO alignment for DATA and NODE writes Jaegeuk Kim
2017-01-04 8:23 ` [f2fs-dev] " Chao Yu
2017-01-04 23:44 ` Jaegeuk Kim
2017-01-12 11:15 ` Chao Yu [this message]
2016-12-30 18:51 ` [PATCH 05/10] f2fs: get io size bit from mount option Jaegeuk Kim
2016-12-30 18:51 ` [PATCH 06/10] f2fs: show the max number of atomic operations Jaegeuk Kim
2017-01-04 8:45 ` Chao Yu
2017-01-04 23:50 ` [PATCH 06/10 v2] " Jaegeuk Kim
2017-01-12 11:15 ` Chao Yu
2016-12-30 18:51 ` [PATCH 07/10] f2fs: don't allow encrypted operations without keys Jaegeuk Kim
2017-01-04 8:56 ` [f2fs-dev] " Chao Yu
2016-12-30 18:51 ` [PATCH 08/10] f2fs: relax async discard commands more Jaegeuk Kim
2017-01-04 9:29 ` [f2fs-dev] " Chao Yu
2017-01-05 3:19 ` Chao Yu
2017-01-05 8:17 ` Chao Yu
2017-01-05 19:59 ` Jaegeuk Kim
2017-01-05 19:46 ` Jaegeuk Kim
2017-01-06 2:06 ` Chao Yu
2017-01-06 2:42 ` Jaegeuk Kim
2017-01-06 3:32 ` Chao Yu
2017-02-22 7:23 ` Chao Yu
2017-02-22 21:15 ` Jaegeuk Kim
2017-02-23 2:08 ` Chao Yu
2017-02-23 2:42 ` Jaegeuk Kim
2016-12-30 18:51 ` [PATCH 09/10] f2fs: avoid needless checkpoint in f2fs_trim_fs Jaegeuk Kim
2017-02-22 7:23 ` [f2fs-dev] " Chao Yu
2016-12-30 18:51 ` [PATCH 10/10] f2fs: return fs_trim if there is no candidate Jaegeuk Kim
2017-02-22 7:23 ` [f2fs-dev] " Chao Yu
2017-02-22 21:26 ` Jaegeuk Kim
2017-02-23 2:12 ` Chao Yu
2017-02-23 2:47 ` Jaegeuk Kim
2017-01-04 3:24 ` [f2fs-dev] [PATCH 01/10] f2fs: reassign new segment for mode=lfs Chao Yu
2017-01-04 22:48 ` Jaegeuk Kim
2017-01-12 11:03 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72d90cfd-4496-ad66-bd02-74b4e570c7ac@huawei.com \
--to=yuchao0@huawei.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®