From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A08BC38142 for ; Tue, 31 Jan 2023 14:30:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231473AbjAaOax (ORCPT ); Tue, 31 Jan 2023 09:30:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231297AbjAaOav (ORCPT ); Tue, 31 Jan 2023 09:30:51 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22B8DF74A for ; Tue, 31 Jan 2023 06:30:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675175404; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CnMa8Dx5VcMMm/Zxziptz0YY6DNnRe7DuNVWJX2ZiNI=; b=Xdl7Gx1WcpjABYq2IMArX0EMVIPP7Tvl7LT92UKlG90pw7blsUo3Ehe4OlGDi/rLE2VZGf A3zdas4y9lQ2htVIqGlaXeh6PFss8MXoKB0Hcx6zgbVKCqbOWkJLAkoWanVWs2Kr4Mv6Y5 RpE6f6WaSQllY92Os3ckrj0iOSstknY= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-652-6ousDReGP1-OcoHLNRM7Gg-1; Tue, 31 Jan 2023 09:30:02 -0500 X-MC-Unique: 6ousDReGP1-OcoHLNRM7Gg-1 Received: by mail-wr1-f71.google.com with SMTP id t3-20020adff043000000b002bfd38027fcso1910814wro.9 for ; Tue, 31 Jan 2023 06:30:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CnMa8Dx5VcMMm/Zxziptz0YY6DNnRe7DuNVWJX2ZiNI=; b=gZBNBvCpdx8DJXNWH+Gdqwq+LKe1VaKg4gtf7Fz/mp/cmdmWyvwB4TBzhbwkErcK1N QEnMyPgfItREZ752IaiIQU+OVSCNhBUcfhfJL6ejV+GO1LVQ6dlifaF4h1aVqk5PDuR+ 9wMJbReo80qNvv6K/KueJJOLWAYnc/NEBuuGQvantcfu3EJrQP1/3DwyD1BtWhyo7Y9K tJr68nKDOZ16FykvB47zELjENoIw14nHEb5XFcaJrWY/1CBlxENg1QmgZojS+mG0Tnl3 +WRyztKSzTfZklJkrnZFzRXYfJTVNOObr4j+WYJ+NenK+0QZfLIzTnV21sJFyoMIyLaK MJrA== X-Gm-Message-State: AO0yUKXsYbQ1Jj26G3+v6QHfzqM8FirAXfPZyhH+x6aNJUT6F9Hettjl v5knvDOkYDTjyhmJ1Zf2csSJUxmX2OYG5lqHrXewanUunlcoPKOdW4tBvEwvbhwNiThQUo7IJ/c UWobW2XaWlOFOC4yVQPK6gjuh X-Received: by 2002:a05:600c:511c:b0:3dc:5240:53b6 with SMTP id o28-20020a05600c511c00b003dc524053b6mr10041680wms.6.1675175401487; Tue, 31 Jan 2023 06:30:01 -0800 (PST) X-Google-Smtp-Source: AK7set9UX3DPxd3+kgFucScJG+BVpFrT5/64dwE6OpUMXKnU1NbzIRaiLPyFlDQrlDicVTUBQXTBCg== X-Received: by 2002:a05:600c:511c:b0:3dc:5240:53b6 with SMTP id o28-20020a05600c511c00b003dc524053b6mr10041651wms.6.1675175401113; Tue, 31 Jan 2023 06:30:01 -0800 (PST) Received: from ?IPV6:2003:d8:2f0a:ca00:f74f:2017:1617:3ec3? (p200300d82f0aca00f74f201716173ec3.dip0.t-ipconnect.de. [2003:d8:2f0a:ca00:f74f:2017:1617:3ec3]) by smtp.gmail.com with ESMTPSA id n17-20020a1c7211000000b003dc3f07c876sm13450391wmc.46.2023.01.31.06.30.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Jan 2023 06:30:00 -0800 (PST) Message-ID: <72dfedd2-a26a-17f4-87c2-3d71ab3f55b4@redhat.com> Date: Tue, 31 Jan 2023 15:29:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] mm/mmap: Fix vma_merge() offset when expanding the next vma Content-Language: en-US To: "Liam R. Howlett" , maple-tree@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , linux-next@vger.kernel.org, Sanan Hasanov , Matthew Wilcox , Hugh Dickins References: <20230130195713.2881766-1-Liam.Howlett@oracle.com> <97ea66a4-54a0-68a3-c42b-f3c36c69768e@redhat.com> <20230131142452.sfrmubta4ojejct2@revolver> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230131142452.sfrmubta4ojejct2@revolver> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31.01.23 15:24, Liam R. Howlett wrote: > * David Hildenbrand [230131 03:35]: >> On 30.01.23 20:57, Liam R. Howlett wrote: >>> The vm_pgoff was being set incorrectly when expanding the next VMA to a >>> lower address. Fix the issue by using the mid->vm_pgoff value for this >>> merge case (aka case 8). Note that this does not change case 3's >>> vm_pgoff as next and mid are the same VMA. >>> >>> Reported-by: Sanan Hasanov >>> Link: https://lore.kernel.org/linux-mm/IA1PR07MB983017D2FBA174D2FF78CEB6ABCE9@IA1PR07MB9830.namprd07.prod.outlook.com/ >>> Cc: Matthew Wilcox >>> Cc: David Hildenbrand >>> Cc: Hugh Dickins >> >> Fixes: ? > > Fixes: (soon to be invalid git id :) ("mm/mmap: remove __vma_adjust()") Ah, right, upstream was not affected ... :) ... so this should be squashed into that commit instead as long as it doesn't have a stable ID. -- Thanks, David / dhildenb