From: Tianyu Lan <Tianyu.Lan@microsoft.com>
To: "rkrcmar@redhat.com" <rkrcmar@redhat.com>,
Tianyu Lan <Tianyu.Lan@microsoft.com>
Cc: "pbonzini@redhat.com" <pbonzini@redhat.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] KVM/X86: Check input sreg values before loading vcpu
Date: Fri, 9 Mar 2018 07:24:13 +0000 [thread overview]
Message-ID: <72e27449-c8fd-c3e3-75c1-07853c49d974@microsoft.com> (raw)
In-Reply-To: <20180308161536.GH12290@flask>
Hi Radim:
Thanks for your review.
On 3/9/2018 12:15 AM, rkrcmar@redhat.com wrote:
> 2018-02-27 06:57+0000, Tianyu Lan:
>> From: Lan Tianyu <Tianyu.Lan@microsoft.com>
>>
>> This patch is to check sreg value first and then load vcpu in order
>> to avoid redundant loading/putting vcpu.
>>
>> Signed-off-by: Lan Tianyu <Tianyu.Lan@microsoft.com>
>> ---
>
> Patch "KVM: x86: KVM_CAP_SYNC_REGS" made significant changes to the
> sregs setter, so the patch cannot be applied in current form.
>
> I think that moving the X86_CR4_OSXSAVE check to guest_cpuid_has still
> makes sense, but avoiding the vcpu_load/put would produce worse code
> elsewhere and avoiding the load/put is not critical as any error is
> probably going to be the end for this VM.
>
OK. I will update patch.
prev parent reply other threads:[~2018-03-09 7:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 6:57 Tianyu Lan
2018-03-08 16:15 ` rkrcmar
2018-03-09 7:24 ` Tianyu Lan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72e27449-c8fd-c3e3-75c1-07853c49d974@microsoft.com \
--to=tianyu.lan@microsoft.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome