From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751105AbdFSSa7 (ORCPT ); Mon, 19 Jun 2017 14:30:59 -0400 Received: from lelnx194.ext.ti.com ([198.47.27.80]:55573 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751029AbdFSSa4 (ORCPT ); Mon, 19 Jun 2017 14:30:56 -0400 Subject: Re: [PATCH v2 3/3] iio: adc: Fix polling of INA219 conversion ready flag To: =?UTF-8?Q?Br=c3=bcns=2c_Stefan?= , Jonathan Cameron CC: "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler References: <20170524000907.7788-1-stefan.bruens@rwth-aachen.de> <20170524205335.166b7085@kernel.org> <20170524205641.20252455@jic23.retrosnub.co.uk> <1598491.c75bYYbHRJ@sbruens-linux> From: "Andrew F. Davis" Message-ID: <72e8186a-101e-f1e3-b7f4-19a0805ff1af@ti.com> Date: Mon, 19 Jun 2017 13:30:31 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1598491.c75bYYbHRJ@sbruens-linux> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/19/2017 01:24 PM, Brüns, Stefan wrote: > On Mittwoch, 24. Mai 2017 21:56:54 CEST Jonathan Cameron wrote: >> On Wed, 24 May 2017 20:53:35 +0100 >> >> Jonathan Cameron wrote: >>> On Wed, 24 May 2017 02:09:07 +0200 >>> >>> Stefan Brüns wrote: >>>> While the INA226 has a conversion ready flag (CVRF) in the R/W >>>> Mask/Enable >>>> register with read-to-clear semantics, the corresponding bit of the >>>> INA219 >>>> (CNVR) is part of the bus voltage register. The flag is cleared by >>>> reading >>>> the power register. >>>> >>>> Signed-off-by: Stefan Brüns >>> >>> Again, looks good to me, but I would like input form Marc or Andrew >>> who are more familiar with these devices than me! >>> >>> Ping me in a week or two if nothing is happening and I look to have >>> lost these! >> >> Ah Marc's old email is bouncing. If no one has a more up to >> data address I guess we'll be looking at Andrew to have a chance to >> respond (which is more likely if I actually cc him ;) > > Ping ;-) > As for me, my silence is approval, nothing looks incorrect to me. > Kind regards, > > Stefan >