From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACC5BC2BB84 for ; Thu, 17 Sep 2020 01:21:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6456C2075E for ; Thu, 17 Sep 2020 01:21:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726151AbgIQBU6 (ORCPT ); Wed, 16 Sep 2020 21:20:58 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:44052 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726011AbgIQBUy (ORCPT ); Wed, 16 Sep 2020 21:20:54 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id C82E18A2BAD876DB442E; Thu, 17 Sep 2020 09:05:30 +0800 (CST) Received: from [10.136.114.67] (10.136.114.67) by smtp.huawei.com (10.3.19.202) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 17 Sep 2020 09:05:28 +0800 Subject: Re: [PATCH] erofs: remove unneeded parameter To: Gao Xiang , Chao Yu CC: , References: <20200916140604.3799-1-chao@kernel.org> <20200916143304.GA23176@xiangao.remote.csb> <20200916143648.GA23921@xiangao.remote.csb> From: Chao Yu Message-ID: <72eab76b-0b05-2e0e-d711-8961a254a49a@huawei.com> Date: Thu, 17 Sep 2020 09:05:28 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200916143648.GA23921@xiangao.remote.csb> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.114.67] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Xiang, On 2020/9/16 22:36, Gao Xiang wrote: > On Wed, Sep 16, 2020 at 10:33:04PM +0800, Gao Xiang wrote: >> Hi Chao, >> >> On Wed, Sep 16, 2020 at 10:06:04PM +0800, Chao Yu wrote: >>> From: Chao Yu >>> >>> In below call path, no page will be cached into @pagepool list >>> or grabbed from @pagepool list: >>> - z_erofs_readpage >>> - z_erofs_do_read_page >>> - preload_compressed_pages >>> - erofs_allocpage >>> >>> Let's get rid of this unneeded parameter. >> >> That would be unneeded after .readahead() is introduced recently >> (so add_to_page_cache_lru() is also moved to mm code), so I agree >> with you on it. > > (cont.) > > ... also it'd be better to add such historical reason to the commit > message... since it was of some use before... No problem, let me revise it in v2. :) Thanks, > > Thanks, > Gao Xiang > > . >