From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Linus Torvalds <torvalds@linuxfoundation.org>
Cc: Kiryl Shutsemau <kas@kernel.org>,
Tal Zussman <tz2294@columbia.edu>, n3rd <18670333770@163.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"ljs@kernel.org" <ljs@kernel.org>,
"ziy@nvidia.com" <ziy@nvidia.com>,
Mike Rapoport <rppt@kernel.org>,
"peterx@redhat.com" <peterx@redhat.com>,
"security@kernel.org" <security@kernel.org>,
"Jose A. Perez de Azpillaga" <azpijr@gmail.com>
Subject: Re: [SECURITY] mm: khugepaged collapse_file() drops RWP PTE markers
Date: Wed, 11 Nov 2026 22:35:34 +0100 [thread overview]
Message-ID: <72f286d5-3f1d-4350-b463-09f7b320cacf@kernel.org> (raw)
In-Reply-To: <CAHk-=wh=cVrn+xs3fZiPW=kJbFQLwf_C+c-YBCR2K9s9aNE_1Q@mail.gmail.com>
On 11/11/26 21:55, Linus Torvalds wrote:
> On Wed, 11 Nov 2026 at 12:20, David Hildenbrand (Arm) <david@kernel.org> wrote:
>>
>> It would be a lot more consistent if we'd just add marker support. Or is there a
>> good reason why that is explicitly not wanted?
>
> Let's not help people do things that won't work on older kernels for
> no real gain.
Uffd folks usually indicate such things through new uffd features.
>
> Is there an actual real-life user that would care and be enormously
> helped by such a thing and it would increase performance or something?
> That sounds very unlikely, since presumably re-faulting never happens
> in practice, so just tracking it in user space is "free".
>
> In the absence of some real load with a real argument for it, please
> let's just document existing behavior to the fact that you need to
> simply see the re-faulting of these things..
Just to express why I would even dare proposing to implement something in
userfaultfd: in Kiryl's series we abstracted the uffd-wp PTE bit to a uffd PTE
bit, which made things more generic.
Abstracting uffd-wp markers to uffd markers would similarly make things more
generic.
A quick codex prompt tells me: 90 insertions, 95 deletions.
But most changes are documentation either way, so that doesn't reflect reality.
Now let's ignore what I wrote above, I just polished another uffd fix and most
fixes I looked at throughout the last days were uffd related, which is starting
to get annoying.
So yes, no new uffd features.
--
Cheers,
David
next prev parent reply other threads:[~2026-11-11 21:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <606cae9e.bbec5.1a1c54f4f9f.Coremail.18670333770@163.com>
2026-11-10 11:55 ` David Hildenbrand (Arm)
2026-11-11 3:19 ` Tal Zussman
2026-11-11 7:29 ` David Hildenbrand (Arm)
2026-11-11 18:53 ` Kiryl Shutsemau
2026-11-11 19:18 ` Linus Torvalds
2026-11-11 19:43 ` David Hildenbrand (Arm)
2026-11-11 20:55 ` Linus Torvalds
2026-11-11 21:35 ` David Hildenbrand (Arm) [this message]
2026-11-11 21:59 ` Linus Torvalds
2026-11-11 19:43 ` Jose A. Perez de Azpillaga
2026-11-11 19:53 ` Kiryl Shutsemau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72f286d5-3f1d-4350-b463-09f7b320cacf@kernel.org \
--to=david@kernel.org \
--cc=18670333770@163.com \
--cc=akpm@linux-foundation.org \
--cc=azpijr@gmail.com \
--cc=kas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=peterx@redhat.com \
--cc=rppt@kernel.org \
--cc=security@kernel.org \
--cc=torvalds@linuxfoundation.org \
--cc=tz2294@columbia.edu \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®