From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 575EF42903F for ; Mon, 27 Jul 2026 20:32:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785184355; cv=none; b=fqdLsSiYN51DzkHK9UiR4YDLLthNzwZ68WHZ+Lj0e3lTG2ona77SFyn7x/OQY+T0/C+bR9bRSjzIQlKffoMqZzHsq+qp/zxKjGwVmTmpdEamrtzjmezkai1DIdu8LjTGfyEFDBw3gFfzng7hJr4seJHJtUbPWsoByy8xFC7Dfug= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785184355; c=relaxed/simple; bh=BfjfrnhbcO2VLWkVFLXa6+RW3NO0V5ODITqAYIm/TiQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LKIDPuldE70ITmmxMkHhxJAwke4Qz+akA0YfyYSaRU/e+vS91BH9d545cwWzDynzWke40Ddq5BXXWKDcwF0D/AA5pLaZjzQ+38MxR5Vs9h2Rro5hQsgsWqwwRy90/X6etAAQ95VRgyDNoMI8CWZdB/Pf7lY3jIgj5w1cvyUTvDM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=n6MxV5Xn; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n6MxV5Xn" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2cf6d65d8a7so46715005ad.0 for ; Mon, 27 Jul 2026 13:32:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785184353; x=1785789153; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=HXpvuPVqT3NSYIRT/XpZ2ZRtWOA79+OnBYVQ1PWJH2c=; b=n6MxV5XnWmJZ6+G7NJSlADwG8W6/K1F3zTyey3n0mSuaE7C4qlgZIW0JgVyR1hUwE5 M/hWNqC0Dt6miOH+1pfSBqDKLQkLkXbxUMaAdYS8hINuRGt66GnGab+MWpZjnkH/G0Jm JVvEbSlpBoItz5cm9MLoLUOk2M9BqxTmmOQNgdWCtCq5vH/P0EdWU+wr4Esi1uYEIZIQ ccLGf+3eC0jUmPMcBgNAMxCDmJvH+aPqTSNguTW3lQmLehxGzmhqFx93D1G8Nx0OBpID fRv5q06vbXvRY9sCoPKey9l1ir1QQZnwqaga4L3dSAS3oW+D+ShoiLYA/Q/YIaaWoC1n WnBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785184353; x=1785789153; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=HXpvuPVqT3NSYIRT/XpZ2ZRtWOA79+OnBYVQ1PWJH2c=; b=OqWu9q28wouoMtveI0mZ1DCfBVNHSY8eLmHjHMDfGgQ5dO8Ha4uYLdKR+ou9oL7pML oXTPcR1kk8xhp+f7N3Ez56o5+uHOiFuB9O0jsYZdX91Wth58aHxPP83A+0CgatYVVrgV cp8urCI3EV60Re4jYG/N//u83n2gMxgxrThY8jxMVdBdA8TEXobUTpt9rcw9kKUGiz1j tLGtwA43sCPv1zJtLcdY5LRW0tigopheG0yF5FIjH5jDV9OlJrq/6zigbgtcydruE7SC 3zeK8n7ep6uhkDX1F6Gjo4P70oHugciapXMHezaaMBaSMqDPlGdMfGM8IEcqp97099KG 12vQ== X-Forwarded-Encrypted: i=1; AHgh+RqmtRxg0mrZqvKU0znZCxHnpF8WpxPzW+vmGNec3LxSFjd3kkKEcOO+5IZjqFTIXNsm05ZWaCMv+9UiUkY=@vger.kernel.org X-Gm-Message-State: AOJu0Yyjmmqn/KQGhBYQPfGLmHIbLw1pVf0t1D2/VJlxNM6oFcxUiYeF 0WNFsXyha4oczwbCOIUmDpIioKr6PN2rLm1Dh0eqwYNvoPl6kSXLo+D2 X-Gm-Gg: AR+sD12/0wh4LOchy+MF5i6lEJa64ilPtlicLxu1fTv9stf6fy0q1X7cEPCTnnAUdS4 o3DhhYSN2V/oHRqHjZpS0AXCvueWLZhavWKCuUilE/k1dqWkXP1dPM3duyNPLlDkKVgp3qg2EAr H7eqh8tuVLRw59mUUYVTdD7OSlK6y3cGTDvVC8DSUoKuvEbQTbarcqdiB/LwhkiTCr+Gx27+0aH QaYRI7J3vqL7U6BqVAVEBc15PgVYrRMfSkiG8DTGetEmZqm0MKy4UJTndE5o4Nq9kzOowvHUQub 0xASiAcq/UC9M1tRihJluvAQNYBnby6zkt6oOImw1xqiOy60lwJoKCR4x0MtHZgFBu6YLxt7YRF tZt6ZDTp0nrATqVAo+7IX0C/J+NLb07fQgLi1EdJAoeoDLgkckDFbw16dC8rpxsE+ewept2R9d3 nfwydk X-Received: by 2002:a17:902:f787:b0:2ca:2073:3119 with SMTP id d9443c01a7336-2cfde86bc98mr94605435ad.32.1785184352698; Mon, 27 Jul 2026 13:32:32 -0700 (PDT) Received: from cryptic.lan ([2001:569:7fab:e200:3789:64f9:8855:c0af]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cfde59b768sm41551805ad.4.2026.07.27.13.32.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2026 13:32:31 -0700 (PDT) From: Allen Pais To: Vinod Koul , Frank Li Cc: Allen Pais , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann , Kees Cook , Michal Simek , Abin Joseph , Radhey Shyam Pandey , Sakari Ailus , linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 21/64] dmaengine: zynqmp-dma: switch completion tasklet to dma_chan BH Date: Mon, 27 Jul 2026 13:28:49 -0700 Message-ID: <72f509130ced9fd642dbf3906d253f5addff444d.1785183549.git.allen.lkml@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: <20260108080332.2341725-1-allen.lkml@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace the per-channel tasklet with the shared dma_chan BH helper. The handler continues to run in softirq context while dmaengine owns the common scheduling and teardown mechanism. Signed-off-by: Allen Pais --- drivers/dma/xilinx/zynqmp_dma.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dma.c index f6a812e49ddc..6291126cdc9f 100644 --- a/drivers/dma/xilinx/zynqmp_dma.c +++ b/drivers/dma/xilinx/zynqmp_dma.c @@ -207,7 +207,6 @@ struct zynqmp_dma_desc_sw { * @dev: The dma device * @irq: Channel IRQ * @is_dmacoherent: Tells whether dma operations are coherent or not - * @tasklet: Cleanup work after irq * @idle : Channel status; * @desc_size: Size of the low level descriptor * @err: Channel has errors @@ -232,7 +231,6 @@ struct zynqmp_dma_chan { struct device *dev; int irq; bool is_dmacoherent; - struct tasklet_struct tasklet; bool idle; size_t desc_size; bool err; @@ -735,7 +733,7 @@ static irqreturn_t zynqmp_dma_irq_handler(int irq, void *data) writel(isr, chan->regs + ZYNQMP_DMA_ISR); if (status & ZYNQMP_DMA_INT_DONE) { - tasklet_schedule(&chan->tasklet); + dma_chan_schedule_bh(&chan->common); ret = IRQ_HANDLED; } @@ -744,7 +742,7 @@ static irqreturn_t zynqmp_dma_irq_handler(int irq, void *data) if (status & ZYNQMP_DMA_INT_ERR) { chan->err = true; - tasklet_schedule(&chan->tasklet); + dma_chan_schedule_bh(&chan->common); dev_err(chan->dev, "Channel %p has errors\n", chan); ret = IRQ_HANDLED; } @@ -760,11 +758,12 @@ static irqreturn_t zynqmp_dma_irq_handler(int irq, void *data) /** * zynqmp_dma_do_tasklet - Schedule completion tasklet - * @t: Pointer to the ZynqMP DMA channel structure + * @c: Pointer to the ZynqMP DMA channel structure */ -static void zynqmp_dma_do_tasklet(struct tasklet_struct *t) +static void zynqmp_dma_do_tasklet(struct dma_chan *c) { - struct zynqmp_dma_chan *chan = from_tasklet(chan, t, tasklet); + struct zynqmp_dma_chan *chan = container_of(c, + struct zynqmp_dma_chan, common); u32 count; unsigned long irqflags; @@ -815,7 +814,7 @@ static void zynqmp_dma_synchronize(struct dma_chan *dchan) { struct zynqmp_dma_chan *chan = to_chan(dchan); - tasklet_kill(&chan->tasklet); + dma_chan_kill_bh(&chan->common); } /** @@ -887,7 +886,7 @@ static void zynqmp_dma_chan_remove(struct zynqmp_dma_chan *chan) if (chan->irq) devm_free_irq(chan->zdev->dev, chan->irq, chan); - tasklet_kill(&chan->tasklet); + dma_chan_kill_bh(&chan->common); list_del(&chan->common.device_node); } @@ -937,7 +936,7 @@ static int zynqmp_dma_chan_probe(struct zynqmp_dma_device *zdev, chan->is_dmacoherent = of_property_read_bool(node, "dma-coherent"); zdev->chan = chan; - tasklet_setup(&chan->tasklet, zynqmp_dma_do_tasklet); + dma_chan_init_bh(&chan->common, zynqmp_dma_do_tasklet); spin_lock_init(&chan->lock); INIT_LIST_HEAD(&chan->active_list); INIT_LIST_HEAD(&chan->pending_list); -- 2.43.0