From: Jan Kiszka <jan.kiszka@siemens.com>
To: Joe Perches <joe@perches.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH 3/3] stmmac: pci: Use dmi_system_id table for retrieving PHY addresses
Date: Mon, 22 May 2017 14:49:18 +0200 [thread overview]
Message-ID: <72ff21ba-f774-b3d5-23b4-e70095cedbef@siemens.com> (raw)
In-Reply-To: <1495452830.2093.14.camel@perches.com>
On 2017-05-22 13:33, Joe Perches wrote:
> On Mon, 2017-05-22 at 13:12 +0200, Jan Kiszka wrote:
>> Avoids reimplementation of DMI matching in stmmac_pci_find_phy_addr.
> []
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c
> []
>> @@ -31,65 +31,78 @@
> []
>> +static const struct stmmac_pci_dmi_data iot2040_stmmac_dmi_data[] = {
>> {
>> - .name = "GalileoGen2",
>> .func = 6,
>> .phy_addr = 1,
>> },
>> {
>> - .name = "SIMATIC IOT2000",
>> - .asset_tag = "6ES7647-0AA00-0YA2",
>> - .func = 6,
>> + .func = 7,
>
> Why change this from 6 to 7?
>
The diff is confusing here: If you look at the outcome, we now have
galileo_stmmac_dmi_data with function 6 only (also used for the
IOT2020), and iot2040_stmmac_dmi_data with both function 6 and 7 (both
MACs are wired up).
Jan
--
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2017-05-22 12:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 11:12 [PATCH 0/3] stmmac: pci: Refactor DMI probing Jan Kiszka
2017-05-22 11:12 ` [PATCH 1/3] stmmac: pci: Overcome stmmac_pci_info structure Jan Kiszka
2017-05-22 17:09 ` Andy Shevchenko
2017-05-23 13:48 ` kbuild test robot
2017-05-22 11:12 ` [PATCH 2/3] stmmac: pci: Make stmmac_pci_find_phy_addr truly generic Jan Kiszka
2017-05-22 11:12 ` [PATCH 3/3] stmmac: pci: Use dmi_system_id table for retrieving PHY addresses Jan Kiszka
2017-05-22 11:33 ` Joe Perches
2017-05-22 12:49 ` Jan Kiszka [this message]
2017-05-22 13:13 ` Joe Perches
2017-05-22 16:59 ` Andy Shevchenko
2017-05-22 16:35 ` [PATCH 0/3] stmmac: pci: Refactor DMI probing David Miller
2017-05-22 17:06 ` Jan Kiszka
2017-05-22 18:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72ff21ba-f774-b3d5-23b4-e70095cedbef@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=alexandre.torgue@st.com \
--cc=andy.shevchenko@gmail.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®