From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [80.241.56.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B38603BFE44 for ; Wed, 25 Feb 2026 13:37:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=80.241.56.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772026671; cv=none; b=OJneNZBdXvTgs2YVgO24JwWVXViZ4Emh+FD4grUKhgvQuD9brjPJ6h+c8dvlbk92YTROcHSgoP2W2XNw8C5SUolj6QcmxNvhzxTgrEnzYykEP379X2EfGHIDLJH1wML/utzR+u+g5V0aZvkzzPqbIDuUlNuWlidchxTe/1PGLEw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772026671; c=relaxed/simple; bh=ozLOy6FgmWkMnPRca81xNgD3oL6vesXFFhzfZs3pXf0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mi0tXDJ93cBmVM0sBMGnKDeX5TiJC49cpEOtFdfZZ1tL7/q/9tsFLPNSjnp2riXTv1/9wPqS8WZ0cnYFi/zXTPWTMbUTVq8bQnwiIBMaHMq7GMG5ybrLcuzPtoDX9/oPKMsmR1gcPRV7nMYRq/o04r9qMqTUyYMr6+8zCDC9noI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org; spf=pass smtp.mailfrom=mailbox.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b=nd+GYY78; arc=none smtp.client-ip=80.241.56.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mailbox.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="nd+GYY78" Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4fLbHk6Wvkz9v92; Wed, 25 Feb 2026 14:37:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1772026659; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CctRGKbjHRhQNeruJvsG/6b4mLUQF7gvnBxGhSS+a9E=; b=nd+GYY78TUf3J9IRaTpnqpOFqI9xp3EK4M/XIZtKzPVLGng/OD6Jxq72wL8Op59OTMmJH5 pl12Y5fvn9J3didpw+QSAInEtJe/KTjPbnVtx1S+h4yPGaujTn+2YvKzhCi/lmdYKildjr gjLdPCRwOJVcQm4uPcsh3bnoGV9EclJchy3pun6TmvYM95eu7QTXf8sLhBbyaOkr8WXuOS 2mLSC1dih6rcXRIAfOpkXOZdJsjeCAzOUqGbq2IDv6cn/keWixiy33ZXF08axAeu4xYmTG BktRutt5B33fmD7aUB+y2q+lgl3pvIoR2JDR/ik2ODeQdpw6bG1MpSQruc44/Q== Message-ID: <7300ad7c-39a5-4424-b4fd-9d3f97083f06@mailbox.org> Date: Wed, 25 Feb 2026 14:37:34 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [RFC PATCH v3 0/3] Querying errors from drm_syncobj To: =?UTF-8?Q?Christian_K=C3=B6nig?= , Yicong Hui Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, david.hunter.linux@gmail.com, Tvrtko Ursulin , Philipp Stanner , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann References: <20260225124609.968505-1-yiconghui@gmail.com> <3491d5f9-d08e-4193-a983-45340af73745@amd.com> From: =?UTF-8?Q?Michel_D=C3=A4nzer?= Content-Language: en-CA In-Reply-To: <3491d5f9-d08e-4193-a983-45340af73745@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-MBO-RS-ID: 9283f5bdaeeabfe4b6a X-MBO-RS-META: fytwafjzzbnuwbbyt6bbicjzmzdod3wc On 2/25/26 14:25, Christian König wrote: > On 2/25/26 13:46, Yicong Hui wrote: >> This patch series adds 2 new flags, DRM_SYNCOBJ_QUERY_FLAGS_ERROR and >> DRM_SYNCOBJ_WAIT_FLAGS_ABORT_ON_ERROR for 3 ioctl operations >> DRM_IOCTL_SYNCOBJ_QUERY, DRM_IOCTL_SYNCOBJ_WAIT and >> DRM_IOCTL_SYNCOBJ_TIMELINE_WAIT to allow them to batch-request error >> codes from multiple syncobjs and abort early upon error of any of them. > > Patch #1 looks good enough to add my rb. > > Patch #2 looks good as well, but I'm not familiar enough with the code and have no time to wrap my head around it to give a review. > > Adding a few people on CC, maybe somebody has time to take another look. > >> >> Based on discussions from Michel Dänzer and Christian König, and a >> starter task from the DRM todo documentation. >> >> See https://gitlab.gnome.org/GNOME/mutter/-/issues/4624 for discussions >> on userspace implementation. >> >> I have looked into adding sub test cases into syncobj_wait.c and >> syncobj_timeline.c, igt-tests for this and I think I understand the >> process for writing tests and submitting them, however, these ioctls >> only trigger in the case that there is an error, but I am not sure what >> is the best way to artifically trigger an error from userspace in order >> to test that these ioctl flags work. What's the recommended way to >> approach this? > > When Michel agrees that this is the way to go then we either need an in-kernel selftest (see directory drivers/gpu/drm/tests/) or an userspace IGT test. > > Not sure what is more appropriate, maybe somebody on CC has more experience with that. I'd advise against landing this in the kernel before there's a corresponding display server implementation making use of it, in a mergeable state. Otherwise you might end up with the kernel having to support UAPI which no real-world user space actually uses. Been there, done that myself. I don't have the capacity to contribute anything more than advice at this point. -- Earthling Michel Dänzer \ GNOME / Xwayland / Mesa developer https://redhat.com \ Libre software enthusiast