From: Joe Perches <joe@perches.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>,
Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] xfs: Remove noinline from #define STATIC
Date: Sat, 10 Nov 2018 17:21:49 -0800 [thread overview]
Message-ID: <7302f4a13c1cbf62b07f636878ce25fcca84b6c4.camel@perches.com> (raw)
Reduce total object size quite a bit (~32KB) and presumably
improve performance at the same time.
Total object size old vs new (x86-64 defconfig with xfs)
text data bss dec hex filename
- 959351 165573 632 1125556 112cb4 (TOTALS) (old)
+ 924683 165669 632 1090984 10a5a8 (TOTALS) (new)
Signed-off-by: Joe Perches <joe@perches.com>
---
fs/xfs/xfs_linux.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_linux.h b/fs/xfs/xfs_linux.h
index edbd5a210df2..f33c8b626bca 100644
--- a/fs/xfs/xfs_linux.h
+++ b/fs/xfs/xfs_linux.h
@@ -242,7 +242,7 @@ static inline uint64_t howmany_64(uint64_t x, uint32_t y)
#endif /* XFS_WARN */
#endif /* DEBUG */
-#define STATIC static noinline
+#define STATIC static
#ifdef CONFIG_XFS_RT
next reply other threads:[~2018-11-11 1:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-11 1:21 Joe Perches [this message]
2018-11-12 20:12 ` Eric Sandeen
2018-11-12 21:05 ` Joe Perches
2018-11-12 21:45 ` Dave Chinner
2018-11-12 22:30 ` Joe Perches
2018-11-13 1:18 ` Dave Chinner
2018-11-13 1:54 ` Theodore Y. Ts'o
2018-11-13 3:09 ` Dave Chinner
2018-11-13 4:23 ` Joe Perches
2018-11-13 5:26 ` Dave Chinner
2018-11-13 5:31 ` Joe Perches
2018-11-13 5:44 ` Darrick J. Wong
2018-11-15 10:12 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7302f4a13c1cbf62b07f636878ce25fcca84b6c4.camel@perches.com \
--to=joe@perches.com \
--cc=darrick.wong@oracle.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®