From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBD70C74A5B for ; Tue, 21 Mar 2023 03:54:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229715AbjCUDyL (ORCPT ); Mon, 20 Mar 2023 23:54:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229449AbjCUDyJ (ORCPT ); Mon, 20 Mar 2023 23:54:09 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 415AF23879 for ; Mon, 20 Mar 2023 20:54:07 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 99695AD7; Mon, 20 Mar 2023 20:54:50 -0700 (PDT) Received: from [10.162.42.6] (unknown [10.162.42.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0E8FC3F67D; Mon, 20 Mar 2023 20:54:04 -0700 (PDT) Message-ID: <730417dd-43b6-67f4-922a-97d2ceb298bc@arm.com> Date: Tue, 21 Mar 2023 09:24:02 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] arm64: Support CMDLINE_EXTEND Content-Language: en-US To: Chris Packham , catalin.marinas@arm.com, will@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230320211451.2512800-1-chris.packham@alliedtelesis.co.nz> From: Anshuman Khandual In-Reply-To: <20230320211451.2512800-1-chris.packham@alliedtelesis.co.nz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Chris, On 3/21/23 02:44, Chris Packham wrote: > Support extending the bootloader provided command line for arm64 > targets. This support is already present via generic DT/EFI code the > only thing required is for the architecture to make it selectable. Does this config really depend on given platform's active support or it is just matter of selecting this for interested platforms ? Could this config definition be unified in a single place i.e arch/Kconfig and be selected (unconditionally or conditionally) on all subscribing platforms. There seems to be a redundancy in defining the exact same config the same way, on multiple platforms. $git grep "config CMDLINE_EXTEND" arch/arm/Kconfig:config CMDLINE_EXTEND arch/loongarch/Kconfig:config CMDLINE_EXTEND arch/powerpc/Kconfig:config CMDLINE_EXTEND arch/riscv/Kconfig:config CMDLINE_EXTEND arch/sh/Kconfig:config CMDLINE_EXTEND I guess this redundancy should be removed as a pre-requisite, before enabling it on arm64 as proposed here, which in itself seems alright. > > Signed-off-by: Chris Packham > --- > arch/arm64/Kconfig | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 1023e896d46b..3c837b085f21 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -2228,6 +2228,12 @@ config CMDLINE_FROM_BOOTLOADER > the boot loader doesn't provide any, the default kernel command > string provided in CMDLINE will be used. > > +config CMDLINE_EXTEND > + bool "Extend bootloader kernel arguments" > + help > + The command-line arguments provided by the boot loader will be > + appended to the default kernel command string. > + > config CMDLINE_FORCE > bool "Always use the default kernel command string" > help