From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cc: Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Rob Herring <robh+dt@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Prabhakar <prabhakar.csengg@gmail.com>,
<linux-ide@vger.kernel.org>
Subject: Re: [PATCH v3 07/10] ata: pata_platform: Merge pata_of_platform into pata_platform
Date: Mon, 27 Dec 2021 23:55:50 +0300 [thread overview]
Message-ID: <73042c85-c194-e1c8-296c-6d9322624d83@omp.ru> (raw)
In-Reply-To: <a0f90ec0-b49a-de0d-b8f5-0443cb904847@omp.ru>
On 12/27/21 11:54 PM, Sergey Shtylyov wrote:
[...]
>> ...
>>
>>> + if ((pdev->num_resources != 3) && (pdev->num_resources != 2)) {
>>> + dev_err(&pdev->dev, "invalid number of resources\n");
>>> + return -EINVAL;
>>
>> return dev_err_probe(); ?
>>
>>> + }
>>
>> ...
>>
>>> + if (!dev_of_node(&pdev->dev))
>>> + ret = pata_platform_get_pdata(pdev, priv);
>>> + else
>>> + ret = pata_of_platform_get_pdata(pdev, priv);
>>
>> What the difference between them?
>
> One parses DT props into the private structure, the other inits this structure without DT...
>
>> Can't you unify them and leave only
>> DT related part separately?
>
> He can't -- grep *defconfig for PATA_PLATFORM=, please.
I take it back -- I think I misunderstood. :-)
> [...]
MBR, Sergey
next prev parent reply other threads:[~2021-12-27 20:55 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-24 13:12 [PATCH v3 00/10] ata: pata_platform: Refurbish the driver Lad Prabhakar
2021-12-24 13:12 ` [PATCH v3 01/10] ata: pata_platform: Make use of platform_get_mem_or_io() Lad Prabhakar
2021-12-24 17:56 ` Sergey Shtylyov
2021-12-24 18:01 ` Lad, Prabhakar
2021-12-24 13:12 ` [PATCH v3 02/10] ata: pata_platform: Drop use of unlikely() in pata_platform_probe Lad Prabhakar
2021-12-24 17:54 ` Sergey Shtylyov
2021-12-24 18:02 ` Lad, Prabhakar
2021-12-26 11:56 ` Damien Le Moal
2021-12-26 14:21 ` Lad, Prabhakar
2021-12-24 13:12 ` [PATCH v3 03/10] ata: pata_of_platform: Use platform_get_irq_optional() to get the interrupt Lad Prabhakar
2021-12-25 17:01 ` Andy Shevchenko
2021-12-25 17:13 ` Lad, Prabhakar
2021-12-27 19:48 ` Sergey Shtylyov
2021-12-24 13:12 ` [PATCH v3 04/10] ata: pata_platform: " Lad Prabhakar
2021-12-27 19:58 ` Sergey Shtylyov
2021-12-28 9:33 ` Sergey Shtylyov
2022-01-04 19:42 ` Lad, Prabhakar
2021-12-24 13:12 ` [PATCH v3 05/10] ata: pata_platform: Drop checking IRQ number Lad Prabhakar
2021-12-27 20:03 ` Sergey Shtylyov
2021-12-24 13:12 ` [PATCH v3 06/10] ata: pata_of_platform: Make use of platform_get_mem_or_io() Lad Prabhakar
2021-12-27 20:05 ` Sergey Shtylyov
2021-12-24 13:12 ` [PATCH v3 07/10] ata: pata_platform: Merge pata_of_platform into pata_platform Lad Prabhakar
2021-12-25 17:16 ` Andy Shevchenko
2021-12-25 17:25 ` Lad, Prabhakar
2021-12-25 17:37 ` Andy Shevchenko
2021-12-27 20:54 ` Sergey Shtylyov
2021-12-27 20:55 ` Sergey Shtylyov [this message]
2021-12-27 20:36 ` Sergey Shtylyov
2021-12-24 13:12 ` [PATCH v3 08/10] ata: pata_platform: Drop validating num_resources count Lad Prabhakar
2021-12-27 20:38 ` Sergey Shtylyov
2021-12-24 13:12 ` [PATCH v3 09/10] ata: pata_platform: Sort the #includes alphabetically Lad Prabhakar
2021-12-27 20:40 ` Sergey Shtylyov
2021-12-24 13:12 ` [PATCH v3 10/10] ata: pata_platform: Make use of GENMASK() macro Lad Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73042c85-c194-e1c8-296c-6d9322624d83@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=andy.shevchenko@gmail.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®