From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com [209.85.210.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A45EB31D730 for ; Wed, 25 Mar 2026 22:22:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774477347; cv=none; b=s8poOcTNRRWY4unkOAEAK4y8sJhTUtT9Y2UDtv52FNe6u0KF9Y15WSuccVPZcpx9ULk9t9L7xYnHnF1hM2VnrhB1sWqJMDvcfvl6GfeRZzbaBZXvAmzWShA7wVthpmI3mxuyNm5jXi/PWgt+A40rxUbaSlpOhrVIr7VvW78ISUY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774477347; c=relaxed/simple; bh=oIZxwS7DyaKrQvzESHSMKLgpw8mQelWUJVu14lPeFVE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=T4SkGc1jJaTtfh8BpVkn6XQVfVXLbiG95JiiyULqOESlqo5++D8qzrioLnD+YlFQTwpkzO0oE2f7O+6UpNp8RO/D2WUe2zqG3NEBZ1lzJ3CUQnGUADqjfyMl9GsbD+sftYl5wyOYvwD+WYJd/fviIbYbZ1vKEqaXXcb+bWGvqNM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=SkWwxlmI; arc=none smtp.client-ip=209.85.210.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="SkWwxlmI" Received: by mail-ot1-f49.google.com with SMTP id 46e09a7af769-7d7f92bde91so207097a34.1 for ; Wed, 25 Mar 2026 15:22:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1774477344; x=1775082144; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jMVBUq76We5OmSgDu+kPUK+rLvGUIFxCal3rZvl7YbA=; b=SkWwxlmIsrDyVam2qe7l2bOZOzYD2lRcVQuvlWcuTKOqaFIYH7XDVx1gJr2s2DbJO5 1xsU8uUiblF5YUkoQESlONDoiioDi36xm7fRbG6PP7/jCmBzVMPYYelghHgW1nEDpimn MFPYpU/VsJzxvOmOLh+44s2uDkLnZgjkeMN0Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774477344; x=1775082144; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jMVBUq76We5OmSgDu+kPUK+rLvGUIFxCal3rZvl7YbA=; b=BR2w2DdMg8OcehlWD4WOQyNOIXM3/HsQggWH4VR7CTMgfnfnTHyC8frUMkbaOn9mMh G99cY5kiZZc/xNs9sF5NxNPfmCjJ8C4RzKP2StOZnFs+vL0LCzhBS1riAvgYjdCJwvNU TPIkUf0UpczQgN90jV06T9UbEGNeipVERE3a4X177p7FoJ3WvjlBHoK5hNwip5RMakCx Gs+snLzD9rf3FLgG7tuR3A9nvhcEZfPD0Zf+TIkPXo4Qrwvwfv131HzNKCer/k+Z9NMU BzZaBULARUbkmpic8RRTicPCqz6XIBRO+5vNBoHFIwdri85aa0NMJR52NBP4Yuu+iEYY brmA== X-Forwarded-Encrypted: i=1; AJvYcCX8MU9hHmbs+E4buX49zYNi3zKA/CXF/SYvcNFETx0uHuf+clWAru+gFznfvUczmjIVvF1PlObxnRPjego=@vger.kernel.org X-Gm-Message-State: AOJu0YyQ3DbZRmFSjL+vCV0DtYQVOcPpzASjQ+WwO6piyI7j0lw3Q8oQ AiB4p+ofL15Je0p8Cde4AqZuGj6KuFF7GD923HdWTFu44s4Qh0DdHxCoIuHbDzvDotQ= X-Gm-Gg: ATEYQzwJyh4+pHhoqz73O+BY5O4fIyQWYrMH/ZtLylq8C77Fc0NRBCEiu/eD17BEn9l VE3FMAO6ioGVibl7MB9f2Y9wGtCzp1bQcO7mKy388OEg/pI6BVD+BiteN/68YsMMh/0ZYCgets+ +vNetP8WeY1xOgdvpDe1/VDkGTHR51HPa/DZxOxS4YCvpwDRmeCBK7fZaR2Gs59VQ2L15D9rnt6 MItV5NZdjEOlVtgu8vVpo+HI/ve54kVURtkPatm+B+lTpaLg+dbtNovJyFgq/SUanNEY5r6SROo YlO4fzYeoya9lsZqt5QgWoK5Am22EaUF6T4QeZ8/Z1jfL1LtbLpM2W+XLXgswe38W0givoaaxHW H2Bx183vHOUdNoq0jC9s6XwmriegqtVpdpqsns/dc8RySa302Jjqsh7ftedof/TjfDxv3t+OkIg xa3IWjD8BwuKD4g+OkgQFF9aOrSSZ283Ba3Le8Ltzlj+Sd0g== X-Received: by 2002:a05:6830:6f45:b0:7d7:fcdd:3f8c with SMTP id 46e09a7af769-7d9d6b1ac8amr3142144a34.34.1774477344605; Wed, 25 Mar 2026 15:22:24 -0700 (PDT) Received: from [192.168.1.14] ([38.175.187.108]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d9e680456bsm1004206a34.0.2026.03.25.15.22.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Mar 2026 15:22:24 -0700 (PDT) Message-ID: <730559e1-aea5-492e-8e5d-9a7ed3b38323@linuxfoundation.org> Date: Wed, 25 Mar 2026 16:22:22 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] staging: rtl8723bs: fix constant on left side of test checkpatch warnings To: Dan Carpenter Cc: Prithvi , Andy Shevchenko , gregkh@linuxfoundation.org, abrahamadekunle50@gmail.com, straube.linux@gmail.com, b9788213@gmail.com, ethantidmore06@gmail.com, weibu@redadmin.org, knavaneeth786@gmail.com, ignacio.pena87@gmail.com, dharanitharan725@gmail.com, lukagejak5@gmail.com, samasth.norway.ananda@oracle.com, karanja99erick@gmail.com, s9430939@naver.com, suunj1331@gmail.com, ysinghcin@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev, david.hunter.linux@gmail.com, khalid@kernel.org, Shuah Khan References: <20260323162901.121947-1-activprithvi@gmail.com> <20260324130234.3776tp4ykuerffcg@inspiron> <20260324135551.grth7jfjyoh5krzr@inspiron> <20260324160229.f46h25ebd2mxcfiq@inspiron> <656d3bf5-8d97-454e-9691-540cdb79dab4@linuxfoundation.org> Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/25/26 15:34, Dan Carpenter wrote: > On Wed, Mar 25, 2026 at 11:57:38AM -0600, Shuah Khan wrote: >> My primary concern with this change is that it 10 files changed, with >> 26 insertions(+), 32 deletions(-) >> >> It can be difficult to find any regressions unless the changes are >> tested. I understand it is staging repo, but if we relax the rules >> for staging irrespective of the scope of change, it becomes lot >> harder to find regressions later. We are essentially leaving the >> job of testing to users. Also if ans when the driver is pulled into >> mainline, it will inherit the regressions that crept in. >> > > To me this is a mechanical patch (basically automatic, flip the > if statement) from a newbie. These kinds of patches are seldom a > problem. > > I took a sample of the patches for five years from 2021 to the end of > 2025. We merged 54406 commits in staging. We had 401 Fixes tags. But > then I decided I don't care about Kconfig problems so I cut it down to > 380 bugs. Half of those (189 commits) were from when the driver was > merged. We tend to not review code very much when it is first merged > to staging. The other half (191 commits) were from us missing bugs > during review. 191 bugs over five years is 40 bugs per year. > > I hand reviewed a bunch of the 191 commits. It's mostly senior > developers and maintainers who introduce bugs. They are normally doing > complicated things like adding features or re-working core parts of the > driver. Quite a few of these patches were tested. > > The fallout from newbie patches is pretty rare and often really > minor. A common thing is "We deleted code but we didn't delete > everything." The number of serious mess ups is probably just a > couple times per year out of the 40 total bugs per year. > > I've attached my script so you can check yourself. NEW means the > bug was introduced by a new driver. OLD means, ideally it would > have been caught in review. > I am not the maintainer for this driver, so it is really up to the maintainer(s) to accept mechanical patches such as this one. As for the mentorship, I like to use a consistent rule that testing for regressions is important and that author needs to disclose how the patch is tested or not tested in the version 1 of the patch and add RFT tag. That way maintainers can make an informed decision on whether to accept the patch or not. thanks, -- Shuah