mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Damien Le Moal <dlemoal@kernel.org>
To: Niklas Cassel <cassel@kernel.org>
Cc: shao.mingyin@zte.com.cn, linux-ide@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v4 1/4] ata: libata-scsi: reject reserved bits in 32-byte passthru
Date: Mon, 16 Nov 2026 12:31:51 -0800	[thread overview]
Message-ID: <730904a8-a650-4271-96da-68a9c8e55b88@kernel.org> (raw)
In-Reply-To: <avs8VMjIphKkvc9S@ryzen>

On 11/16/26 09:24, Niklas Cassel wrote:
> Hello Damien,
> 
> On Sun, Nov 15, 2026 at 11:01:10AM +0900, Damien Le Moal wrote:
>> On 11/14/26 02:48, shao.mingyin@zte.com.cn wrote:
>>> From: Shao Mingyin <shao.mingyin@zte.com.cn>
>>>
>>> ATA PASS-THROUGH(32) has no MULTIPLE_COUNT field. Byte 1 is CONTROL,
>>> including vendor-specific bits 7:6, but libata interprets bits 7:5 as
>>> MULTIPLE_COUNT. This rejects non-multiple commands with those bits set
>>> and can print spurious count mismatch warnings for multiple commands.
>>> The reserved bits 7:5 of byte 10 are not checked.
>>>
>>> Reject nonzero reserved bits in byte 10 with field pointer 10. Skip
>>> the MULTIPLE_COUNT checks for the 32-byte form while retaining the
>>> device multiple-mode check for READ/WRITE MULTIPLE commands. Also point
>>> to byte 10 for invalid PROTOCOL. Keep the 12- and 16-byte count checks
>>> unchanged.
>>>
>>> Fixes: b1ffbf854e08 ("libata: Support for an ATA PASS-THROUGH(32) command.")
>>> Suggested-by: Niklas Cassel <cassel@kernel.org>
>>> Signed-off-by: Shao Mingyin <shao.mingyin@zte.com.cn>
>>
>> Reviewed-by: Damien Le Moal <dlemoal@wdc.com>
> > I replaced this with your @kernel.org email.

Arg... -ETOOMUCHJETLAG :)
Thanks.

-- 
Damien Le Moal
Western Digital Research

  reply	other threads:[~2026-11-16 20:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 17:47 [PATCH v4 0/4] ata: libata-scsi: fix ATA PASS-THROUGH(32) handling shao.mingyin
2026-11-13 17:48 ` [PATCH v4 1/4] ata: libata-scsi: reject reserved bits in 32-byte passthru shao.mingyin
2026-11-15  2:01   ` Damien Le Moal
2026-11-16 17:24     ` Niklas Cassel
2026-11-16 20:31       ` Damien Le Moal [this message]
2026-11-13 17:48 ` [PATCH v4 2/4] ata: libata-scsi: reject unsupported ATA-32 service actions shao.mingyin
2026-11-13 17:48 ` [PATCH v4 3/4] ata: libata-scsi: generate SAT sense data for ATA PASS-THROUGH(32) shao.mingyin
2026-11-13 17:48 ` [PATCH v4 4/4] ata: libata-scsi: fix remaining passthru field pointers shao.mingyin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=730904a8-a650-4271-96da-68a9c8e55b88@kernel.org \
    --to=dlemoal@kernel.org \
    --cc=cassel@kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shao.mingyin@zte.com.cn \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®