From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Binbin Zhou <zhoubb.aaron@gmail.com>
Cc: Binbin Zhou <zhoubinbin@loongson.cn>,
Huacai Chen <chenhuacai@kernel.org>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <maz@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jianmin Lv <lvjianmin@loongson.cn>,
Huacai Chen <chenhuacai@loongson.cn>,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
loongarch@lists.linux.dev, devicetree@vger.kernel.org,
loongson-kernel@lists.loongnix.cn
Subject: Re: [PATCH V2 1/2] dt-bindings: interrupt-controller: Add Loongson EIOINTC
Date: Wed, 15 Feb 2023 21:12:18 +0100 [thread overview]
Message-ID: <730f6bf9-ce57-6834-12e0-b60abbfb2e1f@linaro.org> (raw)
In-Reply-To: <23068d0c-d37c-0563-e1c1-e4d112059f5b@linaro.org>
On 14/02/2023 13:43, Krzysztof Kozlowski wrote:
>>
>>>
>>>> +
>>>> + reg:
>>>> + minItems: 1
>>>> + maxItems: 3
>>>
>>> You need to describe the items.>>>
>>>> +
>>>> + interrupt-controller: true
>>>> +
>>>> + interrupts:
>>>> + description:
>>>> + Interrupt source of the CPU interrupts.
>>>
>>> You need to describe the items.
>>
>> Do you mean a more detailed description?
>
> I mean constraints on interrupts and/or description if they are not obvious.
Actually I noticed that for interrupts you provided the name, so it is
description and you just need maxItems:1.
The reg however need list of items which clearly documents what is there.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-02-15 20:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 12:15 [PATCH V2 0/2] Loongson: irqchip: Add loongson-eiointc DT init support Binbin Zhou
2023-02-13 12:15 ` [PATCH V2 1/2] dt-bindings: interrupt-controller: Add Loongson EIOINTC Binbin Zhou
2023-02-14 9:52 ` Krzysztof Kozlowski
2023-02-14 12:40 ` Binbin Zhou
2023-02-14 12:43 ` Krzysztof Kozlowski
2023-02-15 20:12 ` Krzysztof Kozlowski [this message]
2023-02-16 1:46 ` Binbin Zhou
2023-02-16 8:10 ` Krzysztof Kozlowski
2023-02-16 9:30 ` Huacai Chen
2023-02-16 9:34 ` Krzysztof Kozlowski
2023-02-17 6:09 ` Binbin Zhou
2023-02-17 8:40 ` Krzysztof Kozlowski
2023-02-17 10:12 ` Binbin Zhou
2023-02-21 11:18 ` Krzysztof Kozlowski
2023-02-15 19:49 ` Rob Herring
2023-02-13 12:15 ` [PATCH V2 2/2] irqchip/loongson-eiointc: Add DT init support Binbin Zhou
2023-02-13 14:28 ` [PATCH V2 0/2] Loongson: irqchip: Add loongson-eiointc " Huacai Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=730f6bf9-ce57-6834-12e0-b60abbfb2e1f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=devicetree@vger.kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=lvjianmin@loongson.cn \
--cc=maz@kernel.org \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=zhoubb.aaron@gmail.com \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®