From: "Moger, Babu" <babu.moger@amd.com>
To: Reinette Chatre <reinette.chatre@intel.com>,
fenghua.yu@intel.com, bp@alien8.de, james.morse@arm.com,
tony.luck@intel.com, peternewman@google.com, tglx@linutronix.de,
mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org
Cc: hpa@zytor.com, james.greenhalgh@arm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/resctrl: Fix uninitialized memory read when last CPU of domain goes offline
Date: Mon, 1 Apr 2024 14:17:18 -0500 [thread overview]
Message-ID: <73122f30-44b9-4868-958c-99218e5c1185@amd.com> (raw)
In-Reply-To: <ea8ef700-daf2-4408-888f-f5c93db82331@intel.com>
On 4/1/24 13:12, Reinette Chatre wrote:
> Hi Babu,
>
> On 4/1/2024 10:57 AM, Moger, Babu wrote:
>> On 3/28/24 16:12, Reinette Chatre wrote:
>
>>> --- a/arch/x86/kernel/cpu/resctrl/internal.h
>>> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
>>> @@ -85,6 +85,10 @@ cpumask_any_housekeeping(const struct cpumask *mask, int exclude_cpu)
>>> if (cpu < nr_cpu_ids && !tick_nohz_full_cpu(cpu))
>>> return cpu;
>>>
>>> + /* Only continue if tick_nohz_full_mask has been initialized. */
>>> + if (!tick_nohz_full_enabled())
>>> + return cpu;
>>> +
>>
>> I am curious why this below check didn't fail?
>>
>> if (cpu < nr_cpu_ids && !tick_nohz_full_cpu(cpu))
>> return cpu;
>>
>> The tick_nohz_full_cpu() already checks tick_nohz_full_enabled().
>>
>> It should returned 'false' and returned cpu already.
>>
>> Did i miss something?
>>
>
> The scenario occurs when the last CPU of a domain goes offline and the cpu itself
> is the cpu to be excluded. In this scenario cpu >= nr_cpu_ids in the check you
> quote.
>
> You may, as did I, wonder why continue the check on a smaller set of CPUs
> if the first check already failed? James addressed that in:
> https://lore.kernel.org/lkml/bd8a64fa-86d3-4417-a570-36469330508f@arm.com/
>
Got it.
--
Thanks
Babu Moger
prev parent reply other threads:[~2024-04-01 19:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 21:12 Reinette Chatre
2024-03-28 22:51 ` Luck, Tony
2024-03-29 7:01 ` Ingo Molnar
2024-03-29 15:25 ` Reinette Chatre
2024-03-30 11:12 ` Ingo Molnar
2024-04-01 17:57 ` Moger, Babu
2024-04-01 18:12 ` Reinette Chatre
2024-04-01 19:17 ` Moger, Babu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73122f30-44b9-4868-958c-99218e5c1185@amd.com \
--to=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=james.greenhalgh@arm.com \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peternewman@google.com \
--cc=reinette.chatre@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®