From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7546F39FCD8 for ; Tue, 7 Apr 2026 11:29:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775561397; cv=none; b=lpRxHfHmzFW3VH1WwzczeHzWhxyc1pbCTTnvNzBZiekmufw8pBTCtZgEjapf4x8zFgdOipbSu5JqqMMy/yiC5LNGcxFV2Y/TcgtOzWLL6XdVW5YZn6zDyEaJJX9LcAZFwXsTp0o/BIrOJ2Y4yR65kZF98/hl2exu6eqe7QdVy94= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775561397; c=relaxed/simple; bh=r12oPXmQbt+wakmkFLl5TlvZwD43YhlBp2O2/AMD3q0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WBwZxhJGi/GZ2zai9ASH4t/6RZnvbJvd/XVx3FgXO3khxBoKiHgpqPYA5q7Kx5/qk42QCoJcxNaP7iQ4Gkjha2Q/q3FbFXEGSy91OUDA173aWuJvGafxn6WirSfA4tBZPOIPRIdlRG7AJfEMI5rlJyhgHKJm0NecVv0rQXwOwiY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DAzk4miI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Hy9gRrPj; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DAzk4miI"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Hy9gRrPj" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63765jou2328000 for ; Tue, 7 Apr 2026 11:29:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= RT/YMykjz7y8qLINEn2TgQMrKn6NhuK5gzEeRKqvkL0=; b=DAzk4miI6YyESJLv vG/jqUE0QvZ1K2bIW1DuxpNejt9SWRH3yM8LrqLrNeNRO3Hyl50mpjgO8DyNiCZe 82Yt2cHDod3LyovwLPJbzVHGSDLXcoeAx3gHhiohUTBlZJaCNi6IlSfs+nNEHRS8 a5ls4W1ydLCj6EB1gOF0jhW5GSASYaf78Hy27vH4QSlZOsAzOMxd37M/WszN695R X3Jof/L+lnZ3ZJhaBVbdPwizr/ihQWie8mRbFsreL/RCNf5jd8I6M1DTRPVC1/yx j4haDunQOf2HDANUEKkiAPixTHViR4nsvjsokkcN8IevdNo4VdiNqqEsZHy4cSeo DIvBvA== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dcms4tfgs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Apr 2026 11:29:55 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-8a016b99579so21852396d6.0 for ; Tue, 07 Apr 2026 04:29:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775561395; x=1776166195; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RT/YMykjz7y8qLINEn2TgQMrKn6NhuK5gzEeRKqvkL0=; b=Hy9gRrPjU4B4aGEkz+KkDQQwUE0xEnp2BUkmQEGMGl77AFDnqGH17gKjIAHCUL0W6V opEgyBojjgXrjZdreE6E/ETha1tXycx6feecTZPIN23K7CXzDGx6PcfnhtbqdlFUjKgh 8bE8tHu4oFhYtUsNk3E35rqGsTjT9QhRbCEqXyfTIxU5eCycM8K6jb66Ar9OwssVqXBF kJU+9g93zozTQPqTcjsBrKHrcVpteFR8PRal/Tjn7eaBc55MmP/2RxS6XNMQU/Ou/DRn ahtRrb3CLw4Etm+tmjkQHhzn3JU9giIeORPLyk5B3qjFUoXQKNZdC+mvCutbHpwIIMUS KAQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775561395; x=1776166195; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RT/YMykjz7y8qLINEn2TgQMrKn6NhuK5gzEeRKqvkL0=; b=R/1lknVpTFYdzmtjQSV/0gzWEd/UBnWWeeSJzSsowaz89ZTh5kn1fxvGZgAO8uMXQV cXKwGbjcfrnv4EO37FpTaRwoLDJiSKm7bbgQlD/5Iy3pIsK2nOz5iEztWmmOkYlwOHRj t0lz6DZ2ScOMcwgQ0qNyNDy7ZGfIr8qrtc3GIETqqcwMz7EeFj5TKAZzJqq9XR4g8kVz v30ovM3W2lmwxa5dzix/zkwr/bUDFUdiY9TY+pewxr85i4hrIeL/XYpOpKAgEll8csRa Rc8YXNSJURbFtzvxbpgQU+Pe80MUEjdHiTlhLk5BpiHY9+/Yj5FJ6k+BXEsp+iWsjuzW Hg5Q== X-Forwarded-Encrypted: i=1; AJvYcCUBarfmOGQM9XACUStiHNdJY2I11SIcWQ2pL7sQw7WZkVDFn4unlSrjjGVArxfbMEJHCxZnh3UrqTriv9Q=@vger.kernel.org X-Gm-Message-State: AOJu0Ywkad8mnmbZraT76+OBdYb8UnK1P7dHK4qRfv1FoFOgLGETTQFT 4YB+LGGRBSbcPakTKMZqQI0e66qFjTpClAy8tmQO6G0/89+Ayn3DjJtl3ui+/P7Q9vwfkeRm1k/ qbzle1tKdmRrqYQvmSdGmxWiMwbhJsMMmancFSy7y/Brl8Bofsra4gbSuXubDBm1lVdo= X-Gm-Gg: AeBDies032Fd4ItaCxpgNd7QxmDgljSP8QLS7RXgFL7nlzNzwM1hwCz+m4gHXvbuNZg q//A39DrSkbUmLPGLbU/1QUcc5lLc2wmBU7V5KoQvQ7fmg1OiqTohN0kOHFIj7oI0dbvS81Nt+C V/DaupNHvmqeGY5VSnuubSCckZXtj6jgplvPWS8vLo1+QTRo7kiAUlT7mrqIHddiCS8MI9+2OiA 2pUwLlvvqlatpCUEsoxT6MDyIzuDvpV0FsGaBl+57jTmaOHJ479u+6idxrcpEzqfF5YXcbD0Onz DHy5IYy3plmM9TwFMSNfoaSlLf2sw+7lIet8OkqEJ1ygaIIWOvxRfiDSZA4ftClTpIrObD9LuMN d0W7BTlrp+DfeE2U/uxNUBb6GJfj1yPoforc6gMYITwOu5dc8p8B4AthrxffR+XaHxCdq2oX/9Y 507Ns= X-Received: by 2002:a05:6214:4113:b0:89c:5285:200e with SMTP id 6a1803df08f44-8a7046ddb0emr200475596d6.4.1775561394702; Tue, 07 Apr 2026 04:29:54 -0700 (PDT) X-Received: by 2002:a05:6214:4113:b0:89c:5285:200e with SMTP id 6a1803df08f44-8a7046ddb0emr200475226d6.4.1775561394274; Tue, 07 Apr 2026 04:29:54 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9c3c99ec7csm541081366b.14.2026.04.07.04.29.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Apr 2026 04:29:53 -0700 (PDT) Message-ID: <73196147-0133-4646-927d-dbe93c254286@oss.qualcomm.com> Date: Tue, 7 Apr 2026 13:29:50 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/6] clk: qcom: gxclkctl: Remove GX/GMxC rail votes to align with IFPC To: Taniya Das , Bjorn Andersson , Michael Turquette , Stephen Boyd , Abel Vesa , Rob Clark , Sean Paul , Konrad Dybcio , Akhil P Oommen , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter Cc: Ajit Pandey , Imran Shaik , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org References: <20260407-gfx-clk-fixes-v1-0-4bb5583a5054@oss.qualcomm.com> <20260407-gfx-clk-fixes-v1-4-4bb5583a5054@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260407-gfx-clk-fixes-v1-4-4bb5583a5054@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA3MDEwNyBTYWx0ZWRfX+cJlQdeSknJA 2CGfXxr0TXI1J0Uu340bMyfcdrvHkKERgCf/EpHdplrWYjRyijHNYXjx1dZoSOSmcUHGDzgg2B/ Rv2ZB9BlWDGOs0aCTbf8vQD5mUab7cAebYu/pT6ri06M5ZDO2LAWIohuiMBpnjWnSnG9lXAv1Xa LFMPAuffkq0Q4DlmZJO9kcPgn6XgmxOAMYAdCVSyI4cXny/m4Nuxvc1lClgeoEmxggreBcx3gEl 9/HIEAJ4N4j/E8sg9vI+nIYEJMvJYlMQkOjjIYidk9mVS632lEPSwqM2clAoZauZpFh/CZoZ1AX J94qaDljSdz0RfbKhdlO8HSWBVQ818cP2LbSZAWU4uyw/G9ss5li07TpHSJJfnFIcTJaNcqsWDW ZYONqoOu+bG8YObSpB0z/P4wM4eALH+8KsHl0Q7m0bgoDBrIfTxd6V2tiy9Pa9TRdIpjTYptRfj PmwQvheo34SViYUyyVw== X-Proofpoint-ORIG-GUID: buTfuD98GgRZv-SpVfWBqyFsrpVwezCA X-Authority-Analysis: v=2.4 cv=WNZPmHsR c=1 sm=1 tr=0 ts=69d4eab3 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=ObXhwGULgzmC2I4GqhAA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-GUID: buTfuD98GgRZv-SpVfWBqyFsrpVwezCA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-07_02,2026-04-07_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 phishscore=0 spamscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604070107 On 4/7/26 11:30 AM, Taniya Das wrote: > The GX GDSC control is handled through a dedicated clock controller, > and the enable/disable sequencing depends on correct rail voting. > The driver votes for the GX/GMxC rails and CX GDSC before toggling > the GX GDSC. Currently, during GMU runtime PM resume, rails remain > enabled due to upstream votes propagated via RPM-enabled devlinks > and explicit pm_runtime votes on GX GDSC. > > This is not an expected behaviour of IFPC(Inter Frame Power Collapse) > requirements of GPU as GMU firmware is expected to control these rails, > except during the GPU/GMU recovery via the OS and that is where the GX > GDSC should be voting for the rails (GX/GMxC and CX GDSC) before > toggling the GX GDSC. > > Thus, disable runtime PM after successfully registering the clock > controller. > > Signed-off-by: Taniya Das > --- > drivers/clk/qcom/gxclkctl-kaanapali.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/qcom/gxclkctl-kaanapali.c b/drivers/clk/qcom/gxclkctl-kaanapali.c > index d7cf6834dd77c2a5320ffb8548cdb515be237bdc..d470ade11b0d11eb40843fe84c809e71646dce27 100644 > --- a/drivers/clk/qcom/gxclkctl-kaanapali.c > +++ b/drivers/clk/qcom/gxclkctl-kaanapali.c > @@ -7,6 +7,7 @@ > #include > #include > #include > +#include > #include > > #include > @@ -61,7 +62,15 @@ MODULE_DEVICE_TABLE(of, gx_clkctl_kaanapali_match_table); > > static int gx_clkctl_kaanapali_probe(struct platform_device *pdev) > { > - return qcom_cc_probe(pdev, &gx_clkctl_kaanapali_desc); > + int ret; > + > + ret = qcom_cc_probe(pdev, &gx_clkctl_kaanapali_desc); > + if (ret) > + return ret; > + > + pm_runtime_disable(&pdev->dev); My understanding is that this works because we have more than one domain associated with the nod (so the generic code that would otherwise enable a single one so long as the device is resumed doesn't apply) and your previous patch ensures that after probe, the clock controller is being put to sleep, right before pm_runtime_disable() executes. Is that right? Konrad