From: Laurent Dufour <ldufour@linux.vnet.ibm.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: Fix mem_cgroup_oom_disable() call missing
Date: Tue, 5 Sep 2017 17:54:29 +0200 [thread overview]
Message-ID: <73199b41-da7d-2bd5-6214-da55ab62cea9@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170905154650.c3xiwp52btcckjr4@node.shutemov.name>
On 05/09/2017 17:46, Kirill A. Shutemov wrote:
> On Tue, Sep 05, 2017 at 05:30:39PM +0200, Laurent Dufour wrote:
>> Seen while reading the code, in handle_mm_fault(), in the case
>> arch_vma_access_permitted() is failing the call to mem_cgroup_oom_disable()
>> is not made.
>>
>> To fix that, move the call to mem_cgroup_oom_enable() after calling
>> arch_vma_access_permitted() as it should not have entered the memcg OOM.
>>
>> Fixes: bae473a423f6 ("mm: introduce fault_env")
>> Signed-off-by: Laurent Dufour <ldufour@linux.vnet.ibm.com>
>
> Ouch. Sorry for this.
>
> Acked-by: Kirill A. Shutemov <kirill@shutemov.name>
>
> Cc: stable@ is needed too.
Andrew, should I resent it with stable in copy ?
>
> It's strange we haven't seen reports of warning from
> mem_cgroup_oom_enable().
AFAIU, arch_vma_access_permitted() is only defined for x86 and it is
failing only in the case of the protection key mismatch, not so much used
for now...
Cheers,
Laurent.
next prev parent reply other threads:[~2017-09-05 15:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 15:30 Laurent Dufour
2017-09-05 15:46 ` Kirill A. Shutemov
2017-09-05 15:54 ` Laurent Dufour [this message]
2017-09-05 16:43 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73199b41-da7d-2bd5-6214-da55ab62cea9@linux.vnet.ibm.com \
--to=ldufour@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®