From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 763BDC4649B for ; Fri, 5 Jul 2019 12:18:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3E54220645 for ; Fri, 5 Jul 2019 12:18:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="b3pmEoSQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728230AbfGEMST (ORCPT ); Fri, 5 Jul 2019 08:18:19 -0400 Received: from mail-eopbgr80052.outbound.protection.outlook.com ([40.107.8.52]:13408 "EHLO EUR04-VI1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725601AbfGEMST (ORCPT ); Fri, 5 Jul 2019 08:18:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZYIG5xg6SgOR+uedWHE+D2fpxO0fHVKretsP+pHBSM8=; b=b3pmEoSQSOASq5QDFbEsTr6I2ZqrjyEUZjPyKlnp4rBWq2d03fbErlZFqp+ql6AIUQb6wblbZZHu3vprhTScgHbUyfMTMo+hLBtMuQQI0dU4SF5YJQb4YDB9cwwQpync2he0BgzzszUINlSzBrmO0NWbTwv0TGnDz+fEI5DttFs= Received: from DB6PR05CA0011.eurprd05.prod.outlook.com (2603:10a6:6:14::24) by VI1PR0502MB3981.eurprd05.prod.outlook.com (2603:10a6:803:24::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2032.20; Fri, 5 Jul 2019 12:18:15 +0000 Received: from VE1EUR03FT017.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e09::206) by DB6PR05CA0011.outlook.office365.com (2603:10a6:6:14::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2052.18 via Frontend Transport; Fri, 5 Jul 2019 12:18:15 +0000 Authentication-Results: spf=pass (sender IP is 193.47.165.134) smtp.mailfrom=mellanox.com; raithlin.com; dkim=none (message not signed) header.d=none;raithlin.com; dmarc=pass action=none header.from=mellanox.com; Received-SPF: Pass (protection.outlook.com: domain of mellanox.com designates 193.47.165.134 as permitted sender) receiver=protection.outlook.com; client-ip=193.47.165.134; helo=mtlcas13.mtl.com; Received: from mtlcas13.mtl.com (193.47.165.134) by VE1EUR03FT017.mail.protection.outlook.com (10.152.18.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2052.18 via Frontend Transport; Fri, 5 Jul 2019 12:18:14 +0000 Received: from MTLCAS13.mtl.com (10.0.8.78) by mtlcas13.mtl.com (10.0.8.78) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Fri, 5 Jul 2019 15:18:12 +0300 Received: from MTLCAS01.mtl.com (10.0.8.71) by MTLCAS13.mtl.com (10.0.8.78) with Microsoft SMTP Server (TLS) id 15.0.1178.4 via Frontend Transport; Fri, 5 Jul 2019 15:18:11 +0300 Received: from [172.16.0.102] (172.16.0.102) by MTLCAS01.mtl.com (10.0.8.71) with Microsoft SMTP Server (TLS) id 14.3.301.0; Fri, 5 Jul 2019 15:17:57 +0300 Subject: Re: [PATCH v2 1/2] nvmet: Fix use-after-free bug when a port is removed To: Logan Gunthorpe , , , Christoph Hellwig , "Sagi Grimberg" CC: Stephen Bates References: <20190703230304.22905-1-logang@deltatee.com> <20190703230304.22905-2-logang@deltatee.com> <786259e6-ffed-8db3-74d0-71ed5a760079@mellanox.com> From: Max Gurtovoy Message-ID: <731bd412-2e44-c027-726e-d73a42c5f773@mellanox.com> Date: Fri, 5 Jul 2019 15:17:56 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [172.16.0.102] X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:193.47.165.134;IPV:NLI;CTRY:IL;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(39860400002)(136003)(396003)(346002)(376002)(2980300002)(199004)(189003)(110136005)(16576012)(58126008)(106002)(2201001)(6116002)(3846002)(86362001)(305945005)(6246003)(4326008)(229853002)(8936002)(67846002)(26005)(186003)(77096007)(64126003)(50466002)(36756003)(16526019)(2486003)(316002)(23676004)(76176011)(478600001)(53546011)(2906002)(81156014)(476003)(31696002)(65956001)(446003)(47776003)(8676002)(126002)(65806001)(11346002)(486006)(2616005)(230700001)(31686004)(70586007)(356004)(4744005)(65826007)(336012)(7736002)(5660300002)(70206006)(81166006)(3940600001)(2101003);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0502MB3981;H:mtlcas13.mtl.com;FPR:;SPF:Pass;LANG:en;PTR:mail13.mellanox.com;A:1;MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e4246992-29b2-4e90-f92a-08d70142dae2 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(4709080)(1401327)(2017052603328)(7193020);SRVR:VI1PR0502MB3981; X-MS-TrafficTypeDiagnostic: VI1PR0502MB3981: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4125; X-Forefront-PRVS: 008960E8EC X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: XTtgnlS6dxAHSQ7wQmeZJmQfG4ifcr9AVLrPEyTDsqhHiWcW+fAXJkTaSRaPTRib18H02KRX17gazEsFB+UXOh4z2IFMmlTdaHA2oN7sPShgbNndFZpaNkbzhFnfxWN9VFsgn9Qs5xkvHuor668P3/tkeyjy3czDzwbrpwgcC1Qe90TpJQ9C+6yLby+CVSb3TIuZmtllb7SrdzQ7FTcUeN4nJ94jpfwuXCDQf8hWPgHVQDG+0S0jvhUj0uB7iHJeoDHNxJLzxel+0Hcomb0F+NFiBu4F8px+3b+OFwAcAozlFiZSyk3cMcGBHvPBSlSvQk7Q66NR1IsqZIWO4TeCw4GsEyyFnNxs0guHvByz6eEmmqCGed5AqtI8eE2PLdxILiS0pml05tQTlcm78RiIdGYoa33izx4W2CXw6mSJGZE= X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2019 12:18:14.3598 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e4246992-29b2-4e90-f92a-08d70142dae2 X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a652971c-7d2e-4d9b-a6a4-d149256f461b;Ip=[193.47.165.134];Helo=[mtlcas13.mtl.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0502MB3981 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/5/2019 12:01 AM, Logan Gunthorpe wrote: > > On 2019-07-04 3:00 p.m., Max Gurtovoy wrote: >> Hi Logan, >> >> On 7/4/2019 2:03 AM, Logan Gunthorpe wrote: >>> When a port is removed through configfs, any connected controllers >>> are still active and can still send commands. This causes a >>> use-after-free bug which is detected by KASAN for any admin command >>> that dereferences req->port (like in nvmet_execute_identify_ctrl). >>> >>> To fix this, disconnect all active controllers when a subsystem is >>> removed from a port. This ensures there are no active controllers >>> when the port is eventually removed. >> so now we are enforcing controller existence with port configfs, right ? >> sounds reasonable. > Correct. > >> Did you run your patches with other transport (RDMA/TCP/FC) ? > Just RDMA and loop. I suppose I could test with TCP but I don't have FC > hardware. Great. the code looks good: Reviewed-by: Max Gurtovoy > > Logan