From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DE07C04A94 for ; Thu, 3 Aug 2023 02:44:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233242AbjHCCo6 (ORCPT ); Wed, 2 Aug 2023 22:44:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230210AbjHCCoz (ORCPT ); Wed, 2 Aug 2023 22:44:55 -0400 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03B579B; Wed, 2 Aug 2023 19:44:53 -0700 (PDT) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 4B9F624E22C; Thu, 3 Aug 2023 10:44:51 +0800 (CST) Received: from EXMBX073.cuchost.com (172.16.6.83) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 3 Aug 2023 10:44:51 +0800 Received: from [192.168.1.218] (180.164.60.184) by EXMBX073.cuchost.com (172.16.6.83) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 3 Aug 2023 10:44:50 +0800 Message-ID: <73222603-445e-fdb0-e831-219bac1d5865@starfivetech.com> Date: Thu, 3 Aug 2023 10:44:50 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v7 6/6] media: starfive: camss: Add VIN driver Content-Language: en-US To: Laurent Pinchart CC: Mauro Carvalho Chehab , Robert Foss , Todor Tomov , , Rob Herring , "Krzysztof Kozlowski" , Conor Dooley , Philipp Zabel , Hans Verkuil , Eugen Hristev , Ezequiel Garcia , , , , References: <20230619112838.19797-1-jack.zhu@starfivetech.com> <20230619112838.19797-7-jack.zhu@starfivetech.com> <20230727204911.GA7136@pendragon.ideasonboard.com> <696e3fd0-7c89-812b-5cda-c5c46b594bf7@starfivetech.com> <20230802103809.GB5269@pendragon.ideasonboard.com> From: Jack Zhu In-Reply-To: <20230802103809.GB5269@pendragon.ideasonboard.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [180.164.60.184] X-ClientProxiedBy: EXCAS064.cuchost.com (172.16.6.24) To EXMBX073.cuchost.com (172.16.6.83) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Laurent, On 2023/8/2 18:38, Laurent Pinchart wrote: > Hi Jack, > > On Wed, Aug 02, 2023 at 05:58:26PM +0800, Jack Zhu wrote: >> On 2023/7/28 4:49, Laurent Pinchart wrote: >> > On Mon, Jun 19, 2023 at 07:28:38PM +0800, Jack Zhu wrote: >> >> Add Video In Controller driver for StarFive Camera Subsystem. >> > >> > I haven't reviewed this patch in details, as I have a high-level >> > question: why do you need VIN subdevs ? They don't seem to represent any >> > particular piece of hardware, their input and output formats are always >> > identical, and they're not used to configure registers. The contents of >> > this patch seems to belong to the video device, I think you can drop the >> > VIN subdevs. >> >> The VIN module corresponds to a hardware module, which is mainly responsible >> for data routing and partial interrupt management (when the image data does >> not pass through the isp but directly goes to the ddr), the relevant registers >> need to be configured. > > That's fine, but I don't think you need a subdev for it. As far as I > understand, the VIn modules are (more or less) DMA engines. You can just > model them as video devices, connected directly to the CSI-2 RX and ISP > source pads. > The VIN hardware can also route input data, it can decide whether DVP sensor or MIPI sensor is used as input data. > Does the "vin0_wr" have the ability to capture raw data from the DVP > interface as well, or only from the CSI-2 RX ? > Yes, the "vin0_wr" has the ability to capture raw data from the DVP interface. >> >> Signed-off-by: Jack Zhu >> >> --- >> >> .../media/platform/starfive/camss/Makefile | 4 +- >> >> .../media/platform/starfive/camss/stf_camss.c | 42 +- >> >> .../media/platform/starfive/camss/stf_camss.h | 2 + >> >> .../media/platform/starfive/camss/stf_vin.c | 1069 +++++++++++++++++ >> >> .../media/platform/starfive/camss/stf_vin.h | 173 +++ >> >> .../platform/starfive/camss/stf_vin_hw_ops.c | 192 +++ >> >> 6 files changed, 1478 insertions(+), 4 deletions(-) >> >> create mode 100644 drivers/media/platform/starfive/camss/stf_vin.c >> >> create mode 100644 drivers/media/platform/starfive/camss/stf_vin.h >> >> create mode 100644 drivers/media/platform/starfive/camss/stf_vin_hw_ops.c >> >> >> >> diff --git a/drivers/media/platform/starfive/camss/Makefile b/drivers/media/platform/starfive/camss/Makefile >> >> index cdf57e8c9546..ef574e01ca47 100644 >> >> --- a/drivers/media/platform/starfive/camss/Makefile >> >> +++ b/drivers/media/platform/starfive/camss/Makefile >> >> @@ -7,6 +7,8 @@ starfive-camss-objs += \ >> >> stf_camss.o \ >> >> stf_isp.o \ >> >> stf_isp_hw_ops.o \ >> >> - stf_video.o >> >> + stf_video.o \ >> >> + stf_vin.o \ >> >> + stf_vin_hw_ops.o >> >> >> >> obj-$(CONFIG_VIDEO_STARFIVE_CAMSS) += starfive-camss.o >> >> diff --git a/drivers/media/platform/starfive/camss/stf_camss.c b/drivers/media/platform/starfive/camss/stf_camss.c >> >> index 6f56b45f57db..834ea63eb833 100644 >> >> --- a/drivers/media/platform/starfive/camss/stf_camss.c >> >> +++ b/drivers/media/platform/starfive/camss/stf_camss.c >> >> @@ -131,27 +131,61 @@ static int stfcamss_init_subdevices(struct stfcamss *stfcamss) >> >> return ret; >> >> } >> >> Regards, Jack Zhu