From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753117AbdHROL3 (ORCPT ); Fri, 18 Aug 2017 10:11:29 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:21956 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751614AbdHROL1 (ORCPT ); Fri, 18 Aug 2017 10:11:27 -0400 Subject: Re: [PATCH] MIPS: dts: ralink: Add Mediatek MT7628A SoC To: Rob Herring CC: Mark Rutland , Matthias Brugger , Ralf Baechle , John Crispin , Linux-MIPS , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , References: <1502814530-40604-1-git-send-email-harvey.hunt@imgtec.com> <20170817213426.34shgxwnjowcg4sk@rob-hp-laptop> <97c83648-3710-cb9a-a065-9fbe8dd1b734@imgtec.com> From: Harvey Hunt Message-ID: <73251933-33bf-416d-cf2a-0fad0337a512@imgtec.com> Date: Fri, 18 Aug 2017 15:11:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.107] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, On 18/08/17 15:04, Rob Herring wrote: > On Fri, Aug 18, 2017 at 4:42 AM, Harvey Hunt wrote: >> Hi Rob, >> >> Thanks for the review. >> >> >> On 17/08/17 22:34, Rob Herring wrote: >>> >>> On Tue, Aug 15, 2017 at 05:28:50PM +0100, Harvey Hunt wrote: >>>> >>>> The MT7628A is the successor to the MT7620 and pin compatible with the >>>> MT7688A, although the latter supports only a 1T1R antenna rather than >>>> a 2T2R antenna. > > [...] > >>>> + uartlite@c00 { >>> >>> >>> serial@c00 >>> >>> And so on. IOW, use standard, generic node names as defined in the DT >>> spec. >> >> >> >> The clocks for the UARTs are using the device names "uartlite", "uart1" and >> "uart2" (as defined in arch/mips/ralink/mt7620.c). > > You can't add clocks to the DT? Looks like mt76x8 at least should be > pretty easy with some fixed clocks. > > Depending if backwards compatibility (old dtb working on new kernel) > is a concern on these platforms, you could just change all the names > both in the kernel and dts. I don't think backwards compatibility will matter - the bootloaders I've come across don't ship DTBs with them and I don't think there are any ralink devices using the upstream MT7620 DT. John might have some thoughts on backwards compat though. > >> Changing the name of the DT nodes causes the serial driver to bail as it >> can't find the clock for the device. >> >> arch/mips/boot/dts/ralink/mt7620a.dtsi is already using the uartlite name, >> although it hasn't been documented... > > Generally the kernel shouldn't care what the names are (though you can > match by name, it's not widely used). > > In any case, I guess fixing this can be done later. > > Rob > Shall I respin this patch with the earlier nodes (intc etc) renamed and then send a patch later to rename the serial ports in the DT and kernel (assuming there are no backwards compatibility issues)? Thanks, Harvey