From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39FDFC433EF for ; Wed, 13 Jul 2022 00:22:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230131AbiGMAWk (ORCPT ); Tue, 12 Jul 2022 20:22:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229482AbiGMAWi (ORCPT ); Tue, 12 Jul 2022 20:22:38 -0400 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44726951E5; Tue, 12 Jul 2022 17:22:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657671757; x=1689207757; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=effvbrNy0O1vUmq93yrxqu28Ft9tve9MZHdOlTQGrKw=; b=KJtYZZdjc3WjMtWiuVJoYlh9lpdEUuK3lxW2RM9VwzbLgF4QtkaOKgGA IC6n5Dk53WgRMwNpBFemB9DonsTg3BxpE55UXjRClZ5vVmCGpSyMV3NrI RNTgLT4nK1Y+W8znOP5oTPrFHJHhuWkBgOMlvObmA41fIdbB8+uGQNH58 SQyFVZLLHEjBAqks4BmGfdfwXx256KA21jxknHOvm39FxZ1+yjKXmiVbV oVQmcXT86ScMbXuYePRvmMdU/2o5nxZKgaH+ELguP0OwoJlyZhyFt1yut orTZXAcuZ25ZYN8Lsxt2cgQkySyYGdIMKQ9Oqa12kzJkRE9we5Hu4teG2 w==; X-IronPort-AV: E=McAfee;i="6400,9594,10406"; a="268110188" X-IronPort-AV: E=Sophos;i="5.92,266,1650956400"; d="scan'208";a="268110188" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jul 2022 17:22:35 -0700 X-IronPort-AV: E=Sophos;i="5.92,266,1650956400"; d="scan'208";a="622712651" Received: from hli101-mobl1.ccr.corp.intel.com (HELO [10.255.31.119]) ([10.255.31.119]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jul 2022 17:22:32 -0700 Message-ID: <732553c4-8c2a-bd3f-cd2a-3e03fb364b5f@intel.com> Date: Wed, 13 Jul 2022 08:22:30 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.11.0 Subject: Re: [PATCH v7 030/102] KVM: TDX: Do TDX specific vcpu initialization Content-Language: en-US To: Isaku Yamahata , Yuan Yao Cc: isaku.yamahata@intel.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , Sean Christopherson References: <20220708021443.v4frmpcqgbk23hkp@yy-desk-7060> <20220712203542.GN1379820@ls.amr.corp.intel.com> From: Xiaoyao Li In-Reply-To: <20220712203542.GN1379820@ls.amr.corp.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/13/2022 4:35 AM, Isaku Yamahata wrote: > On Fri, Jul 08, 2022 at 10:14:43AM +0800, > Yuan Yao wrote: > ... >>> +int tdx_vcpu_ioctl(struct kvm_vcpu *vcpu, void __user *argp) >>> +{ >>> + struct kvm_tdx *kvm_tdx = to_kvm_tdx(vcpu->kvm); >>> + struct vcpu_tdx *tdx = to_tdx(vcpu); >>> + struct kvm_tdx_cmd cmd; >>> + u64 err; >>> + >>> + if (tdx->initialized) >> >> Minor: How about "tdx_vcpu->initialized" ? there's >> "is_td_initialized()" below, the "tdx" here may lead guys to treat it >> as whole td vm until they confirmed it's type again. > > I think you man tdx->vcpu_initialized. If so, makes sense. I'll rename it. IMO, no need to do so. All around tdx.c, "tdx" is the brief pointer name, just like "vmx" used in vmx.c. People will get used to it.