mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Quentin Monnet <qmo@kernel.org>
To: "Holger Hoffstätte" <holger@applied-asynchrony.com>,
	"Alexei Starovoitov" <ast@kernel.org>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	"Andrii Nakryiko" <andrii@kernel.org>,
	"Martin KaFai Lau" <martin.lau@linux.dev>,
	"Eduard Zingerman" <eddyz87@gmail.com>,
	"Song Liu" <song@kernel.org>,
	"Yonghong Song" <yonghong.song@linux.dev>,
	"John Fastabend" <john.fastabend@gmail.com>,
	"KP Singh" <kpsingh@kernel.org>,
	"Stanislav Fomichev" <sdf@fomichev.me>,
	"Hao Luo" <haoluo@google.com>, "Jiri Olsa" <jolsa@kernel.org>,
	bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bpftool: build bpf bits with -std=gnu11
Date: Fri, 2 May 2025 10:26:12 +0100	[thread overview]
Message-ID: <7326223e-0cb9-4d22-872f-cbf1ff42227d@kernel.org> (raw)
In-Reply-To: <20250502085710.3980-1-holger@applied-asynchrony.com>

On 02/05/2025 09:57, Holger Hoffstätte wrote:
> A gcc-15-based bpf toolchain defaults to C23 and fails to compile various
> kernel headers due to their use of a custom 'bool' type.
> Explicitly using -std=gnu11 works with both clang and bpf-toolchain.
> 
> Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com>

Thanks! I tested that it still works with clang.

Acked-by: Quentin Monnet <qmo@kernel.org>

I didn't manage to compile with gcc, though. I tried with gcc 15.1.1 but
option '--target=bpf' is apparently unrecognised by the gcc version on
my setup.

Out of curiosity, how did you build using gcc for the skeleton? Was it
enough to run "CLANG=gcc make"? Does it pass the clang-bpf-co-re build
probe successfully?

Thanks,
Quentin

  reply	other threads:[~2025-05-02  9:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-02  8:57 Holger Hoffstätte
2025-05-02  9:26 ` Quentin Monnet [this message]
2025-05-02  9:53   ` Holger Hoffstätte
2025-05-03  2:36     ` Alexei Starovoitov
2025-05-04 10:24       ` Holger Hoffstätte
2025-05-06 21:04         ` Andrii Nakryiko
2025-05-06 21:41           ` Ihor Solodrai
2025-05-06 22:23             ` Andrii Nakryiko
2025-05-06 22:34               ` Ihor Solodrai
2025-05-06 23:34                 ` Andrii Nakryiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7326223e-0cb9-4d22-872f-cbf1ff42227d@kernel.org \
    --to=qmo@kernel.org \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=haoluo@google.com \
    --cc=holger@applied-asynchrony.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=sdf@fomichev.me \
    --cc=song@kernel.org \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome