mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Justin Chen <justin.chen@broadcom.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-serial@vger.kernel.org, "Al Cooper" <alcooperx@gmail.com>,
	"Broadcom internal kernel review list"
	<bcm-kernel-feedback-list@broadcom.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Jiri Slaby" <jirislaby@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"John Ogness" <john.ogness@linutronix.de>,
	"Jiaqing Zhao" <jiaqing.zhao@linux.intel.com>,
	"open list:TTY LAYER" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] serial: 8250_bcm7271: improve bcm7271 8250 port
Date: Fri, 18 Aug 2023 12:22:25 -0700	[thread overview]
Message-ID: <7332fd46-0310-8fdd-81a6-4ac722a6eda4@broadcom.com> (raw)
In-Reply-To: <ZN9PHgS3Ds/Su8Tu@smile.fi.intel.com>

[-- Attachment #1: Type: text/plain, Size: 900 bytes --]



On 8/18/23 3:59 AM, Andy Shevchenko wrote:
> On Thu, Aug 17, 2023 at 02:13:18PM -0700, Justin Chen wrote:
>> The 8250 BCM7271 UART is not a direct match to PORT_16550A and other
>> generic ports do not match its hardware capabilities. PORT_ALTR matches
>> the rx trigger levels, but its vendor configurations are not compatible.
>> Unfortunately this means we need to create another port to fully capture
>> the hardware capabilities of the BCM7271 UART.
>>
>> To alleviate some latency pressures, we default the rx trigger level to 8.
> 
> ...
> 
>> +		.flags		= UART_CAP_FIFO | UART_CAP_AFE
> 
> Leave trailing comma
> 

Acked

> ...
> 
>> +/* Broadcom BCM7271 UART */
>> +#define PORT_BCM7271    76
> 
> 13 is free why not using it?
> 

I was looking for a number close to another Broadcom port. I was 
prioritizing locality. But I have no issues with 13, I will change in v3.

Thanks,
Justin



[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4206 bytes --]

  reply	other threads:[~2023-08-18 19:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-17 21:13 Justin Chen
2023-08-18 10:59 ` Andy Shevchenko
2023-08-18 19:22   ` Justin Chen [this message]
2023-08-21  8:45     ` Andy Shevchenko
2023-08-18 19:37 ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7332fd46-0310-8fdd-81a6-4ac722a6eda4@broadcom.com \
    --to=justin.chen@broadcom.com \
    --cc=alcooperx@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=f.fainelli@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jiaqing.zhao@linux.intel.com \
    --cc=jirislaby@kernel.org \
    --cc=john.ogness@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®