From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751587AbdF1TxP (ORCPT ); Wed, 28 Jun 2017 15:53:15 -0400 Received: from mail-bl2nam02on0059.outbound.protection.outlook.com ([104.47.38.59]:33120 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751501AbdF1TxM (ORCPT ); Wed, 28 Jun 2017 15:53:12 -0400 Authentication-Results: davemloft.net; dkim=none (message not signed) header.d=none;davemloft.net; dmarc=none action=none header.from=amd.com; Subject: Re: [PATCH v2 2/3] crypto: ccp - Introduce the AMD Secure Processor device To: Brijesh Singh , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Cc: gary.hook@amd.com, herbert@gondor.apana.org.au, davem@davemloft.net References: <20170623160630.63292-1-brijesh.singh@amd.com> <20170623160630.63292-3-brijesh.singh@amd.com> <047bd869-675c-33de-d454-7773a711266d@amd.com> <7f88d0bd-daa8-5ab0-ae73-80432d2c791d@amd.com> From: Tom Lendacky Message-ID: <7336ca67-910f-2444-80d4-3b5398e9c2d7@amd.com> Date: Wed, 28 Jun 2017 14:53:05 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <7f88d0bd-daa8-5ab0-ae73-80432d2c791d@amd.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.78.1] X-ClientProxiedBy: MWHPR1001CA0029.namprd10.prod.outlook.com (10.174.165.42) To MWHPR12MB1152.namprd12.prod.outlook.com (10.169.204.16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 24134e5b-3fdc-47df-a9ce-08d4be5f4dc0 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:MWHPR12MB1152; X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1152;3:fUjkOYUUgrUTlawqJKLmXs1RNg1Y4GuWc+8KVmvNpqStnUJ2sOYCeG+fXH2BkKTOyXVWiv9yICFfIpcNnOvtynqhts4YTMPaoSYkvISw795QkA08I9nwRg/KvXoOXLjUOWcNOB6BygtqNqeGJaS3rW10P3x4jdnWb3HQzXLBTbS11Uj42xJbCKbgGYqQ+0Q1UpD1DJafMrXgq87gBmdHWbPAV+YDYkkEAg3dGdxyG9nyg+TCR+tl5ipdUbfHmynhquFlh/xxEleoMWJ3UgwvDu3INoD0Lm1zJmwIsdz6LpkhSK10Oo/85uX1S1DJAkBVcJIekg7fvXIGeg5+j0OZdcFlsXdThQ4oag1er0srXuLyaQmL8eriDoBzI46n3tLgi4nYsv8cKfeO0gYXw3nbQwVEZQJNZP8DZpMBiTJKPO5O5BpuKwa0LFVCC9ujr+mtYRfJ7j958xL4ak0Dsmtvs/sWlOev8UgfVdUIJvJ0LoE1y/mEFkVHRe+tnNnOCvFJnjo7wb43RqckfTgudAy8MSqwshtk5cXt9GqKvXbDwGQfwCmYZc9KkrZRwP+/kw7MydWwGnLVjxPRt5iKtUjxiwYnfHJsb29AUjjYEISoSIHLiBqbga0pHuqCbgbyaLKPeZgrCGqv68mON4Kyqpqeq71MTh9HoTG0115tWrJK6o7ClkWcif7TloxPVOmrftOsKwtZGH+2H3P/Ihvwc3HNlRvblUiKWW6foEN0nYzXs+MmQ/+OL9pKzvWFySTbr/6NgSFq2i0GS9P/rzVR0CWRZQ== X-MS-TrafficTypeDiagnostic: MWHPR12MB1152: X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1152;25:Q1cPpp38xcfpyuY+SdDyrmjI9Eq9gF60tuux/jG/tANnMuwGrYkhiL0nVedTUfNCS9t0Aj7GDkupGSGZ9zJia79TPj0LzaiEpt2vCSepPtDE98L0qcfWl6CFKRMLJheKrQt05ibYLrFmEtpTu6RJodh87BKWyOhvs5cnXU6i12kXWHVJ0gNvaSLe2evS46A+6LlyMi7X4Cud7W37dXUwS1a+6/3t0QFjFC2L6yVVx88cPMnyZ6cJoGNVsZVd98F4wWoLTYqBI8l+AIBz46Gyk/q3tZP2qGifr4ogu75Hk/7rH2n5Mp9Cq0BkDzlfJap9jQT6WCMe6Gp+CutL3OqmU6JJz7l4wdQeCt3pNoGabDLrDVK0ShzhcZt4FPEQzUsbxtWAuL+UGQdTrqAFeyR18FFVj380ueR3q30rNypk2NrdWeLEiWcUXXYqEQ9Za444U+TNvsURNaAlmd+SeDWZaYavjCE+tsna3kXdK8+MOdLUI+5D2DDQWX0p+7Qa2fnkBaMneGv4zszvA4lyptRFwc+BPNEHA6nA+jYDSO/jhBYzI6IYrtDUqwcSFVarbHr0+datx/3rhbvEE3BHEPUjKeVaTFazDxY/e6f52SMi8prkx7Y5dZPcZGzxwi882qnHRLI2z/HcJTPJGfXHyTDYh5YQcxj3miKYktg01ZEG7bsAr8oSujnWIa5F/JunE/VOAuKgdUYggVOjJUNYkKzsgY/ulaZDQ1mRKj/gkBUQkBZy2pWA7PG3HLPhPbNsqJIr13jNYr0xpWCCjcyZLc/1vKizijajdFedBTrTd9CP58E0pFDm7R4ofxLeVkTrRhYs961w8ufC1kG1GF/t05UWLlUR7WEb1uusv/QWvEb9Z/uHJr69WNCdlDkjUyEGTzHP+d5fiJykLW75+Jn3/kMhI4/G4/j3+l+LLiDxKhMrd8o= X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1152;31:/T9uhx8uhOrRqMXbvyQ3ban5B+n8Q8wIXuqYD2XsRlt1a2howmNwExNSPy7Tzyb5zfcq/w9DTiMlzQs9wC5KNf18SE41l0xWQikaXfuiyGtcBAuwAxxUe8L7zhF798pjBMqBKkIfAjNKhUq/Mud1zHHBRFR2HsG6tbDwjiTZnFjXZoHYQ1p6nwNOhlmKn1NzNX28hEx3VedS3tcgOfhB0Zg5LqWUmsDmIJpGYfbP0JXCIe97fZb7NnOBCTjfAmd6zA0qtAcNz2IHhOaUYT13/FckLNI/HuRG/tAVo/abdCm9t1y0nGk/fdLVcY5oc1WWVLDqCQjYjLl+J0g5xrPufSrr7Qksiedef28acBmtR7QJU+cDLfrulDF/f2VlXRa+k1etmFXeo73c5VpcHyZdtdo5rHjN3xX85vlteQkBtWwrsskvtfYKf242jwgW5Ig7FFwhvIMWslCQJUq7GCB5KppqMlVNueVqsRP4cdYaQGzSOvsnyHLnlk1pLPI9KlKToyITgHApuzhv0PtdXpRP2mb/HOpK4E29+ygOJ6UAp6zvZ2L+Hmzmigc4V0J/mhFkMjPm2Bbz3FemI4h8O1IqYJioMEoSk0mBm5m0v+CujLaMkySLLPbDLktLK2Nlb5uchaCGStuYMWbEUNBMdTODuhaeWp+X70fvDUwo91Ellxw= X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1152;20:0RLkyM5ERlZH985FkrZMJ11gVpOeYMIGRWDhI5eFf8s2xhX8JGfqOtmxP0G/59Jzw6r36KPO47MqewexaVTamS9yUfrs0sJsDi0JyEkp2vYlEvCW3C8U/+lEOED2wJDLIU8nAHfKyh1XaS7pN/b1sEdq3BEoEJgZsqaZiU0oD5w/OCpTRzP1RjUQM9jxUuYXoAqPR3dlAHqK1TqYPRXZnkQ0dTss+VcmJ2MvaxFxtkMzVZK1xjYkXQV5SrXHp8SmuvrQQenDKYt+6iDcj81pQ+UHP9egY8j4LRtxFbc4bDLLHpzvDnuIPv/w2ldl2l67+3knrqhr2qKoqI9RuAamaa9aDOsNyeYdSEOwRLUUuocg9+f9ZVcMXiqRnElYB475LtlVWMyVFK75DMM1zAz6ubRMZsvJsrXJaa3yco805aTx6V/IKgMtGelnc01WSoo6tHJzYd59Q/Bk13aKQEDdHGc8muEwSZU3x6ashdQ25nmFdG39HBY8hQlEkKnXmxh/ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(125551606395959)(133145235818549)(236129657087228)(192374486261705)(17755550239193); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(6055026)(6041248)(20161123560025)(20161123562025)(20161123564025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:MWHPR12MB1152;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:MWHPR12MB1152; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNV0hQUjEyTUIxMTUyOzQ6SVdRZGF3cTFvaTNZQXVpbFRiakpsMTY3MXBR?= =?utf-8?B?b1FTL0Q5cmJrVGdFNyswTmFDeDR1YjYvaGtCekRnVmxJQ3lsT2dieXBKNkVN?= =?utf-8?B?NGs3QTUvVGZ4SUNveElEeDNwTTlaaTBzbE1XRnV6bW82ZkpZVC9lSnpzdTM0?= =?utf-8?B?bkZYVFZVZWpwb1pHaG5SRDZyTkhya3k0ZDk2aE5HRlZGdEo4dDRrZXF1SUdP?= =?utf-8?B?QStGODNwa1NNcDQ0bGRUUGE5RjBsWW9mZ3d5bmlWb2dKT2dpMlBlUUNVaWRP?= =?utf-8?B?Q3JHSU81THlGaHdMYy9XQ3lNd2d5eUJXeGJHRlZRblpkSk9uTUxhTDE2b1BL?= =?utf-8?B?cjR5bWpkN0JzU3VmSUIvNXcyd0ZrRVFPQ2VQL0NyVGVjZkZza1dOQnFRMnQ4?= =?utf-8?B?WjY5bGZoZ1pFdnUvTG9aZ0grOGtraGVmdTVOV1dramRwNHd5cnJIVzhOTW1a?= =?utf-8?B?M3JRT0VHVUFLdHl5cDh0WG85dmZuK0xLZTFqY2R3Uy92M2ZEaWFuSFUzbmdO?= =?utf-8?B?NlRRZ2N0SU9BKzZEbWhrR09yRGxyZjNQbFVLekQzVTY2QmVMTFdhb0lFRlhj?= =?utf-8?B?akZIYi9NK2xLS01GUVpYR2FvNVVjeldsS2lLMkVlM1J4NHNiVG9LMmE2ZFA1?= =?utf-8?B?NGYrWGQ0SURyRHpyR29xWjNQNkpGOWZlZ1pwS21wVjJIOTRtTmFmSkpTVVdO?= =?utf-8?B?NDV4UmZscDF0NExBZHE3emlXSkIyempPNWF6TkpSeFBZbmcvMTZvOXQ1VEIy?= =?utf-8?B?ejc5TnF0ZGtlUUl3SUN5RkovdlhORmI0allud1ROVWFFcGdMY0YvK1hYSzla?= =?utf-8?B?emRHZ1NXQzNFbXp0NVFETklTN2lSOXJXWXJUZG5QWGh0cU5TSzQwWWxFNXht?= =?utf-8?B?WkVHck8rOGI2WFpWNEs4RnZmelh0MTViWmJWZ3hMNWZONVNVNldSYWJOQXlo?= =?utf-8?B?OFB0RzF0OEQvMnJvSjd3WDB6R1h2WlJUSGNRV2RseUxjWVVzSHQ1QmpVTFBZ?= =?utf-8?B?bU9aKzJncXhXUHpoQnRteUdwZ2pxdTcyU1R1M1hGSVJsWlgyeUJ5Z1Y3Y1dB?= =?utf-8?B?eElyYXBMajRHZGdWQStKQ0VnL09qNUlDckZnYkpMVVZDUTBUcFFTS2xRS08w?= =?utf-8?B?Sy9VY0F6QmhDQk1zNHAyeTRYc00xYUhOMVUrTEVBTGI0bHBwVnFjR3BuWUlH?= =?utf-8?B?TzlhRm15bjlaaTNkbzN0WTdSMkMvNSsvaXVyNFRETHJwdGpXU0gzZ2RPY1U0?= =?utf-8?B?b0lDUWdSYSsxbHBORC9SU0RIb0ZUNWhpMjM2Ly9NUTRodGI3R3AzTGlPVFhN?= =?utf-8?B?NlpuWldDajBXZ0pkbDROeEtiWFYrYUNGeUhNdFVzUi9HTnhwaWtnSnZMM0dY?= =?utf-8?B?TkV1S1p4TDJZQk9xb3VsSlpDcGlId1E2c1pibWxMbXRjSEhOb3VCTStFMWtW?= =?utf-8?B?dkVTcVV4OXQ1cFNTRUNkWmI5dHRNaEZuRzZCd0FwMTJINHZDRnB2Y0xFdGdr?= =?utf-8?B?L0JJaGxiZFp5akd4a0VOQUdsMzJhdGY5a2lmTFpzYzBPQ1FYYlhHYndJbm8x?= =?utf-8?B?bEEwM1JNWjNUOWR6SnlNL2ZldmQ3czVvT0RIc0htcEVXdDVJb1g3US9MdENl?= =?utf-8?B?UEtlYXVQVlZuc0k0YmZibFZJTU00MWZ0bUEwdUZlWk9MOENybFJHRmc1dURV?= =?utf-8?B?NFo3VHkvKzg4c2dRbktEOFovMUhGc0dvNzl0OFpGcHhBZFZZSVFSczZCdjYy?= =?utf-8?B?c1phdXI4NXdyNnh0NmJvZzByN0lLZkFtVngyOEdoSVNBOWNrSWVpRDBPejJM?= =?utf-8?B?SXQ5UFlxSm9qQnpnYjM2c3hUYXNGQWhPclF4YWNMUng1QT09?= X-Forefront-PRVS: 03524FBD26 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(39840400002)(39860400002)(39850400002)(39410400002)(39400400002)(39450400003)(377454003)(24454002)(90366009)(189998001)(53546010)(83506001)(72206003)(64126003)(65826007)(23676002)(7736002)(50466002)(31696002)(229853002)(230700001)(478600001)(66066001)(65956001)(25786009)(2906002)(4001350100001)(86362001)(47776003)(42186005)(31686004)(65806001)(8676002)(77096006)(6486002)(81166006)(6246003)(93886004)(54356999)(6116002)(3846002)(76176999)(110136004)(53936002)(38730400002)(5660300001)(36756003)(6666003)(4326008)(33646002)(305945005)(50986999)(2950100002);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR12MB1152;H:[10.236.64.250];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNV0hQUjEyTUIxMTUyOzIzOk1reVBzc3VBMER3NE9URlJKYUdHekJXbkYz?= =?utf-8?B?eHdPUUtLZHNtckN2WG9PcGxKR25neDBINENDUHBHMk1tc3d0R2IzZGlGMUJp?= =?utf-8?B?b1FvTkRpSE8xMHhvWDdBdzI0eks5aHRSbWVGSnZxMWtxZUQ0dlRpWjdGcDlq?= =?utf-8?B?aTZ5ZWhEbnJ0cmg4NVcyY2tWT2VhZlRVbHRodEJQck82Qk9CVXZQS3I0ejZD?= =?utf-8?B?UHJrbDkweUlxTDkzbUxuRmVFc0psMURJYUJQd0ttd2FIY1dSdjIvMzZRUlJa?= =?utf-8?B?TXFWY2JCNE9NbElzWEpROU03c1pqODl5K1ZVb21meXIzZmJYOVhnOFRiWG1O?= =?utf-8?B?cFNVTlZoKzBOSU51MHMzSGUvVTJobFEwb294WVdud3J5ZjI2RHo4MlJVekpv?= =?utf-8?B?Z0Rpb09PMEVIcTlraFBTNVRWS0ZpcStBMStHUFhPbjVqMGVOdnA4YjhTbklW?= =?utf-8?B?MlVBMDJ5enozb015Tmp1emdzam0wNGNZR0dOT1k4TDBCR3FlTHZmdnMyOVVu?= =?utf-8?B?cVBwSGZWN0ZJLzhMQVpNMkZ4bVowSGRRVVJmVjdOTCtQVFpRRlpXNmJWZEhs?= =?utf-8?B?WnRxcW1HclRRcG1vUnpldWN6b0FST0lLalJJTnRjZUU1U1NxQ3VNZEtqN0hv?= =?utf-8?B?eXhLaHJLOUYvUjhlQ1lSalY1blFWU0tJNWZQMGMyNGtyMmdWaGk2VE5yYjlm?= =?utf-8?B?N3B2eEpGUm5VOVpJaTF1OVdwMkxZQ2VzdWkyUGtVSnBrSmJvMzFTMURiT0Vn?= =?utf-8?B?YnhVRGZyRjFNdGtERS9sVDVSdlA1WEkyaFJlU2p4OUd3czM5YUFZZmYzOENl?= =?utf-8?B?VjE0NFl2cGxHbHVPNDBYc2J0cEc3VzdIM3JPKzN2VlloaTVSVWg0NjRwT25s?= =?utf-8?B?UnhEcGdPWmNkM3hRdFRXNFkyditBWTc0WHJrcmd1Q3pOdTRDbnVpSTczWmFy?= =?utf-8?B?TGpXQW93ZjhoeUVwUW5BZ0p5SUVaU2I0cXlkbUl2eURkSVc3a0NLVVFmVXpW?= =?utf-8?B?ZFMrUmRQRDZMd1dlWlgwUEV6QnlHZ1Y4Zm1RU2VQSUZuRGx5aTF6UzhLOTJR?= =?utf-8?B?b21QVy83YWxyMFlOU0ZxUlhmb1JSTllHcmhTdmtUYzkwaWpZRWdzbVEvaDZS?= =?utf-8?B?a2xoZ0hQdG1ZV1FEcTlzdHdCUTFYTWttZmdGd3htMjRuZ244WUZOcEgvd0N5?= =?utf-8?B?NEw0TUNTU1VRYWc3bFNUYVg2anFaWTF1L3prb2FDQklmTWNUbmhIZzFtZ05Q?= =?utf-8?B?NnhDajZoSnpteVd3bzhtb0wveENad0tjUjlyd01FcXhLQ0ZvSWZCVGRJVWRR?= =?utf-8?B?cUozV0ZiL0w5bW8yN1QwSXFOS25XeDdBN2tYalZwQUxWOFFTUFJOOEc2bjVS?= =?utf-8?B?VC9OeSs2TnZ5dTB6S0ZocjRUOWpPS2tCd0dMUzkwQ3pETm56Q1VrOE95L3Ur?= =?utf-8?B?aW51N0owUFRkNDRUK3RJNVhXTW5CNFV4emNZcVZ3RWl5THQveHpJYWE0ZlRT?= =?utf-8?B?cFZKK3Vldmdwa1Y1VnQyUlo4NzRkbDE5NS9uUWNWRXNXTHRqMUJ6Sm1PbTg0?= =?utf-8?B?TlMzbXU2RnphZjduMnczcUxBMVZ5dmR5T1lVVitFMEJMcWdUTUNzWm95eThI?= =?utf-8?B?anhjS3lIOXd5cTBNdWZNRFJaTTVNeGRRejFCT3JEWFFpMkpydGxSWCtlbFdB?= =?utf-8?B?a2U3dVExRkpmQ0RWVktkbldLMHpPWUlGeVlhQVFJK2pkRWlHa3FoZ3Q2cW40?= =?utf-8?B?ZFYySGZYTTI0cXphYnBINzlYZEpBdnc1MnQwTHlvNnpkMVdrV1BCOU9Sb1E4?= =?utf-8?B?VGJVczh4cE80cjR0b3BXWThSK1JxNHdOU1JwZVFyNUM2NXRYRzBjMVFzdTBK?= =?utf-8?Q?a/ri67M+Efs=3D?= X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNV0hQUjEyTUIxMTUyOzY6TDJWTUFOeGl0Ui8vUzdaV0o1cUZYVXlUMW1G?= =?utf-8?B?RWg5L0NuNW1RYVIzZzNEMm80ZkJlUGlOeHlZSFZFZThlOFpBdU1mbnRoWmh0?= =?utf-8?B?MnEvbXhINEdPRDd6akcwd1lzdUZwbDJVTDhwR3pVaXZxdjZmWFZ2a1pKLzFV?= =?utf-8?B?YXdXaUZVeENaNFVFZExhN1huU09uMDRBSzBZb1RtbGhMNkxsQ0tVZFRtUmVR?= =?utf-8?B?bUVFVmg2QlowUS9nWExVbkUwT2lLZ0hMblBMZHlNQkhSbG4vU0Y3R0hYbE04?= =?utf-8?B?WFVqTHl5ay9UZkhCZ0FNS2hEdmVIM3RHU0NNV2w3KzdXS0k5czJTWXBtcGxz?= =?utf-8?B?OHl0QmZRUTV6MUxMdXhZa0NKVmhyREZGYnM3MnM5cGw5RXU2N2ExUGFqN21F?= =?utf-8?B?SzA0blR0YVY5K1ZTTElYNG0yUmdEZXowaThXcTBNQ1RORVVmZzNBUEpnQVI2?= =?utf-8?B?LzYxRVZlbFhlWHRNNnE1YSs2RGFkaTBlU2VxTzZKMFJjR25HUmloSVhSWXFm?= =?utf-8?B?ZFgwb3h6dmluUjFSVnI2S3lwbHZqRkNLaWtWRjBqN0grVzZFYmhMdHlyZXd2?= =?utf-8?B?MVowVVJaOHFhY21CUzlwZXZiTDBhRHRPdmhIdmg1L1BsZHdpR2NzcjQrTk9w?= =?utf-8?B?bk5RQTJqUGF4TnpKbG9zMzRkaUx0YUNKN0w1NEo0UEJqdmE2amliL2lLbzVk?= =?utf-8?B?RGxBUnJ6UDlUcVhyNnZQZ0lEN1BtVW5UdUpvdy9JNWMvdTFwMmtCYXlFUEUx?= =?utf-8?B?UFIvK0N2WWJ1Y2xTYjVPcS9SL2Nwak1pVUZDK2w5Ylo4YlRLOWZObGZVMGZ6?= =?utf-8?B?czRvVUVLL2FlSnlabldXTmlOVXBrMjZoMkFaMFMveXVkTUlNdG5QekkycmRP?= =?utf-8?B?clZnNWh2dnREZnNYcU5WSEo2M3JYSUE2b3o3VXJSbW5WaTl2Y2VpOUcyL0dr?= =?utf-8?B?bUtTOFpLUzExdVpSZ0I1WkRtVG16YXFnRjg4VW5oRHlrdDBoQzAvUHR5Ulll?= =?utf-8?B?dDM1VURqZndEMlpiMUVOaUUzVnpBenRUTUEzbkJnd1VQMkxxKzcyUkhsK3FW?= =?utf-8?B?OTZjN2E2M2s0bUNWVW5vWmNlOTZBM01vTXZ6ODlsdXBKZzJ1aXFNYmd3WHFa?= =?utf-8?B?Nk8rZVp0SVN1NDBXak10N2c0azRZVXJmVDVESkpHa0Rlay9SN2dkY2h0OWNG?= =?utf-8?B?TUd2Y3NFTzk2Rjc4SHFlaEF0c3VlRUQ1ZGhHTWxxV3FQMWpIeHFraXpNUmo0?= =?utf-8?B?cGF3aXl0UG0rNHJHOTVlVlNWRzc1ZW1FcW9QVUFzUkpvakY4Uys4OVcySHpw?= =?utf-8?B?YXVSNDE0T3YwcmlNUmFycWIrelQzZGRLZXZSSXlNZE9DaVlqWlpYRndTQTR3?= =?utf-8?Q?nc+duwq?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1152;5:yA80dmYlG4uc8KhUJUOaURPKwLt9O2YuG0mTH4oT+O7b0D+PBlCfX29q12hEG246E0idTG4BCQWWX6Lsc8KQWlmtcj6lgTph+9+gu0BN+XvNy9ibPd6q5wnZf6C1FXE/AMKrhCO2qWo1LuLwkYbkOGjy19mKorKHknPSTA6xjJHZqasjwEXM5peak1W3lOCAKlHxrI0nl6a1zX94dezTlnyl+LyJ2+HbGZuB5SGotdYtV0nZEPP2a+c6J1QJCOdzYBJJdqVV3BT4ydI8kSwQg2Err/4yBgbn2Zq1+qS18CnjqqhRGsnVHePjXv8CxkHnBkswacSzgE+LylZiq1NoXoeyAGcmnOBj8GSo2GZ7IU1rO6g+GVMTbOsAhJiZl0GDc1Hj+FWK1oRw52v/A4LGgioBXSh5bfTzWrKwonGuZ7QpZXYRLOiof+RgewLE3jcBe7/5JyEuMpZLd0zo/X4D91AY29KZj1jFGsynenpr+8An1akWwum1ewsPLHOhX658;24:1v7C175MDHuhVH4oNhrgDfJ3ZT7oC5ZAj4Jp19lLvMKpZuY4C7bPGwtm8GuTFhjX0Nf8w3ihPAl1huiNA+cMTC3E/73wvHtQhfFE3rgzzQs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1152;7:rf2VkzsDNlxCXx7MvYeWRl1/N3/3XCN1AVkrAd5UfrgPgjeDGwXZd+1M8RB9JleibQqXjRhj0OS+eqNTmJ7i0hOY7eFWVCO3Ohx4MEqHeNODnNDmhX7vBau9azzRTqjWTZcw8O/R2N7c7M4q+rowS6EEpKJsU+/069l/pz2tmgY6nGvMSt+C+hNHPm9vHpXG0rqeFb9woa4aren8hvQxVsLRUJJA4H+5jVW0LmfwsC5fTMtr0NDzQJv4gCjlQo9MuTBzqvjOTK2GK0zAPPRAlItXDPcWxIUO0tliJLJ1hjcVzNrgb3a2mH9b8d60wz2edyR7d15lsYOZFAbdG92ztCA8GII0Tty+OG49kHuG22UZqXeuBKQ0j/UozOvgWGx00zL4Vzv5tv2OYISQzZxNXfftc85H65XYgQDEgfstZ9uo7rPmVkBE+vzQUzIsWJmDThNXt5C/VA96CfM2AFA9e5StNkXtzPiWkya4OCybJV8eReXqsos4BrLePJUNjIhb9p6wXwQRBusko110M+A5mzA9PxVdiat2vGaBUGdOf0rFlALYQ2gDuY97xCfilOgkZtYNmqJ0yM4u5zmpSItFBp1ULqiLj7cjr1J7DHSo+afsWlrLIUVabXb1ZCUraiHj49+LPICUFKzNkJUDqcbE6DWIa/ml+0F+9wRsj/e5WcK/sm0EzT6AtSXl9M0M088CNi3iV6DQDyLni1dZfkL+mHlqGuxkAvxswrA+a9+BhqsXny3XHvK3k3QxZDESnvPhDN21+lxI5Y6fgjrQ5v/fl9dUJuLP7X7DCpUe3vzOjCU= X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1152;20:3SEZxMbGx3b2awH51xoRTtSD6HKaFC656VZfUAzShUao+MahgHT3zerZ8usTLVC3J92QUkRB4sd4kM+v61hzhBHgwrjtgnYblQtGg+5umOQAbMxQe0i/h33ZSCes2eXq+vYdJXerp3e6Rq5Q/As6VHmga/dB7jOOXQsZCMYNi3YE7ONGtwKanyXeZ3awAb8Xb3jZ0VQe26zV/lpn0tsAqGkNf4xySSlTSPT9sRHDVo48S1+Cqg9/Y0ZlYrYHvPVb X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2017 19:53:09.5990 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1152 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/28/2017 2:39 PM, Brijesh Singh wrote: > > > On 06/28/2017 12:47 PM, Tom Lendacky wrote: >>> >>> diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig >>> index 0528a62..418f991 100644 >>> --- a/drivers/crypto/Kconfig >>> +++ b/drivers/crypto/Kconfig >>> @@ -512,14 +512,14 @@ config CRYPTO_DEV_ATMEL_SHA >>> To compile this driver as a module, choose M here: the module >>> will be called atmel-sha. >>> -config CRYPTO_DEV_CCP >>> - bool "Support for AMD Cryptographic Coprocessor" >>> +config CRYPTO_DEV_SP >>> + bool "Support for AMD Secure Processor" >>> depends on ((X86 && PCI) || (ARM64 && (OF_ADDRESS || ACPI))) && >>> HAS_IOMEM >>> help >>> - The AMD Cryptographic Coprocessor provides hardware offload >>> support >>> - for encryption, hashing and related operations. >>> + The AMD Secure Processor provides hardware offload support for >>> memory >>> + encryption in virtualization and cryptographic hashing and >>> related operations. >>> -if CRYPTO_DEV_CCP >>> +if CRYPTO_DEV_SP >>> source "drivers/crypto/ccp/Kconfig" >>> endif >>> diff --git a/drivers/crypto/ccp/Kconfig b/drivers/crypto/ccp/Kconfig >>> index 2238f77..bc08f03 100644 >>> --- a/drivers/crypto/ccp/Kconfig >>> +++ b/drivers/crypto/ccp/Kconfig >>> @@ -1,26 +1,37 @@ >>> -config CRYPTO_DEV_CCP_DD >>> - tristate "Cryptographic Coprocessor device driver" >>> - depends on CRYPTO_DEV_CCP >>> - default m >>> - select HW_RANDOM >>> - select DMA_ENGINE >>> - select DMADEVICES >>> - select CRYPTO_SHA1 >>> - select CRYPTO_SHA256 >>> - help >>> - Provides the interface to use the AMD Cryptographic Coprocessor >>> - which can be used to offload encryption operations such as SHA, >>> - AES and more. If you choose 'M' here, this module will be called >>> - ccp. >>> - >>> config CRYPTO_DEV_CCP_CRYPTO >>> tristate "Encryption and hashing offload support" >>> - depends on CRYPTO_DEV_CCP_DD >>> + depends on CRYPTO_DEV_SP_DD >>> default m >>> select CRYPTO_HASH >>> select CRYPTO_BLKCIPHER >>> select CRYPTO_AUTHENC >>> + select CRYPTO_DEV_CCP >>> help >>> Support for using the cryptographic API with the AMD >>> Cryptographic >>> Coprocessor. This module supports offload of SHA and AES >>> algorithms. >>> If you choose 'M' here, this module will be called ccp_crypto. >>> + >>> +config CRYPTO_DEV_SP_DD >>> + tristate "Secure Processor device driver" >>> + depends on CRYPTO_DEV_SP >>> + default m >>> + help >>> + Provides the interface to use the AMD Secure Processor. The >>> + AMD Secure Processor support the Platform Security Processor >>> (PSP) >>> + and Cryptographic Coprocessor (CCP). If you choose 'M' here, this >>> + module will be called ccp. >>> + >>> +if CRYPTO_DEV_SP_DD >>> +config CRYPTO_DEV_CCP >>> + bool "Cryptographic Coprocessor interface" >>> + default y >>> + select HW_RANDOM >>> + select DMA_ENGINE >>> + select DMADEVICES >>> + select CRYPTO_SHA1 >>> + select CRYPTO_SHA256 >>> + help >>> + Provides the interface to use the AMD Cryptographic Coprocessor >>> + which can be used to offload encryption operations such as SHA, >>> + AES and more. >>> +endif >> >> I think the Kconfig changes need to be looked at a bit closer. The >> hierarchy of original version is changed and the number of entries >> might be able to be reduced. >> > > Thanks Tom, how about the below patch? > > In this I am leaving the top level config as-is and adding > CONFIG_CRYPTO_DEV_SP_CCP to enable the CCP device support inside the SP > device driver. > > [*] Support for AMD Secure Processor > Secure Processor device driver > Encryption and hashing offload support > -*- Cryptographic Coprocessor device I think the "Encryption and hashing offload support" should be indented under "Cryptographic Coprocessor device" since it is a function of the CCP and not the SP. Not sure if we can remove a level of menu somehow, something to explore. Thanks, Tom > > > diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig > index 0528a62..148b516 100644 > --- a/drivers/crypto/Kconfig > +++ b/drivers/crypto/Kconfig > @@ -513,11 +513,11 @@ config CRYPTO_DEV_ATMEL_SHA > will be called atmel-sha. > > config CRYPTO_DEV_CCP > - bool "Support for AMD Cryptographic Coprocessor" > + bool "Support for AMD Secure Processor" > depends on ((X86 && PCI) || (ARM64 && (OF_ADDRESS || ACPI))) && > HAS_IOMEM > help > - The AMD Cryptographic Coprocessor provides hardware offload > support > - for encryption, hashing and related operations. > + The AMD Secure Processor provides hardware offload support for > memory > + encryption in virtualization and cryptographic hashing and > related operations. > > if CRYPTO_DEV_CCP > source "drivers/crypto/ccp/Kconfig" > diff --git a/drivers/crypto/ccp/Kconfig b/drivers/crypto/ccp/Kconfig > index 2238f77..ef3a5fb 100644 > --- a/drivers/crypto/ccp/Kconfig > +++ b/drivers/crypto/ccp/Kconfig > @@ -1,26 +1,34 @@ > config CRYPTO_DEV_CCP_DD > - tristate "Cryptographic Coprocessor device driver" > - depends on CRYPTO_DEV_CCP > + tristate "Secure Processor device driver" > default m > - select HW_RANDOM > - select DMA_ENGINE > - select DMADEVICES > - select CRYPTO_SHA1 > - select CRYPTO_SHA256 > help > - Provides the interface to use the AMD Cryptographic Coprocessor > - which can be used to offload encryption operations such as SHA, > - AES and more. If you choose 'M' here, this module will be called > - ccp. > + Provides AMD Secure Processor device driver. > + If you choose 'M' here, this module will be called ccp. > + > +if CRYPTO_DEV_CCP_DD > > config CRYPTO_DEV_CCP_CRYPTO > tristate "Encryption and hashing offload support" > - depends on CRYPTO_DEV_CCP_DD > default m > select CRYPTO_HASH > select CRYPTO_BLKCIPHER > select CRYPTO_AUTHENC > + select CRYPTO_DEV_SP_CCP > help > Support for using the cryptographic API with the AMD > Cryptographic > Coprocessor. This module supports offload of SHA and AES > algorithms. > If you choose 'M' here, this module will be called ccp_crypto. > + > +config CRYPTO_DEV_SP_CCP > + bool "Cryptographic Coprocessor device" > + default y > + select HW_RANDOM > + select DMA_ENGINE > + select DMADEVICES > + select CRYPTO_SHA1 > + select CRYPTO_SHA256 > + help > + Provides the support for AMD Cryptographic Coprocessor (CCP) > device > + which can be used to offload encryption operations such as > SHA, AES > + and more. > +endif > diff --git a/drivers/crypto/ccp/Makefile b/drivers/crypto/ccp/Makefile > index 59493fd..d2f1b52 100644 > --- a/drivers/crypto/ccp/Makefile > +++ b/drivers/crypto/ccp/Makefile > @@ -1,9 +1,9 @@ > obj-$(CONFIG_CRYPTO_DEV_CCP_DD) += ccp.o > -ccp-objs := ccp-dev.o \ > +ccp-objs := sp-dev.o ccp-platform.o > +ccp-$(CONFIG_CRYPTO_DEV_SP_CCP) += ccp-dev.o \ > ccp-ops.o \ > ccp-dev-v3.o \ > ccp-dev-v5.o \ > - ccp-platform.o \ > ccp-dmaengine.o \ > ccp-debugfs.o > ccp-$(CONFIG_PCI) += ccp-pci.o