Re: [PATCH net-next] net: ibm/emac: Constify struct mii_phy_def

[Christophe JAILLET <christophe.jaillet@wanadoo.fr>]

Le 08/08/2024 à 01:00, kernel test robot a écrit :
> Hi Christophe,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on net-next/main]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Christophe-JAILLET/net-ibm-emac-Constify-struct-mii_phy_def/20240807-195146
> base:   net-next/main
> patch link:    https://lore.kernel.org/r/dfc7876d660d700a840e64c35de0a6519e117539.1723031352.git.christophe.jaillet%40wanadoo.fr
> patch subject: [PATCH net-next] net: ibm/emac: Constify struct mii_phy_def
> config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive/20240808/202408080631.rKnoa41D-lkp@intel.com/config)
> compiler: powerpc64-linux-gcc (GCC) 14.1.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240808/202408080631.rKnoa41D-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202408080631.rKnoa41D-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>     drivers/net/ethernet/ibm/emac/core.c: In function 'emac_dt_phy_connect':
>>> drivers/net/ethernet/ibm/emac/core.c:2648:30: error: assignment of member 'phy_id' in read-only object
>      2648 |         dev->phy.def->phy_id = dev->phy_dev->drv->phy_id;
>           |                              ^
>>> drivers/net/ethernet/ibm/emac/core.c:2649:35: error: assignment of member 'phy_id_mask' in read-only object
>      2649 |         dev->phy.def->phy_id_mask = dev->phy_dev->drv->phy_id_mask;
>           |                                   ^
>>> drivers/net/ethernet/ibm/emac/core.c:2650:28: error: assignment of member 'name' in read-only object
>      2650 |         dev->phy.def->name = dev->phy_dev->drv->name;
>           |                            ^
>>> drivers/net/ethernet/ibm/emac/core.c:2651:27: error: assignment of member 'ops' in read-only object
>      2651 |         dev->phy.def->ops = &emac_dt_mdio_phy_ops;
>           |                           ^
>     drivers/net/ethernet/ibm/emac/core.c: In function 'emac_init_phy':
>>> drivers/net/ethernet/ibm/emac/core.c:2818:32: error: assignment of member 'features' in read-only object
>      2818 |         dev->phy.def->features &= ~dev->phy_feat_exc;
>           |                                ^~
> 
> 

Ouch,

I missed the depends on PPC_DCR.

I did:
    - make -j8 drivers/net/ethernet/ibm/emac/phy.o
then
    - make -j8 drivers/net/ethernet/ibm/emac/

but the later does not build anything on x86, and I missed that.

CJ