From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964963AbcHBMg0 (ORCPT ); Tue, 2 Aug 2016 08:36:26 -0400 Received: from mx2.suse.de ([195.135.220.15]:53591 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935091AbcHBMgN (ORCPT ); Tue, 2 Aug 2016 08:36:13 -0400 Subject: Re: [PATCH 0829/1285] Replace numeric parameter like 0444 with macro To: Baole Ni References: <20160802115027.5246-1-baolex.ni@intel.com> Cc: linux-kernel@vger.kernel.org From: Juergen Gross X-Enigmail-Draft-Status: N1110 Message-ID: <733db41f-a76e-6aa2-96a5-b1e31f126df6@suse.com> Date: Tue, 2 Aug 2016 14:36:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <20160802115027.5246-1-baolex.ni@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/08/16 13:50, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > > Signed-off-by: Chuansheng Liu > Signed-off-by: Baole Ni This is the worst series of lkml spam I've ever received! 1. Make something like this a series in one thread, not 1285 single threads! Add a cover letter. 2. Don't write one patch per source file, one per subsystem is enough. Maybe even better: make a tree-wide patch using Coccinelle. 3. Use better subjects. I want to see the subsystem the patch is modifying. 4. Use _correct_ maintainers. WTF do I have to do with pcmcia? Juergen